From f0b6abe439928eb1ec89eb9167deb5d60f5f2cc3 Mon Sep 17 00:00:00 2001 From: javanna Date: Tue, 21 Jun 2016 17:10:18 +0200 Subject: [PATCH] rename onSuccess to onResponse That makes it a bit clearer that it's about the response and whether we decide if it was a good one or a failure (based on status code) --- .../src/main/java/org/elasticsearch/client/RestClient.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/client/src/main/java/org/elasticsearch/client/RestClient.java b/client/src/main/java/org/elasticsearch/client/RestClient.java index 9baafb2b5b7..a8f46ee6b0e 100644 --- a/client/src/main/java/org/elasticsearch/client/RestClient.java +++ b/client/src/main/java/org/elasticsearch/client/RestClient.java @@ -171,7 +171,7 @@ public final class RestClient implements Closeable { int statusCode = response.getStatusLine().getStatusCode(); if (statusCode < 300 || (request.getMethod().equals(HttpHead.METHOD_NAME) && statusCode == 404) ) { RequestLogger.logResponse(logger, request, host, httpResponse); - onSuccess(host); + onResponse(host); return response; } RequestLogger.logResponse(logger, request, host, httpResponse); @@ -195,7 +195,7 @@ public final class RestClient implements Closeable { break; default: //mark host alive and don't retry, as the error should be a request problem - onSuccess(host); + onResponse(host); throw lastSeenException; } } @@ -254,7 +254,7 @@ public final class RestClient implements Closeable { * Called after each successful request call. * Receives as an argument the host that was used for the successful request. */ - private void onSuccess(HttpHost host) { + private void onResponse(HttpHost host) { DeadHostState removedHost = this.blacklist.remove(host); if (logger.isDebugEnabled() && removedHost != null) { logger.debug("removed host [" + host + "] from blacklist");