INGEST: Remove Outdated TODOs (#33458)
* CompoundProcessor is in the ingest package now -> resolved * Java generics don't offer type checking so nothing can be done here -> remvoed TODO and test * #16019 was closed and not acted on -> todo can go away
This commit is contained in:
parent
ab9e2cddf1
commit
f27c3dcf88
|
@ -16,7 +16,6 @@
|
|||
* specific language governing permissions and limitations
|
||||
* under the License.
|
||||
*/
|
||||
//TODO(simonw): can all these classes go into org.elasticsearch.ingest?
|
||||
|
||||
package org.elasticsearch.ingest;
|
||||
|
||||
|
|
|
@ -92,12 +92,6 @@ public class ConfigurationUtilsTests extends ESTestCase {
|
|||
}
|
||||
}
|
||||
|
||||
// TODO(talevy): Issue with generics. This test should fail, "int" is of type List<Integer>
|
||||
public void testOptional_InvalidType() {
|
||||
List<String> val = ConfigurationUtils.readList(null, null, config, "int");
|
||||
assertThat(val, equalTo(Collections.singletonList(2)));
|
||||
}
|
||||
|
||||
public void testReadStringOrIntProperty() {
|
||||
String val1 = ConfigurationUtils.readStringOrIntProperty(null, null, config, "foo", null);
|
||||
String val2 = ConfigurationUtils.readStringOrIntProperty(null, null, config, "num", null);
|
||||
|
|
|
@ -60,7 +60,6 @@ public class IngestClientIT extends ESIntegTestCase {
|
|||
|
||||
@Override
|
||||
protected Settings nodeSettings(int nodeOrdinal) {
|
||||
// TODO: Remove this method once gets in: https://github.com/elastic/elasticsearch/issues/16019
|
||||
if (nodeOrdinal % 2 == 0) {
|
||||
return Settings.builder().put("node.ingest", false).put(super.nodeSettings(nodeOrdinal)).build();
|
||||
}
|
||||
|
|
Loading…
Reference in New Issue