From f38d6f8a1b7b15810cfa12917bbd75e6b2cb54a2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Benjamin=20Deve=CC=80ze?= Date: Sat, 22 Feb 2014 17:24:01 +0100 Subject: [PATCH] Minor improvements to Table class and add tests --- .../java/org/elasticsearch/common/Table.java | 17 +- .../org/elasticsearch/common/TableTests.java | 153 ++++++++++++++++++ 2 files changed, 166 insertions(+), 4 deletions(-) create mode 100644 src/test/java/org/elasticsearch/common/TableTests.java diff --git a/src/main/java/org/elasticsearch/common/Table.java b/src/main/java/org/elasticsearch/common/Table.java index a40bb33b6f8..dddc5d7bcdd 100644 --- a/src/main/java/org/elasticsearch/common/Table.java +++ b/src/main/java/org/elasticsearch/common/Table.java @@ -21,7 +21,7 @@ package org.elasticsearch.common; import com.google.common.collect.ImmutableMap; import com.google.common.collect.Maps; -import org.elasticsearch.ElasticsearchIllegalArgumentException; +import org.elasticsearch.ElasticsearchIllegalStateException; import java.util.ArrayList; import java.util.HashMap; @@ -46,6 +46,9 @@ public class Table { } public Table endHeaders() { + if (currentCells == null || currentCells.isEmpty()) { + throw new ElasticsearchIllegalStateException("no headers added..."); + } inHeaders = false; headers = currentCells; currentCells = null; @@ -70,20 +73,23 @@ public class Table { public Table startRow() { if (headers.isEmpty()) { - throw new ElasticsearchIllegalArgumentException("no headers added..."); + throw new ElasticsearchIllegalStateException("no headers added..."); } currentCells = new ArrayList(headers.size()); return this; } public Table endRow(boolean check) { + if (currentCells == null) { + throw new ElasticsearchIllegalStateException("no row started..."); + } if (check && (currentCells.size() != headers.size())) { StringBuilder s = new StringBuilder(); s.append("mismatch on number of cells "); s.append(currentCells.size()); s.append(" in a row compared to header "); s.append(headers.size()); - throw new ElasticsearchIllegalArgumentException(s.toString()); + throw new ElasticsearchIllegalStateException(s.toString()); } rows.add(currentCells); currentCells = null; @@ -100,9 +106,12 @@ public class Table { } public Table addCell(Object value, String attributes) { + if (currentCells == null) { + throw new ElasticsearchIllegalStateException("no block started..."); + } if (!inHeaders) { if (currentCells.size() == headers.size()) { - throw new ElasticsearchIllegalArgumentException("can't add more cells to a row than the header"); + throw new ElasticsearchIllegalStateException("can't add more cells to a row than the header"); } } Map mAttr; diff --git a/src/test/java/org/elasticsearch/common/TableTests.java b/src/test/java/org/elasticsearch/common/TableTests.java new file mode 100644 index 00000000000..919e1c4dd51 --- /dev/null +++ b/src/test/java/org/elasticsearch/common/TableTests.java @@ -0,0 +1,153 @@ +/* + * Licensed to Elasticsearch under one or more contributor + * license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright + * ownership. Elasticsearch licenses this file to you under + * the Apache License, Version 2.0 (the "License"); you may + * not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.elasticsearch.common; + +import org.elasticsearch.ElasticsearchIllegalStateException; +import org.elasticsearch.test.ElasticsearchTestCase; +import org.junit.Test; + +import java.util.List; +import java.util.Map; + +public class TableTests extends ElasticsearchTestCase { + + @Test(expected = ElasticsearchIllegalStateException.class) + public void testFailOnStartRowWithoutHeader() { + Table table = new Table(); + table.startRow(); + } + + @Test(expected = ElasticsearchIllegalStateException.class) + public void testFailOnEndHeadersWithoutStart() { + Table table = new Table(); + table.endHeaders(); + } + + @Test(expected = ElasticsearchIllegalStateException.class) + public void testFailOnAddCellWithoutHeader() { + Table table = new Table(); + table.addCell("error"); + } + + @Test(expected = ElasticsearchIllegalStateException.class) + public void testFailOnAddCellWithoutRow() { + Table table = this.getTableWithHeaders(); + table.addCell("error"); + } + + @Test(expected = ElasticsearchIllegalStateException.class) + public void testFailOnEndRowWithoutStart() { + Table table = this.getTableWithHeaders(); + table.endRow(); + } + + @Test(expected = ElasticsearchIllegalStateException.class) + public void testFailOnLessCellsThanDeclared() { + Table table = this.getTableWithHeaders(); + table.startRow(); + table.addCell("foo"); + table.endRow(true); + } + + @Test + public void testOnLessCellsThanDeclaredUnchecked() { + Table table = this.getTableWithHeaders(); + table.startRow(); + table.addCell("foo"); + table.endRow(false); + } + + @Test(expected = ElasticsearchIllegalStateException.class) + public void testFailOnMoreCellsThanDeclared() { + Table table = this.getTableWithHeaders(); + table.startRow(); + table.addCell("foo"); + table.addCell("bar"); + table.addCell("foobar"); + } + + @Test + public void testSimple() { + Table table = this.getTableWithHeaders(); + table.startRow(); + table.addCell("foo1"); + table.addCell("bar1"); + table.endRow(); + table.startRow(); + table.addCell("foo2"); + table.addCell("bar2"); + table.endRow(); + + // Check headers + List headers = table.getHeaders(); + assertEquals(2, headers.size()); + assertEquals("foo", headers.get(0).value.toString()); + assertEquals(2, headers.get(0).attr.size()); + assertEquals("f", headers.get(0).attr.get("alias")); + assertEquals("foo", headers.get(0).attr.get("desc")); + assertEquals("bar", headers.get(1).value.toString()); + assertEquals(2, headers.get(1).attr.size()); + assertEquals("b", headers.get(1).attr.get("alias")); + assertEquals("bar", headers.get(1).attr.get("desc")); + + // Check rows + List> rows = table.getRows(); + assertEquals(2, rows.size()); + List row = rows.get(0); + assertEquals("foo1", row.get(0).value.toString()); + assertEquals("bar1", row.get(1).value.toString()); + row = rows.get(1); + assertEquals("foo2", row.get(0).value.toString()); + assertEquals("bar2", row.get(1).value.toString()); + + // Check getAsMap + Map> map = table.getAsMap(); + assertEquals(2, map.size()); + row = map.get("foo"); + assertEquals("foo1", row.get(0).value.toString()); + assertEquals("foo2", row.get(1).value.toString()); + row = map.get("bar"); + assertEquals("bar1", row.get(0).value.toString()); + assertEquals("bar2", row.get(1).value.toString()); + + // Check getHeaderMap + Map headerMap = table.getHeaderMap(); + assertEquals(2, headerMap.size()); + Table.Cell cell = headerMap.get("foo"); + assertEquals("foo", cell.value.toString()); + cell = headerMap.get("bar"); + assertEquals("bar", cell.value.toString()); + + // Check findHeaderByName + cell = table.findHeaderByName("foo"); + assertEquals("foo", cell.value.toString()); + cell = table.findHeaderByName("missing"); + assertNull(cell); + } + + private Table getTableWithHeaders() { + Table table = new Table(); + table.startHeaders(); + table.addCell("foo", "alias:f;desc:foo"); + table.addCell("bar", "alias:b;desc:bar"); + table.endHeaders(); + return table; + } +}