From f48981f43c34545cc072be9201cd6f6eeb9ac55c Mon Sep 17 00:00:00 2001 From: Martijn van Groningen <martijn.v.groningen@gmail.com> Date: Mon, 14 Oct 2019 14:34:09 +0200 Subject: [PATCH] Remove redundant nested operator in builtin grok expression. (#47870) This prevents the following warning from being printed to console: `regular expression has redundant nested repeat operator + /%\{(?<name>(?<pattern>[A-z0-9]+)(?::(?<subname>[[:alnum:]@\[\]_:.-]+))?)(?:=(?<definition>(?:(?:[^{}]+|\.+)+)+))?\}/` The current grok expression is not failing, but just this warning is being printed. The warning started being printed after upgrading joni (#47374). Closes #47861 --- libs/grok/src/main/java/org/elasticsearch/grok/Grok.java | 2 -- 1 file changed, 2 deletions(-) diff --git a/libs/grok/src/main/java/org/elasticsearch/grok/Grok.java b/libs/grok/src/main/java/org/elasticsearch/grok/Grok.java index 07f75fd995b..a7a9a4a6f55 100644 --- a/libs/grok/src/main/java/org/elasticsearch/grok/Grok.java +++ b/libs/grok/src/main/java/org/elasticsearch/grok/Grok.java @@ -55,9 +55,7 @@ public final class Grok { "(?::(?<subname>[[:alnum:]@\\[\\]_:.-]+))?" + ")" + "(?:=(?<definition>" + - "(?:" + "(?:[^{}]+|\\.+)+" + - ")+" + ")" + ")?" + "\\}"; private static final Regex GROK_PATTERN_REGEX = new Regex(GROK_PATTERN.getBytes(StandardCharsets.UTF_8), 0,