From f65125df55e901cab29b4c22d1eb657c2beff14d Mon Sep 17 00:00:00 2001 From: David Roberts Date: Mon, 19 Dec 2016 16:24:45 +0000 Subject: [PATCH] No point rethrowing exception in thread pool task It will just get logged twice, but with a less useful message the second time Original commit: elastic/x-pack-elasticsearch@7d32f65cc14826645af72dcd2c6be8dde89389ea --- .../job/process/normalizer/ShortCircuitingRenormalizer.java | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/elasticsearch/src/main/java/org/elasticsearch/xpack/prelert/job/process/normalizer/ShortCircuitingRenormalizer.java b/elasticsearch/src/main/java/org/elasticsearch/xpack/prelert/job/process/normalizer/ShortCircuitingRenormalizer.java index 82df98b4c23..db31ce820ee 100644 --- a/elasticsearch/src/main/java/org/elasticsearch/xpack/prelert/job/process/normalizer/ShortCircuitingRenormalizer.java +++ b/elasticsearch/src/main/java/org/elasticsearch/xpack/prelert/job/process/normalizer/ShortCircuitingRenormalizer.java @@ -148,13 +148,12 @@ public class ShortCircuitingRenormalizer implements Renormalizer { // Loop if more work has become available while we were working, because the // tasks originally submitted to do that work will have exited early. } while (tryFinishWork() == false); - } catch (RuntimeException e) { + } catch (Exception e) { LOGGER.error("[" + jobId + "] Normalization failed", e); if (latch != null) { latch.countDown(); } forceFinishWork(); - throw e; } }