honeymoose
/
OpenSearch
mirror of https://github.com/honeymoose/OpenSearch.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

[TEST] Relax constraints of breaker tests even more 

They were very stringent, and add values in worst-case situations. The
new values are acceptable while still testing the functionality of the
breaker.
This commit is contained in:
Lee Hinman 2014-11-28 15:10:55 +01:00
parent 256712640f
commit f9d7e76928
1 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/test/java/org/elasticsearch/common/breaker/MemoryCircuitBreakerTests.java
View File

@ -78,8 +78,8 @@ public class MemoryCircuitBreakerTests extends ElasticsearchTestCase {
}
assertThat("no other exceptions were thrown", lastException.get(), equalTo(null));
assertThat("breaker was tripped exactly once", tripped.get(), equalTo(true));
assertThat("breaker was tripped exactly once", breaker.getTrippedCount(), equalTo(1L));
assertThat("breaker was tripped", tripped.get(), equalTo(true));
assertThat("breaker was tripped at least once", breaker.getTrippedCount(), greaterThanOrEqualTo(1L));
}
@Test
@ -136,8 +136,8 @@ public class MemoryCircuitBreakerTests extends ElasticsearchTestCase {
}
assertThat("no other exceptions were thrown", lastException.get(), equalTo(null));
assertThat("breaker was tripped exactly once", tripped.get(), equalTo(true));
assertThat("breaker was tripped exactly once", breaker.getTrippedCount(), equalTo(1L));
assertThat("breaker was tripped", tripped.get(), equalTo(true));
assertThat("breaker was tripped at least once", breaker.getTrippedCount(), greaterThanOrEqualTo(1L));
}
@Test
@ -204,12 +204,12 @@ public class MemoryCircuitBreakerTests extends ElasticsearchTestCase {
}
logger.info("--> child breaker: used: {}, limit: {}", breaker.getUsed(), breaker.getLimit());
logger.info("--> parent tripped: {}, total trip count: {} (expecting 2 for each)", parentTripped.get(), tripped.get());
logger.info("--> parent tripped: {}, total trip count: {} (expecting 1-2 for each)", parentTripped.get(), tripped.get());
assertThat("no other exceptions were thrown", lastException.get(), equalTo(null));
assertThat("breaker should be reset back to the parent limit after parent breaker trips",
breaker.getUsed(), equalTo((long)parentLimit));
assertThat("parent breaker was tripped at least twice", parentTripped.get(), greaterThanOrEqualTo(2));
assertThat("total breaker was tripped at least twice", tripped.get(), greaterThanOrEqualTo(2));
assertThat("parent breaker was tripped at least once", parentTripped.get(), greaterThanOrEqualTo(1));
assertThat("total breaker was tripped at least once", tripped.get(), greaterThanOrEqualTo(1));
assertThat("breaker total is expected value: " + parentLimit, breaker.getUsed(), equalTo((long)
parentLimit));
}