From f9f4d87437fa92b3c466cdbad60d69669f6052c3 Mon Sep 17 00:00:00 2001 From: Nhat Nguyen Date: Mon, 21 Sep 2020 16:27:22 -0400 Subject: [PATCH] Remove invalid assertion in SearchService (#62675) This assertion does not always hold because there can be a race between `putReaderContext` and `afterIndexRemoved` when an index is deleted. Closes #62624 --- .../src/main/java/org/elasticsearch/search/SearchService.java | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/server/src/main/java/org/elasticsearch/search/SearchService.java b/server/src/main/java/org/elasticsearch/search/SearchService.java index 5770b8cf9d8..4085736e5f6 100644 --- a/server/src/main/java/org/elasticsearch/search/SearchService.java +++ b/server/src/main/java/org/elasticsearch/search/SearchService.java @@ -300,8 +300,7 @@ public class SearchService extends AbstractLifecycleComponent implements IndexEv // this is important to ensure store can be cleaned up, in particular if the search is a scroll with a long timeout. final Index index = context.indexShard().shardId().getIndex(); if (indicesService.hasIndex(index) == false) { - final ReaderContext removed = removeReaderContext(context.id().getId()); - assert removed == context; + removeReaderContext(context.id().getId()); throw new IndexNotFoundException(index); } }