From faa687c0ae7e1a6cc3d5a11f0b52d38b14098306 Mon Sep 17 00:00:00 2001
From: Nik Everett <nik9000@gmail.com>
Date: Tue, 7 Apr 2020 11:46:04 -0400
Subject: [PATCH] Fix InternalTTestTests

`testReduceRandom` was bumping up against the serialization that I added
in #54776. This makes it use random values that reduce in ways that
don't cause the randomized serialization to fail.
---
 .../xpack/analytics/ttest/InternalTTestTests.java         | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/x-pack/plugin/analytics/src/test/java/org/elasticsearch/xpack/analytics/ttest/InternalTTestTests.java b/x-pack/plugin/analytics/src/test/java/org/elasticsearch/xpack/analytics/ttest/InternalTTestTests.java
index 39a7fde444d..ec764f440a3 100644
--- a/x-pack/plugin/analytics/src/test/java/org/elasticsearch/xpack/analytics/ttest/InternalTTestTests.java
+++ b/x-pack/plugin/analytics/src/test/java/org/elasticsearch/xpack/analytics/ttest/InternalTTestTests.java
@@ -51,7 +51,13 @@ public class InternalTTestTests extends InternalAggregationTestCase<InternalTTes
     }
 
     private TTestStats randomStats() {
-        return new TTestStats(randomNonNegativeLong(), randomDouble(), randomDouble());
+        /*
+         * Use a count significantly less than Long.MAX_VALUE so the reduce
+         * phase doesn't wrap to a negative number. If it *did* then we'd
+         * try to serialize a negative number with writeVLong which throws
+         * an assertion in tests.
+         */
+        return new TTestStats(randomLongBetween(0, Integer.MAX_VALUE), randomDouble(), randomDouble());
     }
 
     @Override