Commit Graph

54907 Commits

Author SHA1 Message Date
Mark Vieira cda1f884ee Mute WatcherUtilsTests.testDeserializeSearchRequest 2020-11-23 16:02:08 -08:00
Jim Ferenczi 359b89a19b
Fix cacheability of custom LongValuesSource in TermsSetQueryBuilder () ()
This change fixes the equals and hashCode methods of the custom FieldValuesSource
that is used internally to extract the value from a doc value field.
Using the field data instance to check equality prevented the query to be cached in
previous versions. Switching to the field name should make the query eligible for
caching again.
2020-11-23 22:21:01 +01:00
Jay Modi 1a13a0b10f
Watcher understands hidden expand wildcard value ()
Watcher has a search template that stores indices options to be used as
part of a search during watch execution, but this was not updated to be
aware of hidden indices and the `hidden` expand_wildcards option. This
change makes use of the `IndicesOptions#toXContent` method in Watcher,
which already handles the new value. Additionally, the XContent parsing
is moved to the IndicesOptions class so that we will be less likely to
miss updating this in the future.

Closes 
Backport of 
2020-11-23 09:17:49 -07:00
Hendrik Muhs 1828a8b6cc mute WatcherRestartIT 2020-11-23 15:44:55 +01:00
David Turner c558ef6505 Add snapshots to important config list ()
The _Important Elasticsearch configuration_ docs lists a number of items
that you should consider before moving to production. Today this list
does not include configuring snapshots, even though they're very
important to have in production. This commit addresses that omission,
removes some repetition from the introductory paragraphs, and notes that
this config is handled for you on Cloud.

Co-authored-by: James Rodewig <40268737+jrodewig@users.noreply.github.com>
2020-11-23 14:35:46 +00:00
Alan Woodward dc6b05934f
Correctly serialize search-as-you-type analyzer ()
The search-as-you-type mapper was using an incorrect default analyzer when
creating its merge builder, which meant that a configured analyzer would not
be included in serialization.  This in turn resulted in the master node
getting an incorrect configuration, and search-as-you-type fields always
using a standard analyzer.

This has already been fixed via subsequent refactorings in 7.11 and master,
so this fix is for 7.10 only.

Resolves 
2020-11-23 14:02:05 +00:00
Andrei Stefan 866a6afcdf
Extend the interval date comparison () ()
(cherry picked from commit acfb463892fdaf3f0deb679122b5e402c7b56418)
2020-11-23 15:24:36 +02:00
Armin Braun 7fbdcb5e00
Fix SearchableSnapshotsIntegTests.testCreateAndRestoreSearchableSnapshot () ()
The recovery stats assertions in this test ran without any waiting for
the recoveries to actually finish. The fact that they ran after the concurrent
searches checks generally meant that they would pass (because of searches warming caches
+ general relative slowness of searches) but there is no hard guarantees this will work
reliably as the pre-fetch threads which will update the recovery state might still be slow
to do so randomly, causing the assertions to trip.

closes 
2020-11-23 12:30:18 +01:00
Armin Braun b0cea04f95
Fix Broken Error Handling in CacheFile#acquire () ()
If we fail to create the `FileChannelReference` (e.g. because the directory it should be created in
was deleted in a test) we have to remove the listener from the `listeners` set to not trip internal
consistency assertions.

Relates  (does not fix it though, but reduces noise from failures by removing secondary
tripped assertions after the test fails)
2020-11-23 08:57:24 +01:00
Armin Braun 67b6317488
Mute JdbcCsvSpecIT#testCurrentDateFilter ()
Muting for https://github.com/elastic/elasticsearch/issues/65336
2020-11-22 22:37:21 +01:00
Wylie Conlon a86c8dce70 Clarify field data cache behavior in docs ()
* Clarify that field data cache includes global ordinals
* Describe that the cache should be cleared once the limit is reached
* Clarify that the `_id` field does not supported aggregations anymore
* Fold the `fielddata` mapping parameter page into the `text field docs
* Improve cross-linking
2020-11-20 13:59:52 -08:00
Jack Conradson 89ec7db26b Fix casting bug in compound assignment for String ()
This change fixes a bug where when doing compound assignment involving String concatenation, the 
right-hand side will fail to cast to String appropriately and throw a ClassCastException.
2020-11-20 12:09:27 -08:00
Nik Everett 56605e4d9a Fixup reduceRandom tests ()
In aa1ea96b8698aa12bed1c4e8d704882a2a639791 I made all
`testReduceRandom` tests for aggs mimick production more precisely.
More precisely, they pick the correct "lead" result when performing
partial reduction. This is great, but, sadly, some tests assumed that we
always reduced against the "first" aggregator. This fixes those tests.

Closes 
2020-11-20 13:10:34 -05:00
Nik Everett 956ae93fdb Better mimick real reduction in test
This changes has `InternalAggregationTestCase` performs partial
reductions to better mimick `InternalAggregations#reduce`. In
particular, this fixes a bug when we'd attempt a partial reduction of
aggregations that were entirely unmapped but use a mapped aggregation as
the "lead" of the reduction. This was possible in the test but isn't
possible in production. The reduction "lead" is unmapped if all agg
results being reduced are unmapped.

Closes 
2020-11-20 13:10:34 -05:00
James Rodewig feca22729c
[DOCS] Remove duplicated word in replica shard allocator comment () ()
Co-authored-by: Howard <danielhuang@tencent.com>
2020-11-20 12:25:52 -05:00
István Zoltán Szabó e5629f5580
[DOCS] Makes the screenshot larger on the custom URLs page. () () 2020-11-20 15:24:32 +01:00
James Rodewig 99f3156646
[DOCS] Fix formatting issue in search explain docs () ()
Co-authored-by: bellengao <gbl_long@163.com>
2020-11-20 09:21:29 -05:00
Sylvain Wallez f7e840b012
[client] Add simple support for gzip compression
Adds a `RestClient.setCompressionEnabled()` setting that will gzip-
compress request bodies and add a `Accept-Encoding: gzip` header so
that the ES server can send compressed responses.
2020-11-20 07:38:21 +01:00
James Rodewig d4e308a135
[DOCS] Document `xpack.http.proxy.scheme` setting () () 2020-11-19 15:44:12 -05:00
Jay Modi 893e1a5282
Fix date math hidden index resolution ()
This commit updates the IndexAbstractionResolver so that hidden indices
are properly resolved when date math is in use and when we are checking
if the index is visible.

Closes 
Backport of 
2020-11-19 12:40:14 -07:00
James Rodewig b60d0711b7
[DOCS] ILM: Add alloc ex with multiple node attributes () () 2020-11-19 12:38:24 -05:00
István Zoltán Szabó a6a9950868
[7.10][DOCS] Adds UI related limitation to configuring aggs docs () 2020-11-19 14:57:33 +01:00
Nhat Nguyen 3989243a52 Stop renew retention leases when follow task fails ()
If a shard follow-task hits a non-retryable error and stops, then we 
should also stop the retention-leases renewal process associated with
that follow-task.
2020-11-18 15:53:55 -05:00
DeDe Morton 2e079b1b9b
Fix links to Fleet overview () () 2020-11-18 11:04:07 -08:00
James Rodewig 46c55c562a
[DOCS] Remote reindex is not fwd compatible () () 2020-11-18 13:03:12 -05:00
Armin Braun 6953726a2b
Fix Allocation `include` Filter Docs () ()
Fix documentation to match actual behavior of `include` type filters.

Closes 
2020-11-18 18:25:09 +01:00
James Rodewig b1dc869b0f
[DOCS] Clarify logger-package relationship () ()
Updates the logging level docs to better clarify the relationship
between loggers and their Java packages.
2020-11-18 10:45:00 -05:00
James Rodewig c8dac8cff8
[DOCS] Format the ilm-migrate doc () ()
Co-authored-by: bellengao <gbl_long@163.com>
2020-11-18 09:14:00 -05:00
Jim Ferenczi 9f3e3e2162 Fix "resource not found" exception on existing EQL async search ()
This change fixes the initialization of the async results service
for the EQL get async action. The boolean that differentiates EQL
from normal _async_search request is set incorrectly, which results
in errors (404) when extending the keep alive of a running EQL search.

Fixes 
2020-11-18 09:10:31 +01:00
Costin Leau f089547b20 EQL: Fix aggressive/incorrect until policy in sequences ()
The current until implementation in sequences is too optimistic, leading
to an aggressive match that discards correct data leading to invalid
results.
This commit addresses this issue and also unifies the until usage inside
TumblingWindow.
Further more it packs together the UntilGroup with SequenceGroup to
minimize memory usage and improve clean-up.

(cherry picked from commit de2724e92c732c66436939dbbedef93c9981b435)
(cherry picked from commit a60757756aae5f5abb31176fee972a7cdeac3649)
2020-11-18 09:34:33 +02:00
Julie Tibshirani 5495032b00 Remove unused method Analysis#isNoStopwords. 2020-11-17 16:34:33 -08:00
James Rodewig a8d3053128
[DOCS] Clarify ingest attachment example () () 2020-11-17 15:15:25 -05:00
James Rodewig 9471b6345e
[DOCS] Add note about NFS repositories () ()
Co-authored-by: James Rodewig <40268737+jrodewig@users.noreply.github.com>

Co-authored-by: Rafi Estrada <62263912+TheRiffRafi@users.noreply.github.com>
2020-11-17 14:48:47 -05:00
Johnny Lim d67907d244
[DOCS] Fix typos ()
Co-authored-by: James Rodewig <40268737+jrodewig@users.noreply.github.com>
2020-11-17 12:35:41 -05:00
Sylvain Wallez b2475f9ccf
Fix parsing RareTerms aggregation response in RestHighLevelClient ()
Backport of 

- Add LongRareTerms and StringRareTerms to the DefaultNamedXContents,
  ensure that the response of RareTerms aggregation can be parsed
  correctly.
- Add testSearchWithRareTermsAgg method to test the response of
  RareTerms aggregation can be parsed correctly.
- Add some test code to ensure the AggregationsTests can execute
  successfully.

Co-authored-by: bellengao <gbl_long@163.com>
2020-11-17 17:43:51 +01:00
James Rodewig 196c2a52c1
[DOCS] EQL: Update docs for null tiebreakers () () 2020-11-17 10:42:10 -05:00
James Rodewig b54133399e
[DOCS] EQL: Document result_position param () () 2020-11-17 10:41:06 -05:00
Dimitris Athanasiou 197de8fe66
[7.10][ML] Increase timeout waiting for DFA jobs to finish in integ tests () ()
It appears that occasionally 30 seconds are not enough for CI workers
to complete DFA jobs. In order to eliminate such failures we increase
the time we wait for DFA jobs to complete in integration tests to
60 seconds.

Fixes 

Backport of 
2020-11-17 16:46:17 +02:00
István Zoltán Szabó 93505cc05f
[DOCS] Adds recommendation about when to use chunking_config in manual mode. () () 2020-11-17 10:45:28 +01:00
Julie Tibshirani 3974c3b066 Move the shared fetch cache to highlighting. ()
The cache is only used by highlighters, so it can be scoped to only the
highlighting context.
2020-11-16 18:54:32 -08:00
James Rodewig 23a1c64347 [DOCS] Fix typo 2020-11-16 21:35:15 -05:00
Jack Conradson 0beffcd405 Revert null-safe behavior to error at runtime instead of compiletime ()
This reverts a change where null-safe was enhanced to cause a compile-time error instead of a run-
time error when the target value was a primitive type. The reason for the reversion is consistency 
across def/non-def types and versions. I've added a follow up issue to fix this behavior in general 
().
2020-11-16 10:45:38 -08:00
Mark Vieira afd12fddaf Remove reference to 7.9.4 relase which won't happen 2020-11-16 10:31:36 -08:00
Adam Locke 5a6239e916
[DOCS] Adding authorization_realms setting for OIDC () ()
* Adding authorization_realms setting for OIDC.

* Fix typo

* Splitting note into separate notes.
2020-11-16 13:07:20 -05:00
Costin Leau 74fde15833 EQL: Allow null tiebreakers inside ordinals/sequences ()
Align Ordinal comparator to consider nulls last (higher) in tiebreakers.
Add unit tests to Ordinal comparisons and criterion extraction.

Fix 

(cherry picked from commit 93dc883abd6b8855ff1618a574412b7f773b8ff5)
(cherry picked from commit 936e5f1a2cc29c1d5662cb8aa90c629af563a987)
2020-11-16 16:52:55 +02:00
James Rodewig 20bda8d23a
[DOCS] Document reloadable Watcher settings () () 2020-11-16 09:18:48 -05:00
James Rodewig e4054e4e92
[DOCS] Clarify diff between shards per node settings () ()
Clarifies differences between the
`cluster.routing.allocation.total_shards_per_node` and
`cluster.max_shards_per_node` cluster settings.

Closes 

Co-authored-by: Gordon Brown <arcsech@gmail.com>
2020-11-16 09:18:11 -05:00
Przemysław Witek de668ab84b
[7.10] [ML] Extract dependent variable's mapping correctly in case of a multi-field () () 2020-11-16 10:34:58 +01:00
Costin Leau 9551cb3420 EQL: small improvements to the testing base class
Extract request settings into dedicated methods for easier adjustments

(cherry picked from commit 4f93591cc561c7f8ff7c2f070dd1180f209810b7)
(cherry picked from commit ff7e8427345c304f5a37612c870b48555484b692)
2020-11-14 16:40:48 +02:00
Costin Leau f7cc570c4f EQL: Re-enable correctness tests ()
Enable previously disabled tests - only two type of queries remain
disabled: one that does pattern matching and another one for
case-insensitivity.

Fix 

(cherry picked from commit 20210cc43b34438c40b8b5aebf0aa2b8161c4104)
(cherry picked from commit 95d08f2c8d0aac52cc1ed470fa489c239ee25159)
2020-11-14 16:09:11 +02:00