mirror of
https://github.com/honeymoose/OpenSearch.git
synced 2025-03-09 14:34:43 +00:00
The change applies chunking by default on aggregated datafeeds. The chunking is set to a manual mode with time_span being 1000 histogram buckets. The motivation for the change is two-fold: 1. It helps to avoid memory pressure/blowing. Users may perform a lookback on a very long period of time. In that case, we may hold a search response for all that time which could include too many buckets. By chunking, we avoid that situation as we know we'll only keep results for 1000 buckets at a time. 2. It makes cancellation more responsive. In elastic/x-pack-elasticsearch#862 we made the processing of a search response cancellable in a responsive manner. However, the search phase cannot be cancelled at the moment. Chunking makes the search phase shorter, which will result to a better user experience when they stop an aggregated datafeed. Also note the change sets the default chunking_config on datafeed creation so the setting is no longer hidden. Relates to elastic/x-pack-elasticsearch#803 Original commit: elastic/x-pack-elasticsearch@ae8f120f5f