mirror of
https://github.com/honeymoose/OpenSearch.git
synced 2025-02-14 17:05:36 +00:00
There is a very unlikely but possible test failure in this test. The `SnapshotsService` continues iterating over queued operations after resolving the transport listener. This can lead to a situation where the moved repository data is not picked up when running the delete (even though we have the concurrent modifications BwC mode activated) concurrently. I fixed this in the test so that the test still verifies that this setting works. Technically speaking, one could add logic to the way we queue and execute repo operations to address this special case. Since this case only comes about with the concurrent modifications setting enabled (and the setting is gone in master already) I don't really see a reason to improve the logic here since we should always fail queued up repo operations on concurrent modification for safety reasons.