OpenSearch/plugins
Jason Tedor 2dea449949 Remove Strings#splitStringToArray
This commit removes the method Strings#splitStringToArray and replaces
the call sites with invocations to String#split. There are only two
explanations for the existence of this method. The first is that
String#split is slightly tricky in that it accepts a regular expression
rather than a character to split on. This means that if s is a string,
s.split(".")  does not split on the character '.', but rather splits on
the regular expression '.' which splits on every character (of course,
this is easily fixed by invoking s.split("\\.") instead). The second
possible explanation is that (again) String#split accepts a regular
expression. This means that there could be a performance concern
compared to just splitting on a single character. However, it turns out
that String#split has a fast path for the case of splitting on a single
character and microbenchmarks show that String#split has 1.5x--2x the
throughput of Strings#splitStringToArray. There is a slight behavior
difference between Strings#splitStringToArray and String#split: namely,
the former would return an empty array in cases when the input string
was null or empty but String#split will just NPE at the call site on
null and return a one-element array containing the empty string when the
input string is empty. There was only one place relying on this behavior
and the call site has been modified accordingly.
2016-05-04 08:12:41 -04:00
..
analysis-icu Fix icu IndexScope setting 2016-04-22 15:03:02 -07:00
analysis-kuromoji Analyze API : Rename filters/token_filters/char_filter to filter/token_filter/char_filter 2016-04-21 18:05:11 +09:00
analysis-phonetic Upgrade Lucene 6 Release 2016-04-11 16:50:04 -05:00
analysis-smartcn Upgrade Lucene 6 Release 2016-04-11 16:50:04 -05:00
analysis-stempel Analyze API : Rename filters/token_filters/char_filter to filter/token_filter/char_filter 2016-04-21 18:05:11 +09:00
delete-by-query Internal: Remove XContentBuilderString 2016-04-18 14:32:18 -07:00
discovery-azure Add Azure discovery tests mocking Azure management endpoint (#18004) 2016-04-29 15:54:15 +02:00
discovery-ec2 Add Azure discovery tests mocking Azure management endpoint (#18004) 2016-04-29 15:54:15 +02:00
discovery-gce Remove Strings#splitStringToArray 2016-05-04 08:12:41 -04:00
ingest-attachment ingest: Add `date_index_name` processor. 2016-04-29 17:20:48 +02:00
ingest-geoip ingest: Add `date_index_name` processor. 2016-04-29 17:20:48 +02:00
jvm-example Merge pull request #16038 from rjernst/remove_site_plugin 2016-01-21 12:32:22 -08:00
lang-javascript Changed indexed scripts to be stored in the cluster state instead of the `.scripts` index. 2016-04-22 13:42:55 +02:00
lang-python Changed indexed scripts to be stored in the cluster state instead of the `.scripts` index. 2016-04-22 13:42:55 +02:00
mapper-attachments Fix test in mapper attachments plugin 2016-04-29 15:02:04 +02:00
mapper-murmur3 Version: Set version to 5.0.0-alpha2 2016-04-26 09:30:26 +02:00
mapper-size Version: Set version to 5.0.0-alpha2 2016-04-26 09:30:26 +02:00
repository-azure Remove Strings#splitStringToArray 2016-05-04 08:12:41 -04:00
repository-hdfs Remove Settings.settingsBuilder. 2016-04-08 18:10:02 +02:00
repository-s3 Remove Strings#splitStringToArray 2016-05-04 08:12:41 -04:00
store-smb upgrade to lucene 6.0.0-snapshot-bea235f 2016-03-07 04:12:23 -05:00
build.gradle Revert "Build: Switch to maven-publish plugin" 2016-03-18 17:22:25 -07:00