OpenSearch/x-pack/plugin/security
Tim Vernum cad0f6bf28
Do not load SSLService in plugin contructor (#50519)
XPackPlugin created an SSLService within the plugin contructor.
This has 2 negative consequences:

1. The service may be constructed based on a partial view of settings.
   Other plugins are free to add setting values via the
   additionalSettings() method, but this (necessarily) happens after
   plugins have been constructed.

2. Any exceptions thrown during the plugin construction are handled
   differently than exceptions thrown during "createComponents".
   Since SSL configurations exceptions are relatively common, it is
   far preferable for them to be thrown and handled as part of the
   createComponents flow.

This commit moves the creation of the SSLService to
XPackPlugin.createComponents, and alters the sequence of some other
steps to accommodate this change.

Backport of: #49667
2019-12-30 14:42:32 +11:00
..
cli Apply 2-space indent to all gradle scripts (#49071) 2019-11-14 11:01:23 +00:00
forbidden Add an OpenID Connect authentication realm (#40674) (#41178) 2019-04-15 12:41:16 +03:00
licenses [7.x] Update opensaml dependency (#44972) (#49512) 2019-11-29 00:17:16 +02:00
qa Improved diagnostics for TLS trust failures (#49669) 2019-11-29 15:01:20 +11:00
src Do not load SSLService in plugin contructor (#50519) 2019-12-30 14:42:32 +11:00
build.gradle [7.x] Update opensaml dependency (#44972) (#49512) 2019-11-29 00:17:16 +02:00