mirror of
https://github.com/honeymoose/OpenSearch.git
synced 2025-02-07 21:48:39 +00:00
41e42f0945
Before this change DateTimes were being constructed without providing a time zone, this was causing some non-utc time leakage. In particular watch record ids were being created with non utc dates and watch records were going to the wrong .watch_history index. Add Clock.now(DateTimeZone) to allow callers to get UTC now. Also construct the DateTimes with UTC timezones when we construct from millis. Add all constuctors of DateTime that do not specify a time zone to the forbidden APIs. This change makes constructing a `DateTime` object without providing a `DateTimeZone` forbidden. This is much safer and makes time zone errors much more unlikely to occur. Statically import DateTimeZone.UTC everywhere it was being used Now all calls that use DateTimeZone.UTC just refrence UTC. Fixes elastic/elasticsearch#150 Original commit: elastic/x-pack-elasticsearch@7f23ce605e
71 lines
4.3 KiB
Plaintext
71 lines
4.3 KiB
Plaintext
@defaultMessage spawns threads with vague names; use a custom thread factory and name threads so that you can tell (by its name) which executor it is associated with
|
|
|
|
java.util.concurrent.Executors#newFixedThreadPool(int)
|
|
java.util.concurrent.Executors#newSingleThreadExecutor()
|
|
java.util.concurrent.Executors#newCachedThreadPool()
|
|
java.util.concurrent.Executors#newSingleThreadScheduledExecutor()
|
|
java.util.concurrent.Executors#newScheduledThreadPool(int)
|
|
java.util.concurrent.Executors#defaultThreadFactory()
|
|
java.util.concurrent.Executors#privilegedThreadFactory()
|
|
|
|
java.lang.Character#codePointBefore(char[],int) @ Implicit start offset is error-prone when the char[] is a buffer and the first chars are random chars
|
|
java.lang.Character#codePointAt(char[],int) @ Implicit end offset is error-prone when the char[] is a buffer and the last chars are random chars
|
|
|
|
java.io.StringReader#<init>(java.lang.String) @ Use FastStringReader instead
|
|
|
|
@defaultMessage Reference management is tricky, leave it to SearcherManager
|
|
org.apache.lucene.index.IndexReader#decRef()
|
|
org.apache.lucene.index.IndexReader#incRef()
|
|
org.apache.lucene.index.IndexReader#tryIncRef()
|
|
|
|
@defaultMessage QueryWrapperFilter is cachable by default - use Queries#wrap instead
|
|
org.apache.lucene.search.QueryWrapperFilter#<init>(org.apache.lucene.search.Query)
|
|
|
|
@defaultMessage Because the filtercache doesn't take deletes into account FilteredQuery can't be used - use XFilteredQuery instead
|
|
org.apache.lucene.search.FilteredQuery#<init>(org.apache.lucene.search.Query,org.apache.lucene.search.Filter)
|
|
org.apache.lucene.search.FilteredQuery#<init>(org.apache.lucene.search.Query,org.apache.lucene.search.Filter,org.apache.lucene.search.FilteredQuery$FilterStrategy)
|
|
|
|
@defaultMessage Pass the precision step from the mappings explicitly instead
|
|
org.apache.lucene.search.NumericRangeQuery#newDoubleRange(java.lang.String,java.lang.Double,java.lang.Double,boolean,boolean)
|
|
org.apache.lucene.search.NumericRangeQuery#newFloatRange(java.lang.String,java.lang.Float,java.lang.Float,boolean,boolean)
|
|
org.apache.lucene.search.NumericRangeQuery#newIntRange(java.lang.String,java.lang.Integer,java.lang.Integer,boolean,boolean)
|
|
org.apache.lucene.search.NumericRangeQuery#newLongRange(java.lang.String,java.lang.Long,java.lang.Long,boolean,boolean)
|
|
org.apache.lucene.search.NumericRangeFilter#newDoubleRange(java.lang.String,java.lang.Double,java.lang.Double,boolean,boolean)
|
|
org.apache.lucene.search.NumericRangeFilter#newFloatRange(java.lang.String,java.lang.Float,java.lang.Float,boolean,boolean)
|
|
org.apache.lucene.search.NumericRangeFilter#newIntRange(java.lang.String,java.lang.Integer,java.lang.Integer,boolean,boolean)
|
|
org.apache.lucene.search.NumericRangeFilter#newLongRange(java.lang.String,java.lang.Long,java.lang.Long,boolean,boolean)
|
|
|
|
@defaultMessage Only use wait / notify when really needed try to use concurrency primitives, latches or callbacks instead.
|
|
java.lang.Object#wait()
|
|
java.lang.Object#wait(long)
|
|
java.lang.Object#wait(long,int)
|
|
java.lang.Object#notify()
|
|
java.lang.Object#notifyAll()
|
|
|
|
@defaultMessage Beware of the behavior of this method on MIN_VALUE
|
|
java.lang.Math#abs(int)
|
|
java.lang.Math#abs(long)
|
|
|
|
@defaultMessage Please do not try to stop the world
|
|
java.lang.System#gc()
|
|
|
|
@defaultMessage Use Channels.* methods to write to channels. Do not write directly.
|
|
java.nio.channels.WritableByteChannel#write(java.nio.ByteBuffer)
|
|
java.nio.channels.FileChannel#write(java.nio.ByteBuffer, long)
|
|
java.nio.channels.GatheringByteChannel#write(java.nio.ByteBuffer[], int, int)
|
|
java.nio.channels.GatheringByteChannel#write(java.nio.ByteBuffer[])
|
|
java.nio.channels.ReadableByteChannel#read(java.nio.ByteBuffer)
|
|
java.nio.channels.ScatteringByteChannel#read(java.nio.ByteBuffer[])
|
|
java.nio.channels.ScatteringByteChannel#read(java.nio.ByteBuffer[], int, int)
|
|
java.nio.channels.FileChannel#read(java.nio.ByteBuffer, long)
|
|
|
|
@defaultMessage Constructing a DateTime without a time zone is dangerous - use DateTime(DateTimeZone.getDefault()) if you really want the default timezone
|
|
org.elasticsearch.common.joda.time.DateTime#<init>()
|
|
org.elasticsearch.common.joda.time.DateTime#<init>(long)
|
|
org.elasticsearch.common.joda.time.DateTime#<init>(int, int, int, int, int)
|
|
org.elasticsearch.common.joda.time.DateTime#<init>(int, int, int, int, int, int)
|
|
org.elasticsearch.common.joda.time.DateTime#<init>(int, int, int, int, int, int, int)
|
|
org.elasticsearch.common.joda.time.DateTime#now()
|
|
|
|
|