mirror of
https://github.com/honeymoose/OpenSearch.git
synced 2025-02-07 13:38:49 +00:00
2be52eff09
When compiling many dynamically changing scripts, parameterized scripts (<https://www.elastic.co/guide/en/elasticsearch/reference/master/modules-scripting-using.html#prefer-params>) should be preferred. This enforces a limit to the number of scripts that can be compiled within a minute. A new dynamic setting is added - `script.max_compilations_per_minute`, which defaults to 15. If more dynamic scripts are sent, a user will get the following exception: ```json { "error" : { "root_cause" : [ { "type" : "circuit_breaking_exception", "reason" : "[script] Too many dynamic script compilations within one minute, max: [15/min]; please use on-disk, indexed, or scripts with parameters instead", "bytes_wanted" : 0, "bytes_limit" : 0 } ], "type" : "search_phase_execution_exception", "reason" : "all shards failed", "phase" : "query", "grouped" : true, "failed_shards" : [ { "shard" : 0, "index" : "i", "node" : "a5V1eXcZRYiIk8lecjZ4Jw", "reason" : { "type" : "general_script_exception", "reason" : "Failed to compile inline script [\"aaaaaaaaaaaaaaaa\"] using lang [painless]", "caused_by" : { "type" : "circuit_breaking_exception", "reason" : "[script] Too many dynamic script compilations within one minute, max: [15/min]; please use on-disk, indexed, or scripts with parameters instead", "bytes_wanted" : 0, "bytes_limit" : 0 } } } ], "caused_by" : { "type" : "general_script_exception", "reason" : "Failed to compile inline script [\"aaaaaaaaaaaaaaaa\"] using lang [painless]", "caused_by" : { "type" : "circuit_breaking_exception", "reason" : "[script] Too many dynamic script compilations within one minute, max: [15/min]; please use on-disk, indexed, or scripts with parameters instead", "bytes_wanted" : 0, "bytes_limit" : 0 } } }, "status" : 500 } ``` This also fixes a bug in `ScriptService` where requests being executed concurrently on a single node could cause a script to be compiled multiple times (many in the case of a powerful node with many shards) due to no synchronization between checking the cache and compiling the script. There is now synchronization so that a script being compiled will only be compiled once regardless of the number of concurrent searches on a node. Relates to #19396
78 lines
3.0 KiB
Groovy
78 lines
3.0 KiB
Groovy
/*
|
|
* Licensed to Elasticsearch under one or more contributor
|
|
* license agreements. See the NOTICE file distributed with
|
|
* this work for additional information regarding copyright
|
|
* ownership. Elasticsearch licenses this file to you under
|
|
* the Apache License, Version 2.0 (the "License"); you may
|
|
* not use this file except in compliance with the License.
|
|
* You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing,
|
|
* software distributed under the License is distributed on an
|
|
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
|
|
* KIND, either express or implied. See the License for the
|
|
* specific language governing permissions and limitations
|
|
* under the License.
|
|
*/
|
|
|
|
esplugin {
|
|
description 'Groovy scripting integration for Elasticsearch'
|
|
classname 'org.elasticsearch.script.groovy.GroovyPlugin'
|
|
}
|
|
|
|
dependencies {
|
|
compile 'org.codehaus.groovy:groovy:2.4.6:indy'
|
|
}
|
|
|
|
integTest {
|
|
cluster {
|
|
setting 'script.inline', 'true'
|
|
setting 'script.stored', 'true'
|
|
setting 'script.max_compilations_per_minute', '1000'
|
|
}
|
|
}
|
|
|
|
thirdPartyAudit.excludes = [
|
|
// classes are missing, we bring in a minimal groovy dist
|
|
// for example we do not need ivy, scripts arent allowed to download code
|
|
'com.thoughtworks.xstream.XStream',
|
|
'groovyjarjarasm.asm.util.Textifiable',
|
|
// commons-cli is referenced by groovy, even though they supposedly
|
|
// jarjar it. Since we don't use the cli, we don't need the dep.
|
|
'org.apache.commons.cli.CommandLine',
|
|
'org.apache.commons.cli.CommandLineParser',
|
|
'org.apache.commons.cli.GnuParser',
|
|
'org.apache.commons.cli.HelpFormatter',
|
|
'org.apache.commons.cli.Option',
|
|
'org.apache.commons.cli.OptionBuilder',
|
|
'org.apache.commons.cli.Options',
|
|
'org.apache.commons.cli.Parser',
|
|
'org.apache.commons.cli.PosixParser',
|
|
'org.apache.ivy.Ivy',
|
|
'org.apache.ivy.core.event.IvyListener',
|
|
'org.apache.ivy.core.event.download.PrepareDownloadEvent',
|
|
'org.apache.ivy.core.event.resolve.StartResolveEvent',
|
|
'org.apache.ivy.core.module.descriptor.Configuration',
|
|
'org.apache.ivy.core.module.descriptor.DefaultDependencyArtifactDescriptor',
|
|
'org.apache.ivy.core.module.descriptor.DefaultDependencyDescriptor',
|
|
'org.apache.ivy.core.module.descriptor.DefaultExcludeRule',
|
|
'org.apache.ivy.core.module.descriptor.DefaultModuleDescriptor',
|
|
'org.apache.ivy.core.module.id.ArtifactId',
|
|
'org.apache.ivy.core.module.id.ModuleId',
|
|
'org.apache.ivy.core.module.id.ModuleRevisionId',
|
|
'org.apache.ivy.core.report.ResolveReport',
|
|
'org.apache.ivy.core.resolve.ResolveOptions',
|
|
'org.apache.ivy.core.settings.IvySettings',
|
|
'org.apache.ivy.plugins.matcher.ExactPatternMatcher',
|
|
'org.apache.ivy.plugins.matcher.PatternMatcher',
|
|
'org.apache.ivy.plugins.resolver.IBiblioResolver',
|
|
'org.apache.ivy.util.DefaultMessageLogger',
|
|
'org.apache.ivy.util.Message',
|
|
'org.fusesource.jansi.Ansi$Attribute',
|
|
'org.fusesource.jansi.Ansi$Color',
|
|
'org.fusesource.jansi.Ansi',
|
|
'org.fusesource.jansi.AnsiRenderWriter',
|
|
]
|