96f283c195
This commit renames writeThrowable to writeException. The situation here stems from the fact that the StreamOutput method for serializing Exceptions needs to accept Throwables too as Throwables can be the cause of serialized Exceptions. Yet, we do not serialize Throwables in the Error sub-hierarchy in a way that they can be deserialized into their initial type. This leads to an asymmetry in the StreamOutput method for serializing Exceptions and the StreamInput method for writing Excpetions. Namely, the former will accept Throwables but the latter will only return Exceptions. A goal with the stream methods has always been symmetry in the method names so that serialization/deserialization routines appear symmetrical in code. It is this asymmetry on the input/output types for Exceptions on StreamOutput/StreamInput that clashes with the desired symmetry of naming. Despite this, we should favor symmetry in the naming of the methods. This commit renames StreamOutput#writeThrowable to StreamOutput#writeException which leaves us with Exception StreamInput#readException and void StreamOutput#writeException(Throwable). |
||
|---|---|---|
| .. | ||
| aggs-matrix-stats | ||
| ingest-common | ||
| lang-expression | ||
| lang-groovy | ||
| lang-mustache | ||
| lang-painless | ||
| percolator | ||
| reindex | ||
| build.gradle | ||