OpenSearch/plugins
Luca Cavanna a7046e001c
Remove support for maxRetryTimeout from low-level REST client (#38085)
We have had various reports of problems caused by the maxRetryTimeout
setting in the low-level REST client. Such setting was initially added
in the attempts to not have requests go through retries if the request
already took longer than the provided timeout.

The implementation was problematic though as such timeout would also
expire in the first request attempt (see #31834), would leave the
request executing after expiration causing memory leaks (see #33342),
and would not take into account the http client internal queuing (see #25951).

Given all these issues, it seems that this custom timeout mechanism 
gives little benefits while causing a lot of harm. We should rather rely 
on connect and socket timeout exposed by the underlying http client 
and accept that a request can overall take longer than the configured 
timeout, which is the case even with a single retry anyways.

This commit removes the `maxRetryTimeout` setting and all of its usages.
2019-02-06 08:43:47 +01:00
..
analysis-icu Default include_type_name to false in the yml test harness. (#38058) 2019-02-01 11:44:13 -08:00
analysis-kuromoji Default include_type_name to false in the yml test harness. (#38058) 2019-02-01 11:44:13 -08:00
analysis-nori Default include_type_name to false in the yml test harness. (#38058) 2019-02-01 11:44:13 -08:00
analysis-phonetic Default include_type_name to false in the yml test harness. (#38058) 2019-02-01 11:44:13 -08:00
analysis-smartcn Default include_type_name to false in the yml test harness. (#38058) 2019-02-01 11:44:13 -08:00
analysis-stempel Default include_type_name to false in the yml test harness. (#38058) 2019-02-01 11:44:13 -08:00
analysis-ukrainian Default include_type_name to false in the yml test harness. (#38058) 2019-02-01 11:44:13 -08:00
discovery-azure-classic Rename static Zen1 settings (#38333) 2019-02-05 08:46:52 +00:00
discovery-ec2 Rename static Zen1 settings (#38333) 2019-02-05 08:46:52 +00:00
discovery-gce Rename static Zen1 settings (#38333) 2019-02-05 08:46:52 +00:00
examples Allow custom authorization with an authorization engine (#38358) 2019-02-05 13:39:29 -07:00
ingest-attachment Update httpclient for JDK 11 TLS engine (#37994) 2019-01-30 14:24:29 -07:00
mapper-annotated-text Default include_type_name to false in the yml test harness. (#38058) 2019-02-01 11:44:13 -08:00
mapper-murmur3 Default include_type_name to false in the yml test harness. (#38058) 2019-02-01 11:44:13 -08:00
mapper-size Default include_type_name to false in the yml test harness. (#38058) 2019-02-01 11:44:13 -08:00
repository-azure Remove support for maxRetryTimeout from low-level REST client (#38085) 2019-02-06 08:43:47 +01:00
repository-gcs Update httpclient for JDK 11 TLS engine (#37994) 2019-01-30 14:24:29 -07:00
repository-hdfs Update httpclient for JDK 11 TLS engine (#37994) 2019-01-30 14:24:29 -07:00
repository-s3 Update httpclient for JDK 11 TLS engine (#37994) 2019-01-30 14:24:29 -07:00
store-smb Removes typed calls from YAML REST tests (#37611) 2019-01-30 16:32:58 +00:00
transport-nio Extract message serialization from `TcpTransport` (#37034) 2019-01-21 14:14:18 -07:00
build.gradle Reorganize license files 2018-04-20 15:33:59 -07:00