OpenSearch/qa
Luca Cavanna a7046e001c
Remove support for maxRetryTimeout from low-level REST client (#38085)
We have had various reports of problems caused by the maxRetryTimeout
setting in the low-level REST client. Such setting was initially added
in the attempts to not have requests go through retries if the request
already took longer than the provided timeout.

The implementation was problematic though as such timeout would also
expire in the first request attempt (see #31834), would leave the
request executing after expiration causing memory leaks (see #33342),
and would not take into account the http client internal queuing (see #25951).

Given all these issues, it seems that this custom timeout mechanism 
gives little benefits while causing a lot of harm. We should rather rely 
on connect and socket timeout exposed by the underlying http client 
and accept that a request can overall take longer than the configured 
timeout, which is the case even with a single retry anyways.

This commit removes the `maxRetryTimeout` setting and all of its usages.
2019-02-06 08:43:47 +01:00
..
ccs-unavailable-clusters Introduce ability to minimize round-trips in CCS (#37828) 2019-01-31 15:12:14 +01:00
die-with-dignity Elasticsearch support to JSON logging (#36833) 2019-01-29 07:20:09 +01:00
evil-tests Bubble-up exceptions from scheduler (#38317) 2019-02-05 21:48:24 +01:00
full-cluster-restart Types removal fix FullClusterRestartIT warnings (#38445) 2019-02-05 14:15:43 -05:00
logging-config Deprecate minimum_master_nodes (#37868) 2019-01-30 20:09:15 +00:00
mixed-cluster Converting randomized testing to create a separate unitTest task instead of replacing the builtin test task (#36311) 2018-12-19 08:25:20 +02:00
multi-cluster-search Default include_type_name to false in the yml test harness. (#38058) 2019-02-01 11:44:13 -08:00
no-bootstrap-tests Plugins: Remove meta plugins (#30670) 2018-05-18 10:56:08 -07:00
rolling-upgrade Remove support for maxRetryTimeout from low-level REST client (#38085) 2019-02-06 08:43:47 +01:00
smoke-test-client Testing conventions: add support for checking base classes (#36650) 2019-01-08 13:39:03 +02:00
smoke-test-http Deprecate types in index API (#36575) 2018-12-18 08:53:49 -05:00
smoke-test-ingest-disabled Tests: Change rest test extension from .yaml to .yml (#24659) 2017-05-16 17:24:35 -07:00
smoke-test-ingest-with-all-dependencies Default include_type_name to false in the yml test harness. (#38058) 2019-02-01 11:44:13 -08:00
smoke-test-multinode Simplify integ test distribution types (#37618) 2019-01-21 12:37:17 -08:00
smoke-test-plugins Move repository-s3 fixture tests to QA test project (#29372) 2018-04-27 16:49:06 +02:00
unconfigured-node-name Elasticsearch support to JSON logging (#36833) 2019-01-29 07:20:09 +01:00
vagrant Fix exit code in certutil packaging test (#38393) 2019-02-06 12:05:44 +11:00
verify-version-constants MINOR: Remove some Deadcode in Gradle (#37160) 2019-01-07 09:21:25 +01:00
wildfly Testing conventions: add support for checking base classes (#36650) 2019-01-08 13:39:03 +02:00
build.gradle Simplify integ test distribution types (#37618) 2019-01-21 12:37:17 -08:00