d467283475
I observed a test failure with the message 'Attempted to append to non-started appender mock' from an assertion in `OpenSearchTestCase::after`. I believe this indicates that a MockLogAppender (which is named "mock") was added as an appender to the static logging context and some other test in the same JVM happened to cause a logging statement to hit that appender and cause an error, which then caused an unrelated test to fail (because they share static state with the logger). Almost all usages of MockLogAppender start it immediately after creation. I found a few that did not and fixed those. I also made a static helper in MockLogAppender to start it upon creation. Signed-off-by: Andrew Ross <andrross@amazon.com>
Welcome!
OpenSearch is a community-driven, open source fork of Elasticsearch and Kibana following the licence change in early 2021. We're looking to sustain (and evolve!) a search and analytics suite for the multitude of businesses who are dependent on the rights granted by the original, Apache v2.0 License.
Project Resources
- Project Website
- Downloads
- Documentation
- Need help? Try Forums
- Project Principles
- Contributing to OpenSearch
- Maintainer Responsibilities
- Release Management
- Admin Responsibilities
- Testing
- Security
Code of Conduct
This project has adopted the Amazon Open Source Code of Conduct. For more information see the Code of Conduct FAQ, or contact opensource-codeofconduct@amazon.com with any additional questions or comments.
Security
If you discover a potential security issue in this project we ask that you notify AWS/Amazon Security via our vulnerability reporting page or directly via email to aws-security@amazon.com. Please do not create a public GitHub issue.
License
This project is licensed under the Apache v2.0 License.
Copyright
Copyright OpenSearch Contributors. See NOTICE for details.