mirror of
https://github.com/honeymoose/OpenSearch.git
synced 2025-03-09 14:34:43 +00:00
de6b6fd338
This commit namespaces the existing processors setting under the "node" namespace. In doing so, we deprecate the existing processors setting in favor of node.processors.
184 lines
9.5 KiB
Java
184 lines
9.5 KiB
Java
/*
|
|
* Licensed to Elasticsearch under one or more contributor
|
|
* license agreements. See the NOTICE file distributed with
|
|
* this work for additional information regarding copyright
|
|
* ownership. Elasticsearch licenses this file to you under
|
|
* the Apache License, Version 2.0 (the "License"); you may
|
|
* not use this file except in compliance with the License.
|
|
* You may obtain a copy of the License at
|
|
*
|
|
* http://www.apache.org/licenses/LICENSE-2.0
|
|
*
|
|
* Unless required by applicable law or agreed to in writing,
|
|
* software distributed under the License is distributed on an
|
|
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
|
|
* KIND, either express or implied. See the License for the
|
|
* specific language governing permissions and limitations
|
|
* under the License.
|
|
*/
|
|
|
|
package org.elasticsearch.index;
|
|
|
|
import org.apache.logging.log4j.Level;
|
|
import org.apache.logging.log4j.Logger;
|
|
import org.apache.logging.log4j.LogManager;
|
|
import org.apache.logging.log4j.core.LogEvent;
|
|
import org.apache.logging.log4j.core.appender.AbstractAppender;
|
|
import org.apache.logging.log4j.core.filter.RegexFilter;
|
|
import org.elasticsearch.Version;
|
|
import org.elasticsearch.cluster.metadata.IndexMetaData;
|
|
import org.elasticsearch.common.logging.Loggers;
|
|
import org.elasticsearch.common.settings.Settings;
|
|
import org.elasticsearch.test.ESTestCase;
|
|
|
|
import static org.elasticsearch.common.util.concurrent.EsExecutors.NODE_PROCESSORS_SETTING;
|
|
import static org.elasticsearch.index.IndexSettingsTests.newIndexMeta;
|
|
import static org.elasticsearch.index.MergeSchedulerConfig.MAX_MERGE_COUNT_SETTING;
|
|
import static org.elasticsearch.index.MergeSchedulerConfig.MAX_THREAD_COUNT_SETTING;
|
|
import static org.hamcrest.core.StringContains.containsString;
|
|
|
|
public class MergeSchedulerSettingsTests extends ESTestCase {
|
|
private static class MockAppender extends AbstractAppender {
|
|
public boolean sawUpdateMaxThreadCount;
|
|
public boolean sawUpdateAutoThrottle;
|
|
|
|
MockAppender(final String name) throws IllegalAccessException {
|
|
super(name, RegexFilter.createFilter(".*(\n.*)*", new String[0], false, null, null), null);
|
|
}
|
|
|
|
@Override
|
|
public void append(LogEvent event) {
|
|
String message = event.getMessage().getFormattedMessage();
|
|
if (event.getLevel() == Level.TRACE && event.getLoggerName().endsWith("lucene.iw")) {
|
|
}
|
|
if (event.getLevel() == Level.INFO
|
|
&& message.contains("updating [index.merge.scheduler.max_thread_count] from [10000] to [1]")) {
|
|
sawUpdateMaxThreadCount = true;
|
|
}
|
|
if (event.getLevel() == Level.INFO
|
|
&& message.contains("updating [index.merge.scheduler.auto_throttle] from [true] to [false]")) {
|
|
sawUpdateAutoThrottle = true;
|
|
}
|
|
}
|
|
|
|
@Override
|
|
public boolean ignoreExceptions() {
|
|
return false;
|
|
}
|
|
|
|
}
|
|
|
|
public void testUpdateAutoThrottleSettings() throws Exception {
|
|
MockAppender mockAppender = new MockAppender("testUpdateAutoThrottleSettings");
|
|
mockAppender.start();
|
|
final Logger settingsLogger = LogManager.getLogger("org.elasticsearch.common.settings.IndexScopedSettings");
|
|
Loggers.addAppender(settingsLogger, mockAppender);
|
|
Loggers.setLevel(settingsLogger, Level.TRACE);
|
|
try {
|
|
Settings.Builder builder = Settings.builder()
|
|
.put(IndexMetaData.SETTING_VERSION_CREATED, Version.CURRENT)
|
|
.put(IndexMetaData.SETTING_NUMBER_OF_SHARDS, "1")
|
|
.put(IndexMetaData.SETTING_NUMBER_OF_REPLICAS, "0")
|
|
.put(MergePolicyConfig.INDEX_MERGE_POLICY_MAX_MERGE_AT_ONCE_SETTING.getKey(), "2")
|
|
.put(MergePolicyConfig.INDEX_MERGE_POLICY_SEGMENTS_PER_TIER_SETTING.getKey(), "2")
|
|
.put(MergeSchedulerConfig.MAX_THREAD_COUNT_SETTING.getKey(), "1")
|
|
.put(MergeSchedulerConfig.MAX_MERGE_COUNT_SETTING.getKey(), "2")
|
|
.put(MergeSchedulerConfig.AUTO_THROTTLE_SETTING.getKey(), "true");
|
|
IndexSettings settings = new IndexSettings(newIndexMeta("index", builder.build()), Settings.EMPTY);
|
|
assertEquals(settings.getMergeSchedulerConfig().isAutoThrottle(), true);
|
|
builder.put(MergeSchedulerConfig.AUTO_THROTTLE_SETTING.getKey(), "false");
|
|
settings.updateIndexMetaData(newIndexMeta("index", builder.build()));
|
|
// Make sure we log the change:
|
|
assertTrue(mockAppender.sawUpdateAutoThrottle);
|
|
assertEquals(settings.getMergeSchedulerConfig().isAutoThrottle(), false);
|
|
} finally {
|
|
Loggers.removeAppender(settingsLogger, mockAppender);
|
|
mockAppender.stop();
|
|
Loggers.setLevel(settingsLogger, (Level) null);
|
|
}
|
|
}
|
|
|
|
// #6882: make sure we can change index.merge.scheduler.max_thread_count live
|
|
public void testUpdateMergeMaxThreadCount() throws Exception {
|
|
MockAppender mockAppender = new MockAppender("testUpdateAutoThrottleSettings");
|
|
mockAppender.start();
|
|
final Logger settingsLogger = LogManager.getLogger("org.elasticsearch.common.settings.IndexScopedSettings");
|
|
Loggers.addAppender(settingsLogger, mockAppender);
|
|
Loggers.setLevel(settingsLogger, Level.TRACE);
|
|
try {
|
|
Settings.Builder builder = Settings.builder()
|
|
.put(IndexMetaData.SETTING_VERSION_CREATED, Version.CURRENT)
|
|
.put(IndexMetaData.SETTING_NUMBER_OF_SHARDS, "1")
|
|
.put(IndexMetaData.SETTING_NUMBER_OF_REPLICAS, "0")
|
|
.put(MergePolicyConfig.INDEX_MERGE_POLICY_MAX_MERGE_AT_ONCE_SETTING.getKey(), "2")
|
|
.put(MergePolicyConfig.INDEX_MERGE_POLICY_SEGMENTS_PER_TIER_SETTING.getKey(), "2")
|
|
.put(MergeSchedulerConfig.MAX_THREAD_COUNT_SETTING.getKey(), "10000")
|
|
.put(MergeSchedulerConfig.MAX_MERGE_COUNT_SETTING.getKey(), "10000");
|
|
IndexSettings settings = new IndexSettings(newIndexMeta("index", builder.build()), Settings.EMPTY);
|
|
assertEquals(settings.getMergeSchedulerConfig().getMaxMergeCount(), 10000);
|
|
assertEquals(settings.getMergeSchedulerConfig().getMaxThreadCount(), 10000);
|
|
settings.updateIndexMetaData(newIndexMeta("index", builder.build()));
|
|
assertFalse(mockAppender.sawUpdateMaxThreadCount);
|
|
builder.put(MergeSchedulerConfig.MAX_THREAD_COUNT_SETTING.getKey(), "1");
|
|
settings.updateIndexMetaData(newIndexMeta("index", builder.build()));
|
|
// Make sure we log the change:
|
|
assertTrue(mockAppender.sawUpdateMaxThreadCount);
|
|
} finally {
|
|
Loggers.removeAppender(settingsLogger, mockAppender);
|
|
mockAppender.stop();
|
|
Loggers.setLevel(settingsLogger, (Level) null);
|
|
}
|
|
}
|
|
|
|
private static IndexMetaData createMetaData(int maxThreadCount, int maxMergeCount, int numProc) {
|
|
Settings.Builder builder = Settings.builder().put(IndexMetaData.SETTING_VERSION_CREATED, Version.CURRENT);
|
|
if (maxThreadCount != -1) {
|
|
builder.put(MAX_THREAD_COUNT_SETTING.getKey(), maxThreadCount);
|
|
}
|
|
if (maxMergeCount != -1) {
|
|
builder.put(MAX_MERGE_COUNT_SETTING.getKey(), maxMergeCount);
|
|
}
|
|
if (numProc != -1) {
|
|
builder.put(NODE_PROCESSORS_SETTING.getKey(), numProc);
|
|
}
|
|
return newIndexMeta("index", builder.build());
|
|
}
|
|
|
|
public void testMaxThreadAndMergeCount() {
|
|
IllegalArgumentException exc =
|
|
expectThrows(IllegalArgumentException.class,
|
|
() -> new MergeSchedulerConfig(new IndexSettings(createMetaData(10, 4, -1), Settings.EMPTY)));
|
|
assertThat(exc.getMessage(), containsString("maxThreadCount (= 10) should be <= maxMergeCount (= 4)"));
|
|
|
|
IndexSettings settings = new IndexSettings(createMetaData(-1, -1, 2), Settings.EMPTY);
|
|
assertEquals(1, settings.getMergeSchedulerConfig().getMaxThreadCount());
|
|
assertEquals(6, settings.getMergeSchedulerConfig().getMaxMergeCount());
|
|
|
|
settings = new IndexSettings(createMetaData(4, 10, -1), Settings.EMPTY);
|
|
assertEquals(4, settings.getMergeSchedulerConfig().getMaxThreadCount());
|
|
assertEquals(10, settings.getMergeSchedulerConfig().getMaxMergeCount());
|
|
IndexMetaData newMetaData = createMetaData(15, 20, -1);
|
|
|
|
settings.updateIndexMetaData(newMetaData);
|
|
assertEquals(15, settings.getMergeSchedulerConfig().getMaxThreadCount());
|
|
assertEquals(20, settings.getMergeSchedulerConfig().getMaxMergeCount());
|
|
|
|
settings.updateIndexMetaData(createMetaData(40, 50, -1));
|
|
assertEquals(40, settings.getMergeSchedulerConfig().getMaxThreadCount());
|
|
assertEquals(50, settings.getMergeSchedulerConfig().getMaxMergeCount());
|
|
|
|
settings.updateIndexMetaData(createMetaData(40, -1, -1));
|
|
assertEquals(40, settings.getMergeSchedulerConfig().getMaxThreadCount());
|
|
assertEquals(45, settings.getMergeSchedulerConfig().getMaxMergeCount());
|
|
|
|
final IndexSettings finalSettings = settings;
|
|
exc = expectThrows(IllegalArgumentException.class,
|
|
() -> finalSettings.updateIndexMetaData(createMetaData(40, 30, -1)));
|
|
assertThat(exc.getMessage(), containsString("maxThreadCount (= 40) should be <= maxMergeCount (= 30)"));
|
|
|
|
exc = expectThrows(IllegalArgumentException.class,
|
|
() -> finalSettings.updateIndexMetaData(createMetaData(-1, 3, 8)));
|
|
assertThat(exc.getMessage(), containsString("maxThreadCount (= 4) should be <= maxMergeCount (= 3)"));
|
|
}
|
|
}
|