OpenSearch/plugins
David Pilato f8e0557be5 Extract AWS Key from KeyChain instead of using potential null value
While I was working on #18703, I discovered a bad behavior when people don't provide AWS key/secret as part as their `elasticsearch.yml` but rely on SysProps or env. variables...

In [`InternalAwsS3Service#getClient(...)`](d4366f8493/plugins/repository-s3/src/main/java/org/elasticsearch/cloud/aws/InternalAwsS3Service.java (L76-L141)), we have:

```java
        Tuple<String, String> clientDescriptor = new Tuple<>(endpoint, account);
        AmazonS3Client client = clients.get(clientDescriptor);
```

But if people don't provide credentials, `account` is `null`.

Even if it actually could work, I think that we should use the `AWSCredentialsProvider` we create later on and extract from it the `account` (AWS KEY actually) and then use it as the second value of the tuple.

Closes #19557.
2016-07-28 18:05:51 +02:00
..
analysis-icu Rename client yaml test infrastructure 2016-07-26 13:53:44 -04:00
analysis-kuromoji Rename client yaml test infrastructure 2016-07-26 13:53:44 -04:00
analysis-phonetic Rename client yaml test infrastructure 2016-07-26 13:53:44 -04:00
analysis-smartcn Rename client yaml test infrastructure 2016-07-26 13:53:44 -04:00
analysis-stempel Rename client yaml test infrastructure 2016-07-26 13:53:44 -04:00
discovery-azure-classic Rename client yaml test infrastructure 2016-07-26 13:53:44 -04:00
discovery-ec2 Merge branch 'pr/19556-use-DefaultAWSCredentialsProviderChain' 2016-07-28 17:38:52 +02:00
discovery-gce Rename GceMetadataServiceImpl to GceMetadataService 2016-07-27 13:28:53 +02:00
ingest-attachment Rename client yaml test infrastructure 2016-07-26 13:53:44 -04:00
ingest-geoip Rename client yaml test infrastructure 2016-07-26 13:53:44 -04:00
ingest-user-agent Rename client yaml test infrastructure 2016-07-26 13:53:44 -04:00
jvm-example Rename client yaml test infrastructure 2016-07-26 13:53:44 -04:00
lang-javascript Rename client yaml test infrastructure 2016-07-26 13:53:44 -04:00
lang-python Rename client yaml test infrastructure 2016-07-26 13:53:44 -04:00
mapper-attachments Rename client yaml test infrastructure 2016-07-26 13:53:44 -04:00
mapper-murmur3 Rename client yaml test infrastructure 2016-07-26 13:53:44 -04:00
mapper-size Rename client yaml test infrastructure 2016-07-26 13:53:44 -04:00
repository-azure Rename client yaml test infrastructure 2016-07-26 13:53:44 -04:00
repository-gcs Rename client yaml test infrastructure 2016-07-26 13:53:44 -04:00
repository-hdfs Rename client yaml test infrastructure 2016-07-26 13:53:44 -04:00
repository-s3 Extract AWS Key from KeyChain instead of using potential null value 2016-07-28 18:05:51 +02:00
store-smb Rename client yaml test infrastructure 2016-07-26 13:53:44 -04:00
build.gradle Revert "Build: Switch to maven-publish plugin" 2016-03-18 17:22:25 -07:00