honeymoose/angular-cn
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
angular-cn/packages/core/schematics/migrations/missing-injectable/BUILD.bazel

24 lines
846 B
Python
Raw Normal View History

feat(ivy): introduce missing-injectable migration for google3 (#30956) Introduces a new migration schematic for adding the "@Injectable()" decorator to provider classes which are currently not migrated. Previously in ViewEngine, classes which are declared as providers sometimes don't require the "@Injectable()" decorator (e.g. https://stackblitz.com/edit/angular-hpo7gw) With Ivy, provider classes need to be explicitly decorated with the "@Injectable()" decorator if they are declared as providers of a given module. This commit introduces a migration schematic which automatically adds the explicit decorator to places where the decorator is currently missing. The migration logic is designed in a CLI devkit and TSlint agnostic way so that we can also have this migration run as part of a public CLI migration w/ `ng update`. This will be handled as part of a follow-up to reiterate on console output etc. Resolves FW-1371 PR Close #30956
2019-06-10 19:08:54 +02:00
load("//tools:defaults.bzl", "ts_library")
ts_library(
name = "missing-injectable",
srcs = glob(["**/*.ts"]),
tsconfig = "//packages/core/schematics:tsconfig.json",
visibility = [
"//packages/core/schematics:__pkg__",
refactor(core): move google3 migration rules into single directory (#30956) Moves all google3 migration tslint rules into a single directory. This makes it easier to wire up multiple migration rules in google3 without having to update the rule directories each time a new migration is available. PR Close #30956
2019-06-18 11:28:23 +02:00
"//packages/core/schematics/migrations/google3:__pkg__",
feat(ivy): introduce missing-injectable migration for google3 (#30956) Introduces a new migration schematic for adding the "@Injectable()" decorator to provider classes which are currently not migrated. Previously in ViewEngine, classes which are declared as providers sometimes don't require the "@Injectable()" decorator (e.g. https://stackblitz.com/edit/angular-hpo7gw) With Ivy, provider classes need to be explicitly decorated with the "@Injectable()" decorator if they are declared as providers of a given module. This commit introduces a migration schematic which automatically adds the explicit decorator to places where the decorator is currently missing. The migration logic is designed in a CLI devkit and TSlint agnostic way so that we can also have this migration run as part of a public CLI migration w/ `ng update`. This will be handled as part of a follow-up to reiterate on console output etc. Resolves FW-1371 PR Close #30956
2019-06-10 19:08:54 +02:00
"//packages/core/schematics/migrations/missing-injectable/google3:__pkg__",
"//packages/core/schematics/test:__pkg__",
],
deps = [
fix(core): missing-injectable migration should handle forwardRef (#33286) Currently the migration is unable to migrate instances where the provider definition uses `forwardRef`. Since this is a common pattern, we should support that from within the migration. The solution to the problem is adding a foreign function resolver to the `PartialEvaluator`. This basically matches the usage of the static evaluation that is used by the ngtsc annotations. PR Close #33286
2019-10-21 15:45:33 +02:00
"//packages/compiler-cli/src/ngtsc/annotations",
feat(ivy): introduce missing-injectable migration for google3 (#30956) Introduces a new migration schematic for adding the "@Injectable()" decorator to provider classes which are currently not migrated. Previously in ViewEngine, classes which are declared as providers sometimes don't require the "@Injectable()" decorator (e.g. https://stackblitz.com/edit/angular-hpo7gw) With Ivy, provider classes need to be explicitly decorated with the "@Injectable()" decorator if they are declared as providers of a given module. This commit introduces a migration schematic which automatically adds the explicit decorator to places where the decorator is currently missing. The migration logic is designed in a CLI devkit and TSlint agnostic way so that we can also have this migration run as part of a public CLI migration w/ `ng update`. This will be handled as part of a follow-up to reiterate on console output etc. Resolves FW-1371 PR Close #30956
2019-06-10 19:08:54 +02:00
"//packages/compiler-cli/src/ngtsc/imports",
"//packages/compiler-cli/src/ngtsc/partial_evaluator",
"//packages/compiler-cli/src/ngtsc/reflection",
"//packages/core/schematics/utils",
"@npm//@angular-devkit/schematics",
"@npm//@types/node",
"@npm//typescript",
],
)
Reference in New Issue Copy Permalink