2018-07-16 05:23:37 -04:00
|
|
|
/**
|
|
|
|
* @license
|
|
|
|
* Copyright Google Inc. All Rights Reserved.
|
|
|
|
*
|
|
|
|
* Use of this source code is governed by an MIT-style license that can be
|
|
|
|
* found in the LICENSE file at https://angular.io/license
|
|
|
|
*/
|
2018-11-25 16:40:25 -05:00
|
|
|
import {dirname} from 'canonical-path';
|
2018-07-16 05:23:37 -04:00
|
|
|
import MagicString from 'magic-string';
|
2018-11-25 16:40:25 -05:00
|
|
|
import * as ts from 'typescript';
|
2019-03-20 09:47:58 -04:00
|
|
|
import {AbsoluteFsPath} from '../../../src/ngtsc/path';
|
2018-09-26 15:53:45 -04:00
|
|
|
import {DecorationAnalyzer} from '../../src/analysis/decoration_analyzer';
|
2018-11-25 16:40:25 -05:00
|
|
|
import {NgccReferencesRegistry} from '../../src/analysis/ngcc_references_registry';
|
2018-10-04 07:19:11 -04:00
|
|
|
import {SwitchMarkerAnalyzer} from '../../src/analysis/switch_marker_analyzer';
|
2018-07-16 05:23:37 -04:00
|
|
|
import {Esm5ReflectionHost} from '../../src/host/esm5_host';
|
2018-11-01 04:21:07 -04:00
|
|
|
import {Esm5Renderer} from '../../src/rendering/esm5_renderer';
|
2018-11-25 17:07:51 -05:00
|
|
|
import {makeTestEntryPointBundle, getDeclaration} from '../helpers/utils';
|
2019-03-29 06:13:14 -04:00
|
|
|
import {MockLogger} from '../helpers/mock_logger';
|
2018-07-16 05:23:37 -04:00
|
|
|
|
|
|
|
function setup(file: {name: string, contents: string}) {
|
2019-03-29 06:13:14 -04:00
|
|
|
const logger = new MockLogger();
|
2019-03-20 09:47:59 -04:00
|
|
|
const bundle = makeTestEntryPointBundle('module', 'esm5', false, [file]);
|
2018-11-25 16:40:25 -05:00
|
|
|
const typeChecker = bundle.src.program.getTypeChecker();
|
2019-03-29 06:13:14 -04:00
|
|
|
const host = new Esm5ReflectionHost(logger, false, typeChecker);
|
2018-11-25 16:40:25 -05:00
|
|
|
const referencesRegistry = new NgccReferencesRegistry(host);
|
feat(ivy): use fileNameToModuleName to emit imports when it's available (#28523)
The ultimate goal of this commit is to make use of fileNameToModuleName to
get the module specifier to use when generating an import, when that API is
available in the CompilerHost that ngtsc is created with.
As part of getting there, the way in which ngtsc tracks references and
generates import module specifiers is refactored considerably. References
are tracked with the Reference class, and previously ngtsc had several
different kinds of Reference. An AbsoluteReference represented a declaration
which needed to be imported via an absolute module specifier tracked in the
AbsoluteReference, and a RelativeReference represented a declaration from
the local program, imported via relative path or referred to directly by
identifier if possible. Thus, how to refer to a particular declaration was
encoded into the Reference type _at the time of creation of the Reference_.
This commit refactors that logic and reduces Reference to a single class
with no subclasses. A Reference represents a node being referenced, plus
context about how the node was located. This context includes a
"bestGuessOwningModule", the compiler's best guess at which absolute
module specifier has defined this reference. For example, if the compiler
arrives at the declaration of CommonModule via an import to @angular/common,
then any references obtained from CommonModule (e.g. NgIf) will also be
considered to be owned by @angular/common.
A ReferenceEmitter class and accompanying ReferenceEmitStrategy interface
are introduced. To produce an Expression referring to a given Reference'd
node, the ReferenceEmitter consults a sequence of ReferenceEmitStrategy
implementations.
Several different strategies are defined:
- LocalIdentifierStrategy: use local ts.Identifiers if available.
- AbsoluteModuleStrategy: if the Reference has a bestGuessOwningModule,
import the node via an absolute import from that module specifier.
- LogicalProjectStrategy: if the Reference is in the logical project
(is under the project rootDirs), import the node via a relative import.
- FileToModuleStrategy: use a FileToModuleHost to generate the module
specifier by which to import the node.
Depending on the availability of fileNameToModuleName in the CompilerHost,
then, a different collection of these strategies is used for compilation.
PR Close #28523
2019-02-01 20:24:21 -05:00
|
|
|
const decorationAnalyses =
|
|
|
|
new DecorationAnalyzer(
|
|
|
|
bundle.src.program, bundle.src.options, bundle.src.host, typeChecker, host,
|
|
|
|
referencesRegistry, [AbsoluteFsPath.fromUnchecked('/')], false)
|
|
|
|
.analyzeProgram();
|
2018-11-25 16:40:25 -05:00
|
|
|
const switchMarkerAnalyses = new SwitchMarkerAnalyzer(host).analyzeProgram(bundle.src.program);
|
2019-04-28 15:47:56 -04:00
|
|
|
const renderer = new Esm5Renderer(logger, host, false, bundle);
|
2018-11-25 16:40:25 -05:00
|
|
|
return {
|
|
|
|
host,
|
|
|
|
program: bundle.src.program,
|
|
|
|
sourceFile: bundle.src.file, renderer, decorationAnalyses, switchMarkerAnalyses
|
|
|
|
};
|
2018-07-16 05:23:37 -04:00
|
|
|
}
|
|
|
|
|
2018-08-23 04:01:21 -04:00
|
|
|
const PROGRAM = {
|
2018-11-25 16:40:25 -05:00
|
|
|
name: '/some/file.js',
|
2018-08-23 04:01:21 -04:00
|
|
|
contents: `
|
2018-07-16 05:23:37 -04:00
|
|
|
/* A copyright notice */
|
2019-04-22 08:57:31 -04:00
|
|
|
import 'some-side-effect';
|
2018-07-16 05:23:37 -04:00
|
|
|
import {Directive} from '@angular/core';
|
|
|
|
var A = (function() {
|
|
|
|
function A() {}
|
|
|
|
A.decorators = [
|
|
|
|
{ type: Directive, args: [{ selector: '[a]' }] },
|
2018-08-23 04:01:21 -04:00
|
|
|
{ type: OtherA }
|
2018-07-16 05:23:37 -04:00
|
|
|
];
|
2018-11-01 04:21:07 -04:00
|
|
|
A.prototype.ngDoCheck = function() {
|
|
|
|
//
|
|
|
|
};
|
2018-07-16 05:23:37 -04:00
|
|
|
return A;
|
|
|
|
}());
|
2018-08-23 04:01:21 -04:00
|
|
|
|
|
|
|
var B = (function() {
|
|
|
|
function B() {}
|
|
|
|
B.decorators = [
|
|
|
|
{ type: OtherB },
|
|
|
|
{ type: Directive, args: [{ selector: '[b]' }] }
|
|
|
|
];
|
|
|
|
return B;
|
|
|
|
}());
|
|
|
|
|
|
|
|
var C = (function() {
|
|
|
|
function C() {}
|
|
|
|
C.decorators = [
|
|
|
|
{ type: Directive, args: [{ selector: '[c]' }] },
|
|
|
|
];
|
|
|
|
return C;
|
|
|
|
}());
|
|
|
|
|
2018-11-01 04:21:07 -04:00
|
|
|
function NoIife() {}
|
|
|
|
|
|
|
|
var BadIife = (function() {
|
|
|
|
function BadIife() {}
|
|
|
|
BadIife.decorators = [
|
|
|
|
{ type: Directive, args: [{ selector: '[c]' }] },
|
|
|
|
];
|
|
|
|
}());
|
|
|
|
|
refactor(ivy): obviate the Bazel component of the ivy_switch (#26550)
Originally, the ivy_switch mechanism used Bazel genrules to conditionally
compile one TS file or another depending on whether ngc or ngtsc was the
selected compiler. This was done because we wanted to avoid importing
certain modules (and thus pulling them into the build) if Ivy was on or
off. This mechanism had a major drawback: ivy_switch became a bottleneck
in the import graph, as it both imports from many places in the codebase
and is imported by many modules in the codebase. This frequently resulted
in cyclic imports which caused issues both with TS and Closure compilation.
It turns out ngcc needs both code paths in the bundle to perform the switch
during its operation anyway, so import switching was later abandoned. This
means that there's no real reason why the ivy_switch mechanism needed to
operate at the Bazel level, and for the ivy_switch file to be a bottleneck.
This commit removes the Bazel-level ivy_switch mechanism, and introduces
an additional TypeScript transform in ngtsc (and the pass-through tsc
compiler used for testing JIT) to perform the same operation that ngcc
does, and flip the switch during ngtsc compilation. This allows the
ivy_switch file to be removed, and the individual switches to be located
directly next to their consumers in the codebase, greatly mitigating the
circular import issues and making the mechanism much easier to use.
As part of this commit, the tag for marking switched variables was changed
from __PRE_NGCC__ to __PRE_R3__, since it's no longer just ngcc which
flips these tags. Most variables were renamed from R3_* to SWITCH_* as well,
since they're referenced mostly in render2 code.
Test strategy: existing test coverage is more than sufficient - if this
didn't work correctly it would break the hello world and todo apps.
PR Close #26550
2018-10-17 18:44:44 -04:00
|
|
|
var compileNgModuleFactory = compileNgModuleFactory__PRE_R3__;
|
|
|
|
var badlyFormattedVariable = __PRE_R3__badlyFormattedVariable;
|
|
|
|
function compileNgModuleFactory__PRE_R3__(injector, options, moduleType) {
|
2018-08-23 04:01:29 -04:00
|
|
|
const compilerFactory = injector.get(CompilerFactory);
|
|
|
|
const compiler = compilerFactory.createCompiler([options]);
|
|
|
|
return compiler.compileModuleAsync(moduleType);
|
|
|
|
}
|
|
|
|
|
refactor(ivy): obviate the Bazel component of the ivy_switch (#26550)
Originally, the ivy_switch mechanism used Bazel genrules to conditionally
compile one TS file or another depending on whether ngc or ngtsc was the
selected compiler. This was done because we wanted to avoid importing
certain modules (and thus pulling them into the build) if Ivy was on or
off. This mechanism had a major drawback: ivy_switch became a bottleneck
in the import graph, as it both imports from many places in the codebase
and is imported by many modules in the codebase. This frequently resulted
in cyclic imports which caused issues both with TS and Closure compilation.
It turns out ngcc needs both code paths in the bundle to perform the switch
during its operation anyway, so import switching was later abandoned. This
means that there's no real reason why the ivy_switch mechanism needed to
operate at the Bazel level, and for the ivy_switch file to be a bottleneck.
This commit removes the Bazel-level ivy_switch mechanism, and introduces
an additional TypeScript transform in ngtsc (and the pass-through tsc
compiler used for testing JIT) to perform the same operation that ngcc
does, and flip the switch during ngtsc compilation. This allows the
ivy_switch file to be removed, and the individual switches to be located
directly next to their consumers in the codebase, greatly mitigating the
circular import issues and making the mechanism much easier to use.
As part of this commit, the tag for marking switched variables was changed
from __PRE_NGCC__ to __PRE_R3__, since it's no longer just ngcc which
flips these tags. Most variables were renamed from R3_* to SWITCH_* as well,
since they're referenced mostly in render2 code.
Test strategy: existing test coverage is more than sufficient - if this
didn't work correctly it would break the hello world and todo apps.
PR Close #26550
2018-10-17 18:44:44 -04:00
|
|
|
function compileNgModuleFactory__POST_R3__(injector, options, moduleType) {
|
2018-08-23 04:01:29 -04:00
|
|
|
ngDevMode && assertNgModuleType(moduleType);
|
|
|
|
return Promise.resolve(new R3NgModuleFactory(moduleType));
|
|
|
|
}
|
2018-07-16 05:23:37 -04:00
|
|
|
// Some other content
|
2018-11-01 04:21:07 -04:00
|
|
|
export {A, B, C, NoIife, BadIife};`
|
2018-08-23 04:01:21 -04:00
|
|
|
};
|
|
|
|
|
2018-09-24 15:50:25 -04:00
|
|
|
const PROGRAM_DECORATE_HELPER = {
|
2018-11-25 16:40:25 -05:00
|
|
|
name: '/some/file.js',
|
2018-09-24 15:50:25 -04:00
|
|
|
contents: `
|
|
|
|
import * as tslib_1 from "tslib";
|
|
|
|
/* A copyright notice */
|
|
|
|
import { Directive } from '@angular/core';
|
|
|
|
var OtherA = function () { return function (node) { }; };
|
|
|
|
var OtherB = function () { return function (node) { }; };
|
|
|
|
var A = /** @class */ (function () {
|
|
|
|
function A() {
|
|
|
|
}
|
|
|
|
A = tslib_1.__decorate([
|
|
|
|
Directive({ selector: '[a]' }),
|
|
|
|
OtherA()
|
|
|
|
], A);
|
|
|
|
return A;
|
|
|
|
}());
|
|
|
|
export { A };
|
|
|
|
var B = /** @class */ (function () {
|
|
|
|
function B() {
|
|
|
|
}
|
|
|
|
B = tslib_1.__decorate([
|
|
|
|
OtherB(),
|
|
|
|
Directive({ selector: '[b]' })
|
|
|
|
], B);
|
|
|
|
return B;
|
|
|
|
}());
|
|
|
|
export { B };
|
|
|
|
var C = /** @class */ (function () {
|
|
|
|
function C() {
|
|
|
|
}
|
|
|
|
C = tslib_1.__decorate([
|
|
|
|
Directive({ selector: '[c]' })
|
|
|
|
], C);
|
|
|
|
return C;
|
|
|
|
}());
|
|
|
|
export { C };
|
|
|
|
var D = /** @class */ (function () {
|
|
|
|
function D() {
|
|
|
|
}
|
|
|
|
D_1 = D;
|
|
|
|
var D_1;
|
|
|
|
D = D_1 = tslib_1.__decorate([
|
|
|
|
Directive({ selector: '[d]', providers: [D_1] })
|
|
|
|
], D);
|
|
|
|
return D;
|
|
|
|
}());
|
|
|
|
export { D };
|
|
|
|
// Some other content`
|
|
|
|
};
|
|
|
|
|
2018-08-23 04:01:21 -04:00
|
|
|
describe('Esm5Renderer', () => {
|
|
|
|
|
|
|
|
describe('addImports', () => {
|
2019-04-22 08:57:31 -04:00
|
|
|
it('should insert the given imports after existing imports of the source file', () => {
|
|
|
|
const {renderer, sourceFile} = setup(PROGRAM);
|
2018-07-16 05:23:37 -04:00
|
|
|
const output = new MagicString(PROGRAM.contents);
|
2019-04-22 08:57:31 -04:00
|
|
|
renderer.addImports(
|
|
|
|
output,
|
|
|
|
[
|
|
|
|
{specifier: '@angular/core', qualifier: 'i0'},
|
|
|
|
{specifier: '@angular/common', qualifier: 'i1'}
|
|
|
|
],
|
|
|
|
sourceFile);
|
|
|
|
expect(output.toString()).toContain(`/* A copyright notice */
|
|
|
|
import 'some-side-effect';
|
|
|
|
import {Directive} from '@angular/core';
|
|
|
|
import * as i0 from '@angular/core';
|
|
|
|
import * as i1 from '@angular/common';`);
|
2018-07-16 05:23:37 -04:00
|
|
|
});
|
|
|
|
});
|
|
|
|
|
2018-11-25 17:07:51 -05:00
|
|
|
describe('addExports', () => {
|
|
|
|
it('should insert the given exports at the end of the source file', () => {
|
|
|
|
const {renderer} = setup(PROGRAM);
|
|
|
|
const output = new MagicString(PROGRAM.contents);
|
|
|
|
renderer.addExports(output, PROGRAM.name.replace(/\.js$/, ''), [
|
2019-02-14 12:59:46 -05:00
|
|
|
{from: '/some/a.js', dtsFrom: '/some/a.d.ts', identifier: 'ComponentA1'},
|
|
|
|
{from: '/some/a.js', dtsFrom: '/some/a.d.ts', identifier: 'ComponentA2'},
|
|
|
|
{from: '/some/foo/b.js', dtsFrom: '/some/foo/b.d.ts', identifier: 'ComponentB'},
|
|
|
|
{from: PROGRAM.name, dtsFrom: PROGRAM.name, identifier: 'TopLevelComponent'},
|
2018-11-25 17:07:51 -05:00
|
|
|
]);
|
|
|
|
expect(output.toString()).toContain(`
|
|
|
|
export {A, B, C, NoIife, BadIife};
|
|
|
|
export {ComponentA1} from './a';
|
|
|
|
export {ComponentA2} from './a';
|
|
|
|
export {ComponentB} from './foo/b';
|
|
|
|
export {TopLevelComponent};`);
|
|
|
|
});
|
2019-02-14 12:59:46 -05:00
|
|
|
|
|
|
|
it('should not insert alias exports in js output', () => {
|
|
|
|
const {renderer} = setup(PROGRAM);
|
|
|
|
const output = new MagicString(PROGRAM.contents);
|
|
|
|
renderer.addExports(output, PROGRAM.name.replace(/\.js$/, ''), [
|
|
|
|
{from: '/some/a.js', alias: 'eComponentA1', identifier: 'ComponentA1'},
|
|
|
|
{from: '/some/a.js', alias: 'eComponentA2', identifier: 'ComponentA2'},
|
|
|
|
{from: '/some/foo/b.js', alias: 'eComponentB', identifier: 'ComponentB'},
|
|
|
|
{from: PROGRAM.name, alias: 'eTopLevelComponent', identifier: 'TopLevelComponent'},
|
|
|
|
]);
|
|
|
|
const outputString = output.toString();
|
|
|
|
expect(outputString).not.toContain(`{eComponentA1 as ComponentA1}`);
|
|
|
|
expect(outputString).not.toContain(`{eComponentB as ComponentB}`);
|
|
|
|
expect(outputString).not.toContain(`{eTopLevelComponent as TopLevelComponent}`);
|
|
|
|
});
|
2018-11-25 17:07:51 -05:00
|
|
|
});
|
2018-07-16 05:23:37 -04:00
|
|
|
|
2018-08-23 04:01:21 -04:00
|
|
|
describe('addConstants', () => {
|
|
|
|
it('should insert the given constants after imports in the source file', () => {
|
|
|
|
const {renderer, program} = setup(PROGRAM);
|
|
|
|
const file = program.getSourceFile('some/file.js');
|
|
|
|
if (file === undefined) {
|
|
|
|
throw new Error(`Could not find source file`);
|
|
|
|
}
|
|
|
|
const output = new MagicString(PROGRAM.contents);
|
|
|
|
renderer.addConstants(output, 'const x = 3;', file);
|
|
|
|
expect(output.toString()).toContain(`
|
|
|
|
import {Directive} from '@angular/core';
|
2019-04-22 08:57:31 -04:00
|
|
|
|
2018-08-23 04:01:21 -04:00
|
|
|
const x = 3;
|
2019-04-22 08:57:31 -04:00
|
|
|
var A = (function() {`);
|
|
|
|
});
|
|
|
|
|
|
|
|
it('should insert constants after inserted imports', () => {
|
|
|
|
const {renderer, program} = setup(PROGRAM);
|
|
|
|
const file = program.getSourceFile('some/file.js');
|
|
|
|
if (file === undefined) {
|
|
|
|
throw new Error(`Could not find source file`);
|
|
|
|
}
|
|
|
|
const output = new MagicString(PROGRAM.contents);
|
|
|
|
renderer.addConstants(output, 'const x = 3;', file);
|
|
|
|
renderer.addImports(output, [{specifier: '@angular/core', qualifier: 'i0'}], file);
|
|
|
|
expect(output.toString()).toContain(`
|
|
|
|
import {Directive} from '@angular/core';
|
|
|
|
import * as i0 from '@angular/core';
|
2018-08-23 04:01:21 -04:00
|
|
|
|
2019-04-22 08:57:31 -04:00
|
|
|
const x = 3;
|
2018-08-23 04:01:21 -04:00
|
|
|
var A = (function() {`);
|
|
|
|
});
|
|
|
|
});
|
|
|
|
|
2018-08-23 04:01:29 -04:00
|
|
|
describe('rewriteSwitchableDeclarations', () => {
|
|
|
|
it('should switch marked declaration initializers', () => {
|
2018-10-04 07:19:11 -04:00
|
|
|
const {renderer, program, sourceFile, switchMarkerAnalyses} = setup(PROGRAM);
|
2018-08-23 04:01:29 -04:00
|
|
|
const file = program.getSourceFile('some/file.js');
|
|
|
|
if (file === undefined) {
|
|
|
|
throw new Error(`Could not find source file`);
|
|
|
|
}
|
|
|
|
const output = new MagicString(PROGRAM.contents);
|
2018-10-04 07:19:11 -04:00
|
|
|
renderer.rewriteSwitchableDeclarations(
|
|
|
|
output, file, switchMarkerAnalyses.get(sourceFile) !.declarations);
|
2018-08-23 04:01:29 -04:00
|
|
|
expect(output.toString())
|
refactor(ivy): obviate the Bazel component of the ivy_switch (#26550)
Originally, the ivy_switch mechanism used Bazel genrules to conditionally
compile one TS file or another depending on whether ngc or ngtsc was the
selected compiler. This was done because we wanted to avoid importing
certain modules (and thus pulling them into the build) if Ivy was on or
off. This mechanism had a major drawback: ivy_switch became a bottleneck
in the import graph, as it both imports from many places in the codebase
and is imported by many modules in the codebase. This frequently resulted
in cyclic imports which caused issues both with TS and Closure compilation.
It turns out ngcc needs both code paths in the bundle to perform the switch
during its operation anyway, so import switching was later abandoned. This
means that there's no real reason why the ivy_switch mechanism needed to
operate at the Bazel level, and for the ivy_switch file to be a bottleneck.
This commit removes the Bazel-level ivy_switch mechanism, and introduces
an additional TypeScript transform in ngtsc (and the pass-through tsc
compiler used for testing JIT) to perform the same operation that ngcc
does, and flip the switch during ngtsc compilation. This allows the
ivy_switch file to be removed, and the individual switches to be located
directly next to their consumers in the codebase, greatly mitigating the
circular import issues and making the mechanism much easier to use.
As part of this commit, the tag for marking switched variables was changed
from __PRE_NGCC__ to __PRE_R3__, since it's no longer just ngcc which
flips these tags. Most variables were renamed from R3_* to SWITCH_* as well,
since they're referenced mostly in render2 code.
Test strategy: existing test coverage is more than sufficient - if this
didn't work correctly it would break the hello world and todo apps.
PR Close #26550
2018-10-17 18:44:44 -04:00
|
|
|
.not.toContain(`var compileNgModuleFactory = compileNgModuleFactory__PRE_R3__;`);
|
2018-08-23 04:01:29 -04:00
|
|
|
expect(output.toString())
|
refactor(ivy): obviate the Bazel component of the ivy_switch (#26550)
Originally, the ivy_switch mechanism used Bazel genrules to conditionally
compile one TS file or another depending on whether ngc or ngtsc was the
selected compiler. This was done because we wanted to avoid importing
certain modules (and thus pulling them into the build) if Ivy was on or
off. This mechanism had a major drawback: ivy_switch became a bottleneck
in the import graph, as it both imports from many places in the codebase
and is imported by many modules in the codebase. This frequently resulted
in cyclic imports which caused issues both with TS and Closure compilation.
It turns out ngcc needs both code paths in the bundle to perform the switch
during its operation anyway, so import switching was later abandoned. This
means that there's no real reason why the ivy_switch mechanism needed to
operate at the Bazel level, and for the ivy_switch file to be a bottleneck.
This commit removes the Bazel-level ivy_switch mechanism, and introduces
an additional TypeScript transform in ngtsc (and the pass-through tsc
compiler used for testing JIT) to perform the same operation that ngcc
does, and flip the switch during ngtsc compilation. This allows the
ivy_switch file to be removed, and the individual switches to be located
directly next to their consumers in the codebase, greatly mitigating the
circular import issues and making the mechanism much easier to use.
As part of this commit, the tag for marking switched variables was changed
from __PRE_NGCC__ to __PRE_R3__, since it's no longer just ngcc which
flips these tags. Most variables were renamed from R3_* to SWITCH_* as well,
since they're referenced mostly in render2 code.
Test strategy: existing test coverage is more than sufficient - if this
didn't work correctly it would break the hello world and todo apps.
PR Close #26550
2018-10-17 18:44:44 -04:00
|
|
|
.toContain(`var badlyFormattedVariable = __PRE_R3__badlyFormattedVariable;`);
|
2018-08-23 04:01:29 -04:00
|
|
|
expect(output.toString())
|
refactor(ivy): obviate the Bazel component of the ivy_switch (#26550)
Originally, the ivy_switch mechanism used Bazel genrules to conditionally
compile one TS file or another depending on whether ngc or ngtsc was the
selected compiler. This was done because we wanted to avoid importing
certain modules (and thus pulling them into the build) if Ivy was on or
off. This mechanism had a major drawback: ivy_switch became a bottleneck
in the import graph, as it both imports from many places in the codebase
and is imported by many modules in the codebase. This frequently resulted
in cyclic imports which caused issues both with TS and Closure compilation.
It turns out ngcc needs both code paths in the bundle to perform the switch
during its operation anyway, so import switching was later abandoned. This
means that there's no real reason why the ivy_switch mechanism needed to
operate at the Bazel level, and for the ivy_switch file to be a bottleneck.
This commit removes the Bazel-level ivy_switch mechanism, and introduces
an additional TypeScript transform in ngtsc (and the pass-through tsc
compiler used for testing JIT) to perform the same operation that ngcc
does, and flip the switch during ngtsc compilation. This allows the
ivy_switch file to be removed, and the individual switches to be located
directly next to their consumers in the codebase, greatly mitigating the
circular import issues and making the mechanism much easier to use.
As part of this commit, the tag for marking switched variables was changed
from __PRE_NGCC__ to __PRE_R3__, since it's no longer just ngcc which
flips these tags. Most variables were renamed from R3_* to SWITCH_* as well,
since they're referenced mostly in render2 code.
Test strategy: existing test coverage is more than sufficient - if this
didn't work correctly it would break the hello world and todo apps.
PR Close #26550
2018-10-17 18:44:44 -04:00
|
|
|
.toContain(`var compileNgModuleFactory = compileNgModuleFactory__POST_R3__;`);
|
2018-08-23 04:01:29 -04:00
|
|
|
expect(output.toString())
|
refactor(ivy): obviate the Bazel component of the ivy_switch (#26550)
Originally, the ivy_switch mechanism used Bazel genrules to conditionally
compile one TS file or another depending on whether ngc or ngtsc was the
selected compiler. This was done because we wanted to avoid importing
certain modules (and thus pulling them into the build) if Ivy was on or
off. This mechanism had a major drawback: ivy_switch became a bottleneck
in the import graph, as it both imports from many places in the codebase
and is imported by many modules in the codebase. This frequently resulted
in cyclic imports which caused issues both with TS and Closure compilation.
It turns out ngcc needs both code paths in the bundle to perform the switch
during its operation anyway, so import switching was later abandoned. This
means that there's no real reason why the ivy_switch mechanism needed to
operate at the Bazel level, and for the ivy_switch file to be a bottleneck.
This commit removes the Bazel-level ivy_switch mechanism, and introduces
an additional TypeScript transform in ngtsc (and the pass-through tsc
compiler used for testing JIT) to perform the same operation that ngcc
does, and flip the switch during ngtsc compilation. This allows the
ivy_switch file to be removed, and the individual switches to be located
directly next to their consumers in the codebase, greatly mitigating the
circular import issues and making the mechanism much easier to use.
As part of this commit, the tag for marking switched variables was changed
from __PRE_NGCC__ to __PRE_R3__, since it's no longer just ngcc which
flips these tags. Most variables were renamed from R3_* to SWITCH_* as well,
since they're referenced mostly in render2 code.
Test strategy: existing test coverage is more than sufficient - if this
didn't work correctly it would break the hello world and todo apps.
PR Close #26550
2018-10-17 18:44:44 -04:00
|
|
|
.toContain(`function compileNgModuleFactory__PRE_R3__(injector, options, moduleType) {`);
|
2018-08-23 04:01:29 -04:00
|
|
|
expect(output.toString())
|
refactor(ivy): obviate the Bazel component of the ivy_switch (#26550)
Originally, the ivy_switch mechanism used Bazel genrules to conditionally
compile one TS file or another depending on whether ngc or ngtsc was the
selected compiler. This was done because we wanted to avoid importing
certain modules (and thus pulling them into the build) if Ivy was on or
off. This mechanism had a major drawback: ivy_switch became a bottleneck
in the import graph, as it both imports from many places in the codebase
and is imported by many modules in the codebase. This frequently resulted
in cyclic imports which caused issues both with TS and Closure compilation.
It turns out ngcc needs both code paths in the bundle to perform the switch
during its operation anyway, so import switching was later abandoned. This
means that there's no real reason why the ivy_switch mechanism needed to
operate at the Bazel level, and for the ivy_switch file to be a bottleneck.
This commit removes the Bazel-level ivy_switch mechanism, and introduces
an additional TypeScript transform in ngtsc (and the pass-through tsc
compiler used for testing JIT) to perform the same operation that ngcc
does, and flip the switch during ngtsc compilation. This allows the
ivy_switch file to be removed, and the individual switches to be located
directly next to their consumers in the codebase, greatly mitigating the
circular import issues and making the mechanism much easier to use.
As part of this commit, the tag for marking switched variables was changed
from __PRE_NGCC__ to __PRE_R3__, since it's no longer just ngcc which
flips these tags. Most variables were renamed from R3_* to SWITCH_* as well,
since they're referenced mostly in render2 code.
Test strategy: existing test coverage is more than sufficient - if this
didn't work correctly it would break the hello world and todo apps.
PR Close #26550
2018-10-17 18:44:44 -04:00
|
|
|
.toContain(`function compileNgModuleFactory__POST_R3__(injector, options, moduleType) {`);
|
2018-08-23 04:01:29 -04:00
|
|
|
});
|
|
|
|
});
|
|
|
|
|
2018-07-16 05:23:37 -04:00
|
|
|
describe('addDefinitions', () => {
|
2018-11-01 04:21:07 -04:00
|
|
|
it('should insert the definitions directly before the return statement of the class IIFE',
|
|
|
|
() => {
|
|
|
|
const {renderer, decorationAnalyses, sourceFile} = setup(PROGRAM);
|
|
|
|
const output = new MagicString(PROGRAM.contents);
|
|
|
|
const compiledClass =
|
|
|
|
decorationAnalyses.get(sourceFile) !.compiledClasses.find(c => c.name === 'A') !;
|
|
|
|
renderer.addDefinitions(output, compiledClass, 'SOME DEFINITION TEXT');
|
|
|
|
expect(output.toString()).toContain(`
|
|
|
|
A.prototype.ngDoCheck = function() {
|
|
|
|
//
|
|
|
|
};
|
2018-07-16 05:23:37 -04:00
|
|
|
SOME DEFINITION TEXT
|
2018-11-01 04:21:07 -04:00
|
|
|
return A;
|
2018-08-23 04:01:21 -04:00
|
|
|
`);
|
2018-11-01 04:21:07 -04:00
|
|
|
});
|
|
|
|
|
|
|
|
it('should error if the compiledClass is not valid', () => {
|
|
|
|
const {renderer, host, sourceFile, program} = setup(PROGRAM);
|
|
|
|
const output = new MagicString(PROGRAM.contents);
|
2018-07-16 05:23:37 -04:00
|
|
|
|
2018-11-01 04:21:07 -04:00
|
|
|
const noIifeDeclaration =
|
|
|
|
getDeclaration(program, sourceFile.fileName, 'NoIife', ts.isFunctionDeclaration);
|
|
|
|
const mockNoIifeClass: any = {declaration: noIifeDeclaration, name: 'NoIife'};
|
|
|
|
expect(() => renderer.addDefinitions(output, mockNoIifeClass, 'SOME DEFINITION TEXT'))
|
|
|
|
.toThrowError(
|
|
|
|
'Compiled class declaration is not inside an IIFE: NoIife in /some/file.js');
|
|
|
|
|
|
|
|
const badIifeDeclaration =
|
2019-03-20 06:10:58 -04:00
|
|
|
getDeclaration(program, sourceFile.fileName, 'BadIife', ts.isVariableDeclaration);
|
2018-11-01 04:21:07 -04:00
|
|
|
const mockBadIifeClass: any = {declaration: badIifeDeclaration, name: 'BadIife'};
|
|
|
|
expect(() => renderer.addDefinitions(output, mockBadIifeClass, 'SOME DEFINITION TEXT'))
|
|
|
|
.toThrowError(
|
|
|
|
'Compiled class wrapper IIFE does not have a return statement: BadIife in /some/file.js');
|
|
|
|
});
|
2018-07-16 05:23:37 -04:00
|
|
|
});
|
|
|
|
|
|
|
|
|
|
|
|
describe('removeDecorators', () => {
|
|
|
|
|
|
|
|
it('should delete the decorator (and following comma) that was matched in the analysis', () => {
|
2018-10-04 07:19:11 -04:00
|
|
|
const {renderer, decorationAnalyses, sourceFile} = setup(PROGRAM);
|
2018-07-16 05:23:37 -04:00
|
|
|
const output = new MagicString(PROGRAM.contents);
|
2018-10-16 03:56:54 -04:00
|
|
|
const compiledClass =
|
|
|
|
decorationAnalyses.get(sourceFile) !.compiledClasses.find(c => c.name === 'A') !;
|
|
|
|
const decorator = compiledClass.decorators[0];
|
2018-07-16 05:23:37 -04:00
|
|
|
const decoratorsToRemove = new Map<ts.Node, ts.Node[]>();
|
2018-08-23 04:01:21 -04:00
|
|
|
decoratorsToRemove.set(decorator.node.parent !, [decorator.node]);
|
2018-07-16 05:23:37 -04:00
|
|
|
renderer.removeDecorators(output, decoratorsToRemove);
|
2018-08-23 04:01:21 -04:00
|
|
|
expect(output.toString()).not.toContain(`{ type: Directive, args: [{ selector: '[a]' }] },`);
|
|
|
|
expect(output.toString()).toContain(`{ type: OtherA }`);
|
|
|
|
expect(output.toString()).toContain(`{ type: Directive, args: [{ selector: '[b]' }] }`);
|
|
|
|
expect(output.toString()).toContain(`{ type: OtherB }`);
|
|
|
|
expect(output.toString()).toContain(`{ type: Directive, args: [{ selector: '[c]' }] }`);
|
2018-07-16 05:23:37 -04:00
|
|
|
});
|
|
|
|
|
|
|
|
|
|
|
|
it('should delete the decorator (but cope with no trailing comma) that was matched in the analysis',
|
|
|
|
() => {
|
2018-10-04 07:19:11 -04:00
|
|
|
const {renderer, decorationAnalyses, sourceFile} = setup(PROGRAM);
|
2018-07-16 05:23:37 -04:00
|
|
|
const output = new MagicString(PROGRAM.contents);
|
2018-10-16 03:56:54 -04:00
|
|
|
const compiledClass =
|
|
|
|
decorationAnalyses.get(sourceFile) !.compiledClasses.find(c => c.name === 'B') !;
|
|
|
|
const decorator = compiledClass.decorators[0];
|
2018-07-16 05:23:37 -04:00
|
|
|
const decoratorsToRemove = new Map<ts.Node, ts.Node[]>();
|
2018-08-23 04:01:21 -04:00
|
|
|
decoratorsToRemove.set(decorator.node.parent !, [decorator.node]);
|
2018-07-16 05:23:37 -04:00
|
|
|
renderer.removeDecorators(output, decoratorsToRemove);
|
2018-08-23 04:01:21 -04:00
|
|
|
expect(output.toString()).toContain(`{ type: Directive, args: [{ selector: '[a]' }] },`);
|
|
|
|
expect(output.toString()).toContain(`{ type: OtherA }`);
|
|
|
|
expect(output.toString())
|
|
|
|
.not.toContain(`{ type: Directive, args: [{ selector: '[b]' }] }`);
|
|
|
|
expect(output.toString()).toContain(`{ type: OtherB }`);
|
|
|
|
expect(output.toString()).toContain(`{ type: Directive, args: [{ selector: '[c]' }] }`);
|
2018-07-16 05:23:37 -04:00
|
|
|
});
|
|
|
|
|
|
|
|
|
|
|
|
it('should delete the decorator (and its container if there are not other decorators left) that was matched in the analysis',
|
|
|
|
() => {
|
2018-10-04 07:19:11 -04:00
|
|
|
const {renderer, decorationAnalyses, sourceFile} = setup(PROGRAM);
|
2018-07-16 05:23:37 -04:00
|
|
|
const output = new MagicString(PROGRAM.contents);
|
2018-10-16 03:56:54 -04:00
|
|
|
const compiledClass =
|
|
|
|
decorationAnalyses.get(sourceFile) !.compiledClasses.find(c => c.name === 'C') !;
|
|
|
|
const decorator = compiledClass.decorators[0];
|
2018-07-16 05:23:37 -04:00
|
|
|
const decoratorsToRemove = new Map<ts.Node, ts.Node[]>();
|
2018-08-23 04:01:21 -04:00
|
|
|
decoratorsToRemove.set(decorator.node.parent !, [decorator.node]);
|
2018-07-16 05:23:37 -04:00
|
|
|
renderer.removeDecorators(output, decoratorsToRemove);
|
2018-11-18 15:37:30 -05:00
|
|
|
renderer.addDefinitions(output, compiledClass, 'SOME DEFINITION TEXT');
|
2018-08-23 04:01:21 -04:00
|
|
|
expect(output.toString()).toContain(`{ type: Directive, args: [{ selector: '[a]' }] },`);
|
|
|
|
expect(output.toString()).toContain(`{ type: OtherA }`);
|
|
|
|
expect(output.toString()).toContain(`{ type: Directive, args: [{ selector: '[b]' }] }`);
|
|
|
|
expect(output.toString()).toContain(`{ type: OtherB }`);
|
2018-11-18 15:37:30 -05:00
|
|
|
expect(output.toString()).toContain(`function C() {}\nSOME DEFINITION TEXT\n return C;`);
|
2018-08-23 04:01:21 -04:00
|
|
|
expect(output.toString()).not.toContain(`C.decorators = [
|
|
|
|
{ type: Directive, args: [{ selector: '[c]' }] },
|
|
|
|
];`);
|
2018-07-16 05:23:37 -04:00
|
|
|
});
|
|
|
|
|
|
|
|
});
|
2018-09-24 15:50:25 -04:00
|
|
|
|
|
|
|
describe('[__decorate declarations]', () => {
|
|
|
|
it('should delete the decorator (and following comma) that was matched in the analysis', () => {
|
2018-10-04 07:19:11 -04:00
|
|
|
const {renderer, decorationAnalyses, sourceFile} = setup(PROGRAM_DECORATE_HELPER);
|
2018-09-24 15:50:25 -04:00
|
|
|
const output = new MagicString(PROGRAM_DECORATE_HELPER.contents);
|
2018-10-16 03:56:54 -04:00
|
|
|
const compiledClass =
|
|
|
|
decorationAnalyses.get(sourceFile) !.compiledClasses.find(c => c.name === 'A') !;
|
|
|
|
const decorator = compiledClass.decorators.find(d => d.name === 'Directive') !;
|
2018-09-24 15:50:25 -04:00
|
|
|
const decoratorsToRemove = new Map<ts.Node, ts.Node[]>();
|
|
|
|
decoratorsToRemove.set(decorator.node.parent !, [decorator.node]);
|
|
|
|
renderer.removeDecorators(output, decoratorsToRemove);
|
|
|
|
expect(output.toString()).not.toContain(`Directive({ selector: '[a]' }),`);
|
|
|
|
expect(output.toString()).toContain(`OtherA()`);
|
|
|
|
expect(output.toString()).toContain(`Directive({ selector: '[b]' })`);
|
|
|
|
expect(output.toString()).toContain(`OtherB()`);
|
|
|
|
expect(output.toString()).toContain(`Directive({ selector: '[c]' })`);
|
|
|
|
});
|
|
|
|
|
|
|
|
it('should delete the decorator (but cope with no trailing comma) that was matched in the analysis',
|
|
|
|
() => {
|
2018-10-04 07:19:11 -04:00
|
|
|
const {renderer, decorationAnalyses, sourceFile} = setup(PROGRAM_DECORATE_HELPER);
|
2018-09-24 15:50:25 -04:00
|
|
|
const output = new MagicString(PROGRAM_DECORATE_HELPER.contents);
|
2018-10-16 03:56:54 -04:00
|
|
|
const compiledClass =
|
|
|
|
decorationAnalyses.get(sourceFile) !.compiledClasses.find(c => c.name === 'B') !;
|
|
|
|
const decorator = compiledClass.decorators.find(d => d.name === 'Directive') !;
|
2018-09-24 15:50:25 -04:00
|
|
|
const decoratorsToRemove = new Map<ts.Node, ts.Node[]>();
|
|
|
|
decoratorsToRemove.set(decorator.node.parent !, [decorator.node]);
|
|
|
|
renderer.removeDecorators(output, decoratorsToRemove);
|
|
|
|
expect(output.toString()).toContain(`Directive({ selector: '[a]' }),`);
|
|
|
|
expect(output.toString()).toContain(`OtherA()`);
|
|
|
|
expect(output.toString()).not.toContain(`Directive({ selector: '[b]' })`);
|
|
|
|
expect(output.toString()).toContain(`OtherB()`);
|
|
|
|
expect(output.toString()).toContain(`Directive({ selector: '[c]' })`);
|
|
|
|
});
|
|
|
|
|
|
|
|
|
|
|
|
it('should delete the decorator (and its container if there are no other decorators left) that was matched in the analysis',
|
|
|
|
() => {
|
2018-10-04 07:19:11 -04:00
|
|
|
const {renderer, decorationAnalyses, sourceFile} = setup(PROGRAM_DECORATE_HELPER);
|
2018-09-24 15:50:25 -04:00
|
|
|
const output = new MagicString(PROGRAM_DECORATE_HELPER.contents);
|
2018-10-16 03:56:54 -04:00
|
|
|
const compiledClass =
|
|
|
|
decorationAnalyses.get(sourceFile) !.compiledClasses.find(c => c.name === 'C') !;
|
|
|
|
const decorator = compiledClass.decorators.find(d => d.name === 'Directive') !;
|
2018-09-24 15:50:25 -04:00
|
|
|
const decoratorsToRemove = new Map<ts.Node, ts.Node[]>();
|
|
|
|
decoratorsToRemove.set(decorator.node.parent !, [decorator.node]);
|
|
|
|
renderer.removeDecorators(output, decoratorsToRemove);
|
|
|
|
expect(output.toString()).toContain(`Directive({ selector: '[a]' }),`);
|
|
|
|
expect(output.toString()).toContain(`OtherA()`);
|
|
|
|
expect(output.toString()).toContain(`Directive({ selector: '[b]' })`);
|
|
|
|
expect(output.toString()).toContain(`OtherB()`);
|
|
|
|
expect(output.toString()).not.toContain(`Directive({ selector: '[c]' })`);
|
|
|
|
expect(output.toString()).not.toContain(`C = tslib_1.__decorate([`);
|
|
|
|
expect(output.toString()).toContain(`function C() {\n }\n return C;`);
|
|
|
|
});
|
|
|
|
});
|
2018-07-16 05:23:37 -04:00
|
|
|
});
|