2018-01-09 18:24:00 -05:00
|
|
|
"""Re-export of some bazel rules with repository-wide defaults."""
|
2018-08-07 19:15:45 -04:00
|
|
|
|
2018-09-11 21:11:32 -04:00
|
|
|
load("@build_bazel_rules_nodejs//:defs.bzl", _jasmine_node_test = "jasmine_node_test", _nodejs_binary = "nodejs_binary", _npm_package = "npm_package")
|
2018-05-11 12:43:06 -04:00
|
|
|
load("@build_bazel_rules_typescript//:defs.bzl", _ts_library = "ts_library", _ts_web_test_suite = "ts_web_test_suite")
|
2018-02-13 14:26:06 -05:00
|
|
|
load("//packages/bazel:index.bzl", _ng_module = "ng_module", _ng_package = "ng_package")
|
build(ivy): support alternate compilation modes to enable Ivy testing (#24056)
Bazel has a restriction that a single output (eg. a compiled version of
//packages/common) can only be produced by a single rule. This precludes
the Angular repo from having multiple rules that build the same code. And
the complexity of having a single rule produce multiple outputs (eg. an
ngc-compiled version of //packages/common and an Ivy-enabled version) is
too high.
Additionally, the Angular repo has lots of existing tests which could be
executed as-is under Ivy. Such testing is very valuable, and it would be
nice to share not only the code, but the dependency graph / build config
as well.
Thus, this change introduces a --define flag 'compile' with three potential
values. When --define=compile=X is set, the entire build system runs in a
particular mode - the behavior of all existing targets is controlled by
the flag. This allows us to reuse our entire build structure for testing
in a variety of different manners. The flag has three possible settings:
* legacy (the default): the traditional View Engine (ngc) build
* local: runs the prototype ngtsc compiler, which does not rely on global
analysis
* jit: runs ngtsc in a mode which executes tsickle, but excludes the
Angular related transforms, which approximates the behavior of plain
tsc. This allows the main packages such as common to be tested with
the JIT compiler.
Additionally, the ivy_ng_module() rule still exists and runs ngc in a mode
where Ivy-compiled output is produced from global analysis information, as
a stopgap while ngtsc is being developed.
PR Close #24056
2018-05-21 18:48:00 -04:00
|
|
|
load("//packages/bazel/src:ng_module.bzl", _internal_global_ng_module = "internal_global_ng_module")
|
2018-09-11 21:11:32 -04:00
|
|
|
load("//packages/bazel/src:ng_rollup_bundle.bzl", _ng_rollup_bundle = "ng_rollup_bundle")
|
2018-01-09 18:24:00 -05:00
|
|
|
|
2018-10-16 16:20:00 -04:00
|
|
|
_DEFAULT_TSCONFIG_BUILD = "//packages:tsconfig-build.json"
|
|
|
|
_DEFAULT_TSCONFIG_TEST = "//packages:tsconfig-test.json"
|
|
|
|
_DEFAULT_TS_TYPINGS = "@ngdeps//typescript:typescript__typings"
|
|
|
|
_INTERNAL_NG_MODULE_COMPILER = "//packages/bazel/src/ngc-wrapped"
|
|
|
|
_INTERNAL_NG_MODULE_XI18N = "//packages/bazel/src/ngc-wrapped:xi18n"
|
|
|
|
_INTERNAL_NG_PACKAGER_PACKAGER = "//packages/bazel/src/ng_package:packager"
|
2018-01-09 18:24:00 -05:00
|
|
|
|
2018-03-13 14:00:53 -04:00
|
|
|
# Packages which are versioned together on npm
|
|
|
|
ANGULAR_SCOPED_PACKAGES = ["@angular/%s" % p for p in [
|
2018-08-07 19:15:45 -04:00
|
|
|
# core should be the first package because it's the main package in the group
|
|
|
|
# this is significant for Angular CLI and "ng update" specifically, @angular/core
|
|
|
|
# is considered the identifier of the group by these tools.
|
|
|
|
"core",
|
|
|
|
"bazel",
|
|
|
|
"common",
|
|
|
|
"compiler",
|
|
|
|
"compiler-cli",
|
|
|
|
"animations",
|
|
|
|
"elements",
|
|
|
|
"platform-browser",
|
|
|
|
"platform-browser-dynamic",
|
|
|
|
"forms",
|
|
|
|
"http",
|
|
|
|
"platform-server",
|
|
|
|
"platform-webworker",
|
|
|
|
"platform-webworker-dynamic",
|
|
|
|
"upgrade",
|
|
|
|
"router",
|
|
|
|
"language-service",
|
|
|
|
"service-worker",
|
2018-03-13 14:00:53 -04:00
|
|
|
]]
|
|
|
|
|
|
|
|
PKG_GROUP_REPLACEMENTS = {
|
|
|
|
"\"NG_UPDATE_PACKAGE_GROUP\"": """[
|
|
|
|
%s
|
2018-08-07 19:15:45 -04:00
|
|
|
]""" % ",\n ".join(["\"%s\"" % s for s in ANGULAR_SCOPED_PACKAGES]),
|
2018-03-13 14:00:53 -04:00
|
|
|
}
|
|
|
|
|
2018-10-16 02:24:22 -04:00
|
|
|
def ts_library(tsconfig = None, testonly = False, deps = [], tags = [], **kwargs):
|
2018-10-04 16:14:14 -04:00
|
|
|
"""Default values for ts_library"""
|
|
|
|
deps = deps + ["@ngdeps//tslib"]
|
|
|
|
if testonly:
|
|
|
|
# Match the types[] in //packages:tsconfig-test.json
|
|
|
|
deps.append("@ngdeps//@types/jasmine")
|
|
|
|
deps.append("@ngdeps//@types/node")
|
2018-08-07 19:15:45 -04:00
|
|
|
if not tsconfig:
|
2018-08-14 19:18:26 -04:00
|
|
|
if testonly:
|
2018-10-16 16:20:00 -04:00
|
|
|
tsconfig = _DEFAULT_TSCONFIG_TEST
|
2018-08-14 19:18:26 -04:00
|
|
|
else:
|
2018-10-16 16:20:00 -04:00
|
|
|
tsconfig = _DEFAULT_TSCONFIG_BUILD
|
2018-10-16 02:24:22 -04:00
|
|
|
|
2018-10-04 16:14:14 -04:00
|
|
|
_ts_library(
|
|
|
|
tsconfig = tsconfig,
|
|
|
|
testonly = testonly,
|
|
|
|
deps = deps,
|
2018-10-16 16:20:00 -04:00
|
|
|
node_modules = _DEFAULT_TS_TYPINGS,
|
2018-10-16 02:24:22 -04:00
|
|
|
tags = ivy_tags(tags),
|
2018-10-04 16:14:14 -04:00
|
|
|
**kwargs
|
|
|
|
)
|
2018-01-09 18:24:00 -05:00
|
|
|
|
2018-10-16 02:24:22 -04:00
|
|
|
def ng_module(name, tsconfig = None, entry_point = None, testonly = False, deps = [], tags = [], **kwargs):
|
2018-10-04 16:14:14 -04:00
|
|
|
"""Default values for ng_module"""
|
|
|
|
deps = deps + ["@ngdeps//tslib"]
|
|
|
|
if testonly:
|
|
|
|
# Match the types[] in //packages:tsconfig-test.json
|
|
|
|
deps.append("@ngdeps//@types/jasmine")
|
|
|
|
deps.append("@ngdeps//@types/node")
|
2018-08-07 19:15:45 -04:00
|
|
|
if not tsconfig:
|
2018-08-14 19:18:26 -04:00
|
|
|
if testonly:
|
2018-10-16 16:20:00 -04:00
|
|
|
tsconfig = _DEFAULT_TSCONFIG_TEST
|
2018-08-14 19:18:26 -04:00
|
|
|
else:
|
2018-10-16 16:20:00 -04:00
|
|
|
tsconfig = _DEFAULT_TSCONFIG_BUILD
|
2018-08-07 19:15:45 -04:00
|
|
|
if not entry_point:
|
|
|
|
entry_point = "public_api.ts"
|
2018-10-04 16:14:14 -04:00
|
|
|
_ng_module(
|
|
|
|
name = name,
|
|
|
|
flat_module_out_file = name,
|
|
|
|
tsconfig = tsconfig,
|
|
|
|
entry_point = entry_point,
|
|
|
|
testonly = testonly,
|
|
|
|
deps = deps,
|
2018-10-16 16:20:00 -04:00
|
|
|
compiler = _INTERNAL_NG_MODULE_COMPILER,
|
|
|
|
ng_xi18n = _INTERNAL_NG_MODULE_XI18N,
|
|
|
|
node_modules = _DEFAULT_TS_TYPINGS,
|
2018-10-16 02:24:22 -04:00
|
|
|
tags = ivy_tags(tags),
|
2018-10-04 16:14:14 -04:00
|
|
|
**kwargs
|
|
|
|
)
|
2018-02-13 14:26:06 -05:00
|
|
|
|
build(ivy): support alternate compilation modes to enable Ivy testing (#24056)
Bazel has a restriction that a single output (eg. a compiled version of
//packages/common) can only be produced by a single rule. This precludes
the Angular repo from having multiple rules that build the same code. And
the complexity of having a single rule produce multiple outputs (eg. an
ngc-compiled version of //packages/common and an Ivy-enabled version) is
too high.
Additionally, the Angular repo has lots of existing tests which could be
executed as-is under Ivy. Such testing is very valuable, and it would be
nice to share not only the code, but the dependency graph / build config
as well.
Thus, this change introduces a --define flag 'compile' with three potential
values. When --define=compile=X is set, the entire build system runs in a
particular mode - the behavior of all existing targets is controlled by
the flag. This allows us to reuse our entire build structure for testing
in a variety of different manners. The flag has three possible settings:
* legacy (the default): the traditional View Engine (ngc) build
* local: runs the prototype ngtsc compiler, which does not rely on global
analysis
* jit: runs ngtsc in a mode which executes tsickle, but excludes the
Angular related transforms, which approximates the behavior of plain
tsc. This allows the main packages such as common to be tested with
the JIT compiler.
Additionally, the ivy_ng_module() rule still exists and runs ngc in a mode
where Ivy-compiled output is produced from global analysis information, as
a stopgap while ngtsc is being developed.
PR Close #24056
2018-05-21 18:48:00 -04:00
|
|
|
# ivy_ng_module behaves like ng_module, and under --define=compile=legacy it runs ngc with global
|
|
|
|
# analysis but produces Ivy outputs. Under other compile modes, it behaves as ng_module.
|
|
|
|
# TODO(alxhub): remove when ngtsc supports the same use cases.
|
2018-10-04 16:14:14 -04:00
|
|
|
def ivy_ng_module(name, tsconfig = None, entry_point = None, testonly = False, deps = [], **kwargs):
|
|
|
|
"""Default values for ivy_ng_module"""
|
|
|
|
deps = deps + ["@ngdeps//tslib"]
|
|
|
|
if testonly:
|
|
|
|
# Match the types[] in //packages:tsconfig-test.json
|
|
|
|
deps.append("@ngdeps//@types/jasmine")
|
|
|
|
deps.append("@ngdeps//@types/node")
|
2018-08-07 19:15:45 -04:00
|
|
|
if not tsconfig:
|
2018-08-14 19:18:26 -04:00
|
|
|
if testonly:
|
2018-10-16 16:20:00 -04:00
|
|
|
tsconfig = _DEFAULT_TSCONFIG_TEST
|
2018-08-14 19:18:26 -04:00
|
|
|
else:
|
2018-10-16 16:20:00 -04:00
|
|
|
tsconfig = _DEFAULT_TSCONFIG_BUILD
|
2018-08-07 19:15:45 -04:00
|
|
|
if not entry_point:
|
|
|
|
entry_point = "public_api.ts"
|
2018-10-04 16:14:14 -04:00
|
|
|
_internal_global_ng_module(
|
|
|
|
name = name,
|
|
|
|
flat_module_out_file = name,
|
|
|
|
tsconfig = tsconfig,
|
|
|
|
entry_point = entry_point,
|
|
|
|
testonly = testonly,
|
|
|
|
deps = deps,
|
2018-10-16 16:20:00 -04:00
|
|
|
compiler = _INTERNAL_NG_MODULE_COMPILER,
|
|
|
|
ng_xi18n = _INTERNAL_NG_MODULE_XI18N,
|
|
|
|
node_modules = _DEFAULT_TS_TYPINGS,
|
2018-10-04 16:14:14 -04:00
|
|
|
**kwargs
|
|
|
|
)
|
build(ivy): support alternate compilation modes to enable Ivy testing (#24056)
Bazel has a restriction that a single output (eg. a compiled version of
//packages/common) can only be produced by a single rule. This precludes
the Angular repo from having multiple rules that build the same code. And
the complexity of having a single rule produce multiple outputs (eg. an
ngc-compiled version of //packages/common and an Ivy-enabled version) is
too high.
Additionally, the Angular repo has lots of existing tests which could be
executed as-is under Ivy. Such testing is very valuable, and it would be
nice to share not only the code, but the dependency graph / build config
as well.
Thus, this change introduces a --define flag 'compile' with three potential
values. When --define=compile=X is set, the entire build system runs in a
particular mode - the behavior of all existing targets is controlled by
the flag. This allows us to reuse our entire build structure for testing
in a variety of different manners. The flag has three possible settings:
* legacy (the default): the traditional View Engine (ngc) build
* local: runs the prototype ngtsc compiler, which does not rely on global
analysis
* jit: runs ngtsc in a mode which executes tsickle, but excludes the
Angular related transforms, which approximates the behavior of plain
tsc. This allows the main packages such as common to be tested with
the JIT compiler.
Additionally, the ivy_ng_module() rule still exists and runs ngc in a mode
where Ivy-compiled output is produced from global analysis information, as
a stopgap while ngtsc is being developed.
PR Close #24056
2018-05-21 18:48:00 -04:00
|
|
|
|
2018-10-04 16:14:14 -04:00
|
|
|
def ng_package(name, readme_md = None, license_banner = None, deps = [], **kwargs):
|
|
|
|
"""Default values for ng_package"""
|
2018-08-07 19:15:45 -04:00
|
|
|
if not readme_md:
|
|
|
|
readme_md = "//packages:README.md"
|
|
|
|
if not license_banner:
|
|
|
|
license_banner = "//packages:license-banner.txt"
|
2018-10-04 16:14:14 -04:00
|
|
|
deps = deps + [
|
|
|
|
"@ngdeps//tslib",
|
|
|
|
]
|
2018-02-13 14:26:06 -05:00
|
|
|
|
2018-08-07 19:15:45 -04:00
|
|
|
_ng_package(
|
|
|
|
name = name,
|
2018-10-04 16:14:14 -04:00
|
|
|
deps = deps,
|
2018-08-07 19:15:45 -04:00
|
|
|
readme_md = readme_md,
|
|
|
|
license_banner = license_banner,
|
|
|
|
replacements = PKG_GROUP_REPLACEMENTS,
|
2018-10-16 16:20:00 -04:00
|
|
|
ng_packager = _INTERNAL_NG_PACKAGER_PACKAGER,
|
2018-08-07 19:15:45 -04:00
|
|
|
**kwargs
|
|
|
|
)
|
2018-03-13 14:00:53 -04:00
|
|
|
|
|
|
|
def npm_package(name, replacements = {}, **kwargs):
|
2018-10-04 16:14:14 -04:00
|
|
|
"""Default values for npm_package"""
|
2018-08-07 19:15:45 -04:00
|
|
|
_npm_package(
|
|
|
|
name = name,
|
|
|
|
replacements = dict(replacements, **PKG_GROUP_REPLACEMENTS),
|
|
|
|
**kwargs
|
|
|
|
)
|
2018-03-15 21:33:52 -04:00
|
|
|
|
2018-10-16 02:24:22 -04:00
|
|
|
def ts_web_test_suite(bootstrap = [], deps = [], tags = [], **kwargs):
|
2018-10-04 16:14:14 -04:00
|
|
|
"""Default values for ts_web_test_suite"""
|
2018-08-07 19:15:45 -04:00
|
|
|
if not bootstrap:
|
|
|
|
bootstrap = ["//:web_test_bootstrap_scripts"]
|
|
|
|
local_deps = [
|
2018-10-04 16:14:14 -04:00
|
|
|
"@ngdeps//node_modules/tslib:tslib.js",
|
2018-08-07 19:15:45 -04:00
|
|
|
"//tools/testing:browser",
|
|
|
|
] + deps
|
2018-03-15 21:33:52 -04:00
|
|
|
|
2018-08-07 19:15:45 -04:00
|
|
|
_ts_web_test_suite(
|
|
|
|
bootstrap = bootstrap,
|
|
|
|
deps = local_deps,
|
|
|
|
# Run unit tests on local Chromium by default.
|
|
|
|
# You can exclude tests based on tags, e.g. to skip Firefox testing,
|
|
|
|
# `bazel test --test_tag_filters=-browser:firefox-local [targets]`
|
|
|
|
browsers = [
|
|
|
|
"@io_bazel_rules_webtesting//browsers:chromium-local",
|
|
|
|
# Don't test on local Firefox by default, for faster builds.
|
|
|
|
# We think that bugs in Angular tend to be caught the same in any
|
|
|
|
# evergreen browser.
|
|
|
|
# "@io_bazel_rules_webtesting//browsers:firefox-local",
|
|
|
|
# TODO(alexeagle): add remote browsers on SauceLabs
|
|
|
|
],
|
2018-10-16 02:24:22 -04:00
|
|
|
tags = ivy_tags(tags),
|
2018-08-07 19:15:45 -04:00
|
|
|
**kwargs
|
|
|
|
)
|
2018-09-11 21:11:32 -04:00
|
|
|
|
2018-10-04 16:14:14 -04:00
|
|
|
def nodejs_binary(**kwargs):
|
|
|
|
"""Default values for nodejs_binary"""
|
|
|
|
_nodejs_binary(
|
|
|
|
# Pass-thru --define=compile=foo as an environment variable
|
|
|
|
configuration_env_vars = ["compile"],
|
|
|
|
**kwargs
|
|
|
|
)
|
2018-09-11 21:11:32 -04:00
|
|
|
|
2018-10-16 02:24:22 -04:00
|
|
|
def jasmine_node_test(deps = [], tags = [], **kwargs):
|
2018-10-04 16:14:14 -04:00
|
|
|
"""Default values for jasmine_node_test"""
|
|
|
|
deps = deps + [
|
|
|
|
# Very common dependencies for tests
|
|
|
|
"@ngdeps//chokidar",
|
|
|
|
"@ngdeps//domino",
|
|
|
|
"@ngdeps//jasmine",
|
|
|
|
"@ngdeps//jasmine-core",
|
|
|
|
"@ngdeps//mock-fs",
|
|
|
|
"@ngdeps//reflect-metadata",
|
|
|
|
"@ngdeps//tslib",
|
|
|
|
"@ngdeps//xhr2",
|
|
|
|
]
|
|
|
|
_jasmine_node_test(
|
|
|
|
deps = deps,
|
2018-10-16 02:24:22 -04:00
|
|
|
tags = ivy_tags(tags),
|
2018-10-04 16:14:14 -04:00
|
|
|
# Pass-thru --define=compile=foo as an environment variable
|
|
|
|
configuration_env_vars = ["compile"],
|
|
|
|
**kwargs
|
|
|
|
)
|
2018-09-11 21:11:32 -04:00
|
|
|
|
2018-10-04 16:14:14 -04:00
|
|
|
def ng_rollup_bundle(deps = [], **kwargs):
|
|
|
|
"""Default values for ng_rollup_bundle"""
|
|
|
|
deps = deps + [
|
|
|
|
"@ngdeps//tslib",
|
|
|
|
]
|
|
|
|
_ng_rollup_bundle(
|
|
|
|
deps = deps,
|
|
|
|
**kwargs
|
|
|
|
)
|
2018-10-16 02:24:22 -04:00
|
|
|
|
|
|
|
def ivy_tags(tags):
|
|
|
|
"""Sets inclusive ivy-jit and ivy-local tags"""
|
|
|
|
|
|
|
|
# Set the tags by default unless no-ivy-jit, no-ivy-local, fixme-ivy-jit, or fixme-ivy-local were specified.
|
|
|
|
# We should remove this and use only explicitly defined tags once https://github.com/bazelbuild/rules_nodejs/pull/388 is fixed.
|
|
|
|
if not tags:
|
|
|
|
tags = ["ivy-jit", "ivy-local"]
|
|
|
|
elif "no-ivy-jit" not in tags and "fixme-ivy-jit" not in tags:
|
|
|
|
tags = tags + ["ivy-jit"]
|
|
|
|
elif "no-ivy-local" not in tags and "fixme-ivy-local" not in tags:
|
|
|
|
tags = tags + ["ivy-local"]
|
|
|
|
return tags
|