2017-09-28 19:18:12 -04:00
|
|
|
/**
|
|
|
|
* @license
|
|
|
|
* Copyright Google Inc. All Rights Reserved.
|
|
|
|
*
|
|
|
|
* Use of this source code is governed by an MIT-style license that can be
|
|
|
|
* found in the LICENSE file at https://angular.io/license
|
|
|
|
*/
|
|
|
|
|
2018-04-12 11:04:11 -04:00
|
|
|
import {processNavigationUrls} from '../../config/src/generator';
|
2017-09-28 19:18:12 -04:00
|
|
|
import {CacheDatabase} from '../src/db-cache';
|
fix(service-worker): properly handle invalid hashes in all scenarios (#21288)
When the SW fetches URLs listed in a manifest with hashes, it checks
the content hash against the manifest to make sure it has the correct
version of the URL. In the event of a mismatch, the SW is supposed to
consider the manifest invalid, and avoid using it. There are 3 cases
to consider by which this can happen.
Case 1: during the initial SW installation, a manifest is activated
without waiting for every URL to be fully loaded. In the background,
every prefetch URL listed by the manifest is requested and cached.
One such prefetch request could fail the hash test, and cause the
manifest to be treated as invalid. In such a case, the SW should
enter a state of EXISTING_CLIENTS_ONLY, as the latest manifest is
invalid.
This case works today.
Case 2: during the initial SW installation, as in Case 1, a manifest
is activated without waiting for each URL to fully load. However,
it's possible that the application could request a URL with a bad
hash before background initialization tries to load that URL. This
happens if, for example, the application has a broken index.html.
In this case, the SW should enter a state of EXISTING_CLIENTS_ONLY,
and serve the request from the network instead.
What happens today is that the internal error escapes the SW and
is returned as a rejected Promise to respondWith(), causing a
browser-level error that the site cannot be loaded, breaking the
site.
This change allows the SW to detect the error and enter the correct
state, falling back on the network if needed.
Case 3: during checkForUpdate(), the SW will try to fully cache the
new update before making it the latest version. Failure here is
complicated - if the page fails to load due to transient network
conditions (timeouts, 500s, etc), then it makes sense to continue
serving the existing cached version, and attempt to activate the
update on the next cycle.
If the page fails due to non-transient conditions though (400 error,
hash mismatch, etc), then the SW should consider the updated
manifest invalid, and enter a state of EXISTING_CLIENTS_ONLY.
Currently, all errors are treated as transient.
This change causes the SW to treat all errors during updates as
non-transient, which can cause the SW to unnecessarily enter a
safe mode. A future change can allow the SW to remain in normal mode
if the error is provably transient.
PR Close #21288
2018-01-02 15:42:39 -05:00
|
|
|
import {Driver, DriverReadyState} from '../src/driver';
|
2017-09-28 19:18:12 -04:00
|
|
|
import {Manifest} from '../src/manifest';
|
|
|
|
import {sha1} from '../src/sha1';
|
|
|
|
import {MockRequest} from '../testing/fetch';
|
|
|
|
import {MockFileSystemBuilder, MockServerStateBuilder, tmpHashTableForFs} from '../testing/mock';
|
|
|
|
import {SwTestHarness, SwTestHarnessBuilder} from '../testing/scope';
|
|
|
|
|
|
|
|
import {async_beforeEach, async_fit, async_it} from './async';
|
|
|
|
|
|
|
|
const dist =
|
|
|
|
new MockFileSystemBuilder()
|
|
|
|
.addFile('/foo.txt', 'this is foo')
|
|
|
|
.addFile('/bar.txt', 'this is bar')
|
|
|
|
.addFile('/baz.txt', 'this is baz')
|
|
|
|
.addFile('/qux.txt', 'this is qux')
|
|
|
|
.addFile('/quux.txt', 'this is quux')
|
|
|
|
.addUnhashedFile('/unhashed/a.txt', 'this is unhashed', {'Cache-Control': 'max-age=10'})
|
|
|
|
.build();
|
|
|
|
|
|
|
|
const distUpdate =
|
|
|
|
new MockFileSystemBuilder()
|
|
|
|
.addFile('/foo.txt', 'this is foo v2')
|
|
|
|
.addFile('/bar.txt', 'this is bar')
|
|
|
|
.addFile('/baz.txt', 'this is baz v2')
|
|
|
|
.addFile('/qux.txt', 'this is qux v2')
|
|
|
|
.addFile('/quux.txt', 'this is quux v2')
|
|
|
|
.addUnhashedFile('/unhashed/a.txt', 'this is unhashed v2', {'Cache-Control': 'max-age=10'})
|
2018-04-12 11:04:11 -04:00
|
|
|
.addUnhashedFile('/ignored/file1', 'this is not handled by the SW')
|
|
|
|
.addUnhashedFile('/ignored/dir/file2', 'this is not handled by the SW either')
|
2017-09-28 19:18:12 -04:00
|
|
|
.build();
|
|
|
|
|
fix(service-worker): properly handle invalid hashes in all scenarios (#21288)
When the SW fetches URLs listed in a manifest with hashes, it checks
the content hash against the manifest to make sure it has the correct
version of the URL. In the event of a mismatch, the SW is supposed to
consider the manifest invalid, and avoid using it. There are 3 cases
to consider by which this can happen.
Case 1: during the initial SW installation, a manifest is activated
without waiting for every URL to be fully loaded. In the background,
every prefetch URL listed by the manifest is requested and cached.
One such prefetch request could fail the hash test, and cause the
manifest to be treated as invalid. In such a case, the SW should
enter a state of EXISTING_CLIENTS_ONLY, as the latest manifest is
invalid.
This case works today.
Case 2: during the initial SW installation, as in Case 1, a manifest
is activated without waiting for each URL to fully load. However,
it's possible that the application could request a URL with a bad
hash before background initialization tries to load that URL. This
happens if, for example, the application has a broken index.html.
In this case, the SW should enter a state of EXISTING_CLIENTS_ONLY,
and serve the request from the network instead.
What happens today is that the internal error escapes the SW and
is returned as a rejected Promise to respondWith(), causing a
browser-level error that the site cannot be loaded, breaking the
site.
This change allows the SW to detect the error and enter the correct
state, falling back on the network if needed.
Case 3: during checkForUpdate(), the SW will try to fully cache the
new update before making it the latest version. Failure here is
complicated - if the page fails to load due to transient network
conditions (timeouts, 500s, etc), then it makes sense to continue
serving the existing cached version, and attempt to activate the
update on the next cycle.
If the page fails due to non-transient conditions though (400 error,
hash mismatch, etc), then the SW should consider the updated
manifest invalid, and enter a state of EXISTING_CLIENTS_ONLY.
Currently, all errors are treated as transient.
This change causes the SW to treat all errors during updates as
non-transient, which can cause the SW to unnecessarily enter a
safe mode. A future change can allow the SW to remain in normal mode
if the error is provably transient.
PR Close #21288
2018-01-02 15:42:39 -05:00
|
|
|
const brokenFs = new MockFileSystemBuilder().addFile('/foo.txt', 'this is foo').build();
|
|
|
|
|
|
|
|
const brokenManifest: Manifest = {
|
|
|
|
configVersion: 1,
|
|
|
|
index: '/foo.txt',
|
|
|
|
assetGroups: [{
|
|
|
|
name: 'assets',
|
|
|
|
installMode: 'prefetch',
|
|
|
|
updateMode: 'prefetch',
|
|
|
|
urls: [
|
|
|
|
'/foo.txt',
|
|
|
|
],
|
|
|
|
patterns: [],
|
|
|
|
}],
|
|
|
|
dataGroups: [],
|
2018-04-12 11:04:11 -04:00
|
|
|
navigationUrls: processNavigationUrls(''),
|
fix(service-worker): properly handle invalid hashes in all scenarios (#21288)
When the SW fetches URLs listed in a manifest with hashes, it checks
the content hash against the manifest to make sure it has the correct
version of the URL. In the event of a mismatch, the SW is supposed to
consider the manifest invalid, and avoid using it. There are 3 cases
to consider by which this can happen.
Case 1: during the initial SW installation, a manifest is activated
without waiting for every URL to be fully loaded. In the background,
every prefetch URL listed by the manifest is requested and cached.
One such prefetch request could fail the hash test, and cause the
manifest to be treated as invalid. In such a case, the SW should
enter a state of EXISTING_CLIENTS_ONLY, as the latest manifest is
invalid.
This case works today.
Case 2: during the initial SW installation, as in Case 1, a manifest
is activated without waiting for each URL to fully load. However,
it's possible that the application could request a URL with a bad
hash before background initialization tries to load that URL. This
happens if, for example, the application has a broken index.html.
In this case, the SW should enter a state of EXISTING_CLIENTS_ONLY,
and serve the request from the network instead.
What happens today is that the internal error escapes the SW and
is returned as a rejected Promise to respondWith(), causing a
browser-level error that the site cannot be loaded, breaking the
site.
This change allows the SW to detect the error and enter the correct
state, falling back on the network if needed.
Case 3: during checkForUpdate(), the SW will try to fully cache the
new update before making it the latest version. Failure here is
complicated - if the page fails to load due to transient network
conditions (timeouts, 500s, etc), then it makes sense to continue
serving the existing cached version, and attempt to activate the
update on the next cycle.
If the page fails due to non-transient conditions though (400 error,
hash mismatch, etc), then the SW should consider the updated
manifest invalid, and enter a state of EXISTING_CLIENTS_ONLY.
Currently, all errors are treated as transient.
This change causes the SW to treat all errors during updates as
non-transient, which can cause the SW to unnecessarily enter a
safe mode. A future change can allow the SW to remain in normal mode
if the error is provably transient.
PR Close #21288
2018-01-02 15:42:39 -05:00
|
|
|
hashTable: tmpHashTableForFs(brokenFs, {'/foo.txt': true}),
|
|
|
|
};
|
|
|
|
|
2017-09-28 19:18:12 -04:00
|
|
|
const manifest: Manifest = {
|
|
|
|
configVersion: 1,
|
|
|
|
appData: {
|
|
|
|
version: 'original',
|
|
|
|
},
|
|
|
|
index: '/foo.txt',
|
|
|
|
assetGroups: [
|
|
|
|
{
|
|
|
|
name: 'assets',
|
|
|
|
installMode: 'prefetch',
|
|
|
|
updateMode: 'prefetch',
|
|
|
|
urls: [
|
|
|
|
'/foo.txt',
|
|
|
|
'/bar.txt',
|
2017-10-02 18:59:57 -04:00
|
|
|
'/redirected.txt',
|
2017-09-28 19:18:12 -04:00
|
|
|
],
|
|
|
|
patterns: [
|
|
|
|
'/unhashed/.*',
|
|
|
|
],
|
|
|
|
},
|
|
|
|
{
|
|
|
|
name: 'other',
|
|
|
|
installMode: 'lazy',
|
|
|
|
updateMode: 'lazy',
|
|
|
|
urls: [
|
|
|
|
'/baz.txt',
|
|
|
|
'/qux.txt',
|
|
|
|
],
|
|
|
|
patterns: [],
|
|
|
|
},
|
|
|
|
{
|
|
|
|
name: 'lazy_prefetch',
|
|
|
|
installMode: 'lazy',
|
|
|
|
updateMode: 'prefetch',
|
|
|
|
urls: ['/quux.txt'],
|
|
|
|
patterns: [],
|
|
|
|
}
|
|
|
|
],
|
2018-04-12 11:04:11 -04:00
|
|
|
navigationUrls: processNavigationUrls(''),
|
2017-09-28 19:18:12 -04:00
|
|
|
hashTable: tmpHashTableForFs(dist),
|
|
|
|
};
|
|
|
|
|
|
|
|
const manifestUpdate: Manifest = {
|
|
|
|
configVersion: 1,
|
|
|
|
appData: {
|
|
|
|
version: 'update',
|
|
|
|
},
|
|
|
|
index: '/foo.txt',
|
|
|
|
assetGroups: [
|
|
|
|
{
|
|
|
|
name: 'assets',
|
|
|
|
installMode: 'prefetch',
|
|
|
|
updateMode: 'prefetch',
|
|
|
|
urls: [
|
|
|
|
'/foo.txt',
|
|
|
|
'/bar.txt',
|
2017-10-02 18:59:57 -04:00
|
|
|
'/redirected.txt',
|
2017-09-28 19:18:12 -04:00
|
|
|
],
|
|
|
|
patterns: [
|
|
|
|
'/unhashed/.*',
|
|
|
|
],
|
|
|
|
},
|
|
|
|
{
|
|
|
|
name: 'other',
|
|
|
|
installMode: 'lazy',
|
|
|
|
updateMode: 'lazy',
|
|
|
|
urls: [
|
|
|
|
'/baz.txt',
|
|
|
|
'/qux.txt',
|
|
|
|
],
|
|
|
|
patterns: [],
|
|
|
|
},
|
|
|
|
{
|
|
|
|
name: 'lazy_prefetch',
|
|
|
|
installMode: 'lazy',
|
|
|
|
updateMode: 'prefetch',
|
|
|
|
urls: ['/quux.txt'],
|
|
|
|
patterns: [],
|
|
|
|
}
|
|
|
|
],
|
2018-04-12 11:04:11 -04:00
|
|
|
navigationUrls: processNavigationUrls(
|
|
|
|
'',
|
|
|
|
[
|
|
|
|
'/**/file1',
|
|
|
|
'/**/file2',
|
|
|
|
'!/ignored/file1',
|
|
|
|
'!/ignored/dir/**',
|
|
|
|
]),
|
2017-09-28 19:18:12 -04:00
|
|
|
hashTable: tmpHashTableForFs(distUpdate),
|
|
|
|
};
|
|
|
|
|
2017-10-02 18:59:57 -04:00
|
|
|
const server = new MockServerStateBuilder()
|
|
|
|
.withStaticFiles(dist)
|
|
|
|
.withManifest(manifest)
|
|
|
|
.withRedirect('/redirected.txt', '/redirect-target.txt', 'this was a redirect')
|
|
|
|
.withError('/error.txt')
|
|
|
|
.build();
|
2017-09-28 19:18:12 -04:00
|
|
|
|
|
|
|
const serverUpdate =
|
2017-10-02 18:59:57 -04:00
|
|
|
new MockServerStateBuilder()
|
|
|
|
.withStaticFiles(distUpdate)
|
|
|
|
.withManifest(manifestUpdate)
|
|
|
|
.withRedirect('/redirected.txt', '/redirect-target.txt', 'this was a redirect')
|
|
|
|
.build();
|
2017-09-28 19:18:12 -04:00
|
|
|
|
fix(service-worker): properly handle invalid hashes in all scenarios (#21288)
When the SW fetches URLs listed in a manifest with hashes, it checks
the content hash against the manifest to make sure it has the correct
version of the URL. In the event of a mismatch, the SW is supposed to
consider the manifest invalid, and avoid using it. There are 3 cases
to consider by which this can happen.
Case 1: during the initial SW installation, a manifest is activated
without waiting for every URL to be fully loaded. In the background,
every prefetch URL listed by the manifest is requested and cached.
One such prefetch request could fail the hash test, and cause the
manifest to be treated as invalid. In such a case, the SW should
enter a state of EXISTING_CLIENTS_ONLY, as the latest manifest is
invalid.
This case works today.
Case 2: during the initial SW installation, as in Case 1, a manifest
is activated without waiting for each URL to fully load. However,
it's possible that the application could request a URL with a bad
hash before background initialization tries to load that URL. This
happens if, for example, the application has a broken index.html.
In this case, the SW should enter a state of EXISTING_CLIENTS_ONLY,
and serve the request from the network instead.
What happens today is that the internal error escapes the SW and
is returned as a rejected Promise to respondWith(), causing a
browser-level error that the site cannot be loaded, breaking the
site.
This change allows the SW to detect the error and enter the correct
state, falling back on the network if needed.
Case 3: during checkForUpdate(), the SW will try to fully cache the
new update before making it the latest version. Failure here is
complicated - if the page fails to load due to transient network
conditions (timeouts, 500s, etc), then it makes sense to continue
serving the existing cached version, and attempt to activate the
update on the next cycle.
If the page fails due to non-transient conditions though (400 error,
hash mismatch, etc), then the SW should consider the updated
manifest invalid, and enter a state of EXISTING_CLIENTS_ONLY.
Currently, all errors are treated as transient.
This change causes the SW to treat all errors during updates as
non-transient, which can cause the SW to unnecessarily enter a
safe mode. A future change can allow the SW to remain in normal mode
if the error is provably transient.
PR Close #21288
2018-01-02 15:42:39 -05:00
|
|
|
const brokenServer =
|
|
|
|
new MockServerStateBuilder().withStaticFiles(brokenFs).withManifest(brokenManifest).build();
|
|
|
|
|
2017-09-28 19:18:12 -04:00
|
|
|
const server404 = new MockServerStateBuilder().withStaticFiles(dist).build();
|
|
|
|
|
|
|
|
const scope = new SwTestHarnessBuilder().withServerState(server).build();
|
|
|
|
|
|
|
|
const manifestHash = sha1(JSON.stringify(manifest));
|
|
|
|
const manifestUpdateHash = sha1(JSON.stringify(manifestUpdate));
|
|
|
|
|
2017-12-17 18:10:54 -05:00
|
|
|
(function() {
|
2017-09-28 19:18:12 -04:00
|
|
|
// Skip environments that don't support the minimum APIs needed to run the SW tests.
|
|
|
|
if (!SwTestHarness.envIsSupported()) {
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
describe('Driver', () => {
|
|
|
|
let scope: SwTestHarness;
|
|
|
|
let driver: Driver;
|
|
|
|
|
|
|
|
beforeEach(() => {
|
2018-03-19 18:29:00 -04:00
|
|
|
server.reset();
|
|
|
|
serverUpdate.reset();
|
|
|
|
server404.reset();
|
|
|
|
brokenServer.reset();
|
|
|
|
|
2017-09-28 19:18:12 -04:00
|
|
|
scope = new SwTestHarnessBuilder().withServerState(server).build();
|
|
|
|
driver = new Driver(scope, scope, new CacheDatabase(scope, scope));
|
|
|
|
});
|
|
|
|
|
|
|
|
async_it('initializes prefetched content correctly, after activation', async() => {
|
|
|
|
expect(await scope.startup(true)).toEqual(true);
|
|
|
|
await scope.resolveSelfMessages();
|
|
|
|
await driver.initialized;
|
2017-11-30 12:51:09 -05:00
|
|
|
server.assertSawRequestFor('ngsw.json');
|
2017-09-28 19:18:12 -04:00
|
|
|
server.assertSawRequestFor('/foo.txt');
|
|
|
|
server.assertSawRequestFor('/bar.txt');
|
2017-10-02 18:59:57 -04:00
|
|
|
server.assertSawRequestFor('/redirected.txt');
|
2017-09-28 19:18:12 -04:00
|
|
|
expect(await makeRequest(scope, '/foo.txt')).toEqual('this is foo');
|
|
|
|
expect(await makeRequest(scope, '/bar.txt')).toEqual('this is bar');
|
|
|
|
server.assertNoOtherRequests();
|
|
|
|
});
|
|
|
|
|
|
|
|
async_it('initializes prefetched content correctly, after a request kicks it off', async() => {
|
|
|
|
expect(await makeRequest(scope, '/foo.txt')).toEqual('this is foo');
|
|
|
|
await driver.initialized;
|
2017-11-30 12:51:09 -05:00
|
|
|
server.assertSawRequestFor('ngsw.json');
|
2017-09-28 19:18:12 -04:00
|
|
|
server.assertSawRequestFor('/foo.txt');
|
|
|
|
server.assertSawRequestFor('/bar.txt');
|
2017-10-02 18:59:57 -04:00
|
|
|
server.assertSawRequestFor('/redirected.txt');
|
2017-09-28 19:18:12 -04:00
|
|
|
expect(await makeRequest(scope, '/foo.txt')).toEqual('this is foo');
|
|
|
|
expect(await makeRequest(scope, '/bar.txt')).toEqual('this is bar');
|
|
|
|
server.assertNoOtherRequests();
|
|
|
|
});
|
|
|
|
|
2017-10-02 18:59:57 -04:00
|
|
|
async_it('handles non-relative URLs', async() => {
|
|
|
|
expect(await makeRequest(scope, '/foo.txt')).toEqual('this is foo');
|
|
|
|
await driver.initialized;
|
|
|
|
server.clearRequests();
|
|
|
|
expect(await makeRequest(scope, 'http://localhost/foo.txt')).toEqual('this is foo');
|
|
|
|
server.assertNoOtherRequests();
|
|
|
|
});
|
|
|
|
|
|
|
|
async_it('handles actual errors from the browser', async() => {
|
|
|
|
expect(await makeRequest(scope, '/foo.txt')).toEqual('this is foo');
|
|
|
|
await driver.initialized;
|
|
|
|
server.clearRequests();
|
|
|
|
|
|
|
|
const [resPromise, done] = scope.handleFetch(new MockRequest('/error.txt'), 'default');
|
|
|
|
await done;
|
|
|
|
const res = (await resPromise) !;
|
|
|
|
expect(res.status).toEqual(504);
|
|
|
|
expect(res.statusText).toEqual('Gateway Timeout');
|
|
|
|
});
|
|
|
|
|
|
|
|
async_it('handles redirected responses', async() => {
|
|
|
|
expect(await makeRequest(scope, '/foo.txt')).toEqual('this is foo');
|
|
|
|
await driver.initialized;
|
|
|
|
server.clearRequests();
|
|
|
|
expect(await makeRequest(scope, '/redirected.txt')).toEqual('this was a redirect');
|
|
|
|
server.assertNoOtherRequests();
|
|
|
|
});
|
|
|
|
|
2017-09-28 19:18:12 -04:00
|
|
|
async_it('caches lazy content on-request', async() => {
|
|
|
|
expect(await makeRequest(scope, '/foo.txt')).toEqual('this is foo');
|
|
|
|
await driver.initialized;
|
|
|
|
server.clearRequests();
|
|
|
|
expect(await makeRequest(scope, '/baz.txt')).toEqual('this is baz');
|
|
|
|
server.assertSawRequestFor('/baz.txt');
|
|
|
|
server.assertNoOtherRequests();
|
|
|
|
expect(await makeRequest(scope, '/baz.txt')).toEqual('this is baz');
|
|
|
|
server.assertNoOtherRequests();
|
|
|
|
expect(await makeRequest(scope, '/qux.txt')).toEqual('this is qux');
|
|
|
|
server.assertSawRequestFor('/qux.txt');
|
|
|
|
server.assertNoOtherRequests();
|
|
|
|
});
|
|
|
|
|
|
|
|
async_it('updates to new content when requested', async() => {
|
|
|
|
expect(await makeRequest(scope, '/foo.txt')).toEqual('this is foo');
|
|
|
|
await driver.initialized;
|
|
|
|
|
|
|
|
const client = scope.clients.getMock('default') !;
|
|
|
|
expect(client.messages).toEqual([]);
|
|
|
|
|
|
|
|
scope.updateServerState(serverUpdate);
|
|
|
|
expect(await driver.checkForUpdate()).toEqual(true);
|
2017-11-30 12:51:09 -05:00
|
|
|
serverUpdate.assertSawRequestFor('ngsw.json');
|
2017-09-28 19:18:12 -04:00
|
|
|
serverUpdate.assertSawRequestFor('/foo.txt');
|
2017-10-02 18:59:57 -04:00
|
|
|
serverUpdate.assertSawRequestFor('/redirected.txt');
|
2017-09-28 19:18:12 -04:00
|
|
|
serverUpdate.assertNoOtherRequests();
|
|
|
|
|
|
|
|
expect(client.messages).toEqual([{
|
|
|
|
type: 'UPDATE_AVAILABLE',
|
|
|
|
current: {hash: manifestHash, appData: {version: 'original'}},
|
|
|
|
available: {hash: manifestUpdateHash, appData: {version: 'update'}},
|
|
|
|
}]);
|
|
|
|
|
|
|
|
// Default client is still on the old version of the app.
|
|
|
|
expect(await makeRequest(scope, '/foo.txt')).toEqual('this is foo');
|
|
|
|
|
|
|
|
// Sending a new client id should result in the updated version being returned.
|
|
|
|
expect(await makeRequest(scope, '/foo.txt', 'new')).toEqual('this is foo v2');
|
|
|
|
|
|
|
|
// Of course, the old version should still work.
|
|
|
|
expect(await makeRequest(scope, '/foo.txt')).toEqual('this is foo');
|
|
|
|
|
|
|
|
expect(await makeRequest(scope, '/bar.txt')).toEqual('this is bar');
|
|
|
|
serverUpdate.assertNoOtherRequests();
|
|
|
|
});
|
|
|
|
|
|
|
|
async_it('updates a specific client to new content on request', async() => {
|
|
|
|
expect(await makeRequest(scope, '/foo.txt')).toEqual('this is foo');
|
|
|
|
await driver.initialized;
|
|
|
|
|
|
|
|
const client = scope.clients.getMock('default') !;
|
|
|
|
expect(client.messages).toEqual([]);
|
|
|
|
|
|
|
|
scope.updateServerState(serverUpdate);
|
|
|
|
expect(await driver.checkForUpdate()).toEqual(true);
|
|
|
|
serverUpdate.clearRequests();
|
|
|
|
await driver.updateClient(client as any as Client);
|
|
|
|
|
|
|
|
expect(client.messages).toEqual([
|
|
|
|
{
|
|
|
|
type: 'UPDATE_AVAILABLE',
|
|
|
|
current: {hash: manifestHash, appData: {version: 'original'}},
|
|
|
|
available: {hash: manifestUpdateHash, appData: {version: 'update'}},
|
|
|
|
},
|
|
|
|
{
|
|
|
|
type: 'UPDATE_ACTIVATED',
|
|
|
|
previous: {hash: manifestHash, appData: {version: 'original'}},
|
|
|
|
current: {hash: manifestUpdateHash, appData: {version: 'update'}},
|
|
|
|
}
|
|
|
|
]);
|
|
|
|
|
|
|
|
expect(await makeRequest(scope, '/foo.txt')).toEqual('this is foo v2');
|
|
|
|
});
|
|
|
|
|
|
|
|
async_it('checks for updates on restart', async() => {
|
|
|
|
expect(await makeRequest(scope, '/foo.txt')).toEqual('this is foo');
|
|
|
|
await driver.initialized;
|
|
|
|
|
|
|
|
scope = new SwTestHarnessBuilder()
|
|
|
|
.withCacheState(scope.caches.dehydrate())
|
|
|
|
.withServerState(serverUpdate)
|
|
|
|
.build();
|
|
|
|
driver = new Driver(scope, scope, new CacheDatabase(scope, scope));
|
|
|
|
expect(await makeRequest(scope, '/foo.txt')).toEqual('this is foo');
|
|
|
|
await driver.initialized;
|
|
|
|
serverUpdate.assertNoOtherRequests();
|
|
|
|
|
|
|
|
scope.advance(12000);
|
|
|
|
await driver.idle.empty;
|
2017-10-02 18:59:57 -04:00
|
|
|
|
2017-11-30 12:51:09 -05:00
|
|
|
serverUpdate.assertSawRequestFor('ngsw.json');
|
2017-09-28 19:18:12 -04:00
|
|
|
serverUpdate.assertSawRequestFor('/foo.txt');
|
2017-10-02 18:59:57 -04:00
|
|
|
serverUpdate.assertSawRequestFor('/redirected.txt');
|
2017-09-28 19:18:12 -04:00
|
|
|
serverUpdate.assertNoOtherRequests();
|
|
|
|
});
|
|
|
|
|
2017-12-14 16:10:06 -05:00
|
|
|
async_it('checks for updates on navigation', async() => {
|
|
|
|
expect(await makeRequest(scope, '/foo.txt')).toEqual('this is foo');
|
|
|
|
await driver.initialized;
|
|
|
|
server.clearRequests();
|
|
|
|
|
|
|
|
expect(await makeRequest(scope, '/foo.txt', 'default', {
|
|
|
|
mode: 'navigate',
|
|
|
|
})).toEqual('this is foo');
|
|
|
|
|
|
|
|
scope.advance(12000);
|
|
|
|
await driver.idle.empty;
|
|
|
|
|
|
|
|
server.assertSawRequestFor('ngsw.json');
|
|
|
|
});
|
|
|
|
|
|
|
|
async_it('does not make concurrent checks for updates on navigation', async() => {
|
|
|
|
expect(await makeRequest(scope, '/foo.txt')).toEqual('this is foo');
|
|
|
|
await driver.initialized;
|
|
|
|
server.clearRequests();
|
|
|
|
|
|
|
|
expect(await makeRequest(scope, '/foo.txt', 'default', {
|
|
|
|
mode: 'navigate',
|
|
|
|
})).toEqual('this is foo');
|
|
|
|
|
|
|
|
expect(await makeRequest(scope, '/foo.txt', 'default', {
|
|
|
|
mode: 'navigate',
|
|
|
|
})).toEqual('this is foo');
|
|
|
|
|
|
|
|
scope.advance(12000);
|
|
|
|
await driver.idle.empty;
|
|
|
|
|
|
|
|
server.assertSawRequestFor('ngsw.json');
|
|
|
|
server.assertNoOtherRequests();
|
|
|
|
});
|
|
|
|
|
2017-09-28 19:18:12 -04:00
|
|
|
async_it('preserves multiple client assignments across restarts', async() => {
|
|
|
|
expect(await makeRequest(scope, '/foo.txt')).toEqual('this is foo');
|
|
|
|
await driver.initialized;
|
|
|
|
|
|
|
|
scope.updateServerState(serverUpdate);
|
|
|
|
expect(await driver.checkForUpdate()).toEqual(true);
|
|
|
|
expect(await makeRequest(scope, '/foo.txt', 'new')).toEqual('this is foo v2');
|
|
|
|
serverUpdate.clearRequests();
|
|
|
|
|
|
|
|
scope = new SwTestHarnessBuilder()
|
|
|
|
.withCacheState(scope.caches.dehydrate())
|
2018-03-19 18:29:00 -04:00
|
|
|
.withServerState(serverUpdate)
|
2017-09-28 19:18:12 -04:00
|
|
|
.build();
|
|
|
|
driver = new Driver(scope, scope, new CacheDatabase(scope, scope));
|
|
|
|
|
|
|
|
expect(await makeRequest(scope, '/foo.txt')).toEqual('this is foo');
|
|
|
|
expect(await makeRequest(scope, '/foo.txt', 'new')).toEqual('this is foo v2');
|
|
|
|
serverUpdate.assertNoOtherRequests();
|
|
|
|
});
|
|
|
|
|
|
|
|
async_it('updates when refreshed', async() => {
|
|
|
|
expect(await makeRequest(scope, '/foo.txt')).toEqual('this is foo');
|
|
|
|
await driver.initialized;
|
|
|
|
|
|
|
|
const client = scope.clients.getMock('default') !;
|
|
|
|
|
|
|
|
scope.updateServerState(serverUpdate);
|
|
|
|
expect(await driver.checkForUpdate()).toEqual(true);
|
|
|
|
serverUpdate.clearRequests();
|
|
|
|
|
2018-04-12 11:04:11 -04:00
|
|
|
expect(await makeRequest(scope, '/file1', 'default', {
|
2017-09-28 19:18:12 -04:00
|
|
|
headers: {
|
|
|
|
'Accept': 'text/plain, text/html, text/css',
|
|
|
|
},
|
|
|
|
mode: 'navigate',
|
|
|
|
})).toEqual('this is foo v2');
|
|
|
|
|
|
|
|
expect(client.messages).toEqual([
|
|
|
|
{
|
|
|
|
type: 'UPDATE_AVAILABLE',
|
|
|
|
current: {hash: manifestHash, appData: {version: 'original'}},
|
|
|
|
available: {hash: manifestUpdateHash, appData: {version: 'update'}},
|
|
|
|
},
|
|
|
|
{
|
|
|
|
type: 'UPDATE_ACTIVATED',
|
|
|
|
previous: {hash: manifestHash, appData: {version: 'original'}},
|
|
|
|
current: {hash: manifestUpdateHash, appData: {version: 'update'}},
|
|
|
|
}
|
|
|
|
]);
|
|
|
|
serverUpdate.assertNoOtherRequests();
|
|
|
|
});
|
|
|
|
|
|
|
|
async_it('cleans up properly when manually requested', async() => {
|
|
|
|
expect(await makeRequest(scope, '/foo.txt')).toEqual('this is foo');
|
|
|
|
await driver.initialized;
|
|
|
|
|
|
|
|
scope.updateServerState(serverUpdate);
|
|
|
|
expect(await driver.checkForUpdate()).toEqual(true);
|
|
|
|
serverUpdate.clearRequests();
|
|
|
|
|
|
|
|
expect(await makeRequest(scope, '/foo.txt', 'new')).toEqual('this is foo v2');
|
|
|
|
|
|
|
|
// Delete the default client.
|
|
|
|
scope.clients.remove('default');
|
|
|
|
|
|
|
|
// After this, the old version should no longer be cached.
|
|
|
|
await driver.cleanupCaches();
|
|
|
|
expect(await makeRequest(scope, '/foo.txt')).toEqual('this is foo v2');
|
|
|
|
|
|
|
|
serverUpdate.assertNoOtherRequests();
|
|
|
|
});
|
|
|
|
|
|
|
|
async_it('cleans up properly on restart', async() => {
|
|
|
|
expect(await makeRequest(scope, '/foo.txt')).toEqual('this is foo');
|
|
|
|
await driver.initialized;
|
|
|
|
|
|
|
|
scope = new SwTestHarnessBuilder()
|
|
|
|
.withCacheState(scope.caches.dehydrate())
|
|
|
|
.withServerState(serverUpdate)
|
|
|
|
.build();
|
|
|
|
driver = new Driver(scope, scope, new CacheDatabase(scope, scope));
|
|
|
|
expect(await makeRequest(scope, '/foo.txt')).toEqual('this is foo');
|
|
|
|
await driver.initialized;
|
|
|
|
serverUpdate.assertNoOtherRequests();
|
|
|
|
|
2018-03-19 18:29:00 -04:00
|
|
|
let keys = await scope.caches.keys();
|
|
|
|
let hasOriginalCaches = keys.some(name => name.startsWith(`ngsw:${manifestHash}:`));
|
|
|
|
expect(hasOriginalCaches).toEqual(true);
|
|
|
|
|
2017-09-28 19:18:12 -04:00
|
|
|
scope.clients.remove('default');
|
|
|
|
|
|
|
|
scope.advance(12000);
|
|
|
|
await driver.idle.empty;
|
|
|
|
serverUpdate.clearRequests();
|
|
|
|
|
|
|
|
driver = new Driver(scope, scope, new CacheDatabase(scope, scope));
|
|
|
|
expect(await makeRequest(scope, '/foo.txt')).toEqual('this is foo v2');
|
|
|
|
|
2018-03-19 18:29:00 -04:00
|
|
|
keys = await scope.caches.keys();
|
|
|
|
hasOriginalCaches = keys.some(name => name.startsWith(`ngsw:${manifestHash}:`));
|
|
|
|
expect(hasOriginalCaches).toEqual(false);
|
2017-09-28 19:18:12 -04:00
|
|
|
});
|
|
|
|
|
|
|
|
async_it('shows notifications for push notifications', async() => {
|
|
|
|
expect(await makeRequest(scope, '/foo.txt')).toEqual('this is foo');
|
|
|
|
await driver.initialized;
|
|
|
|
await scope.handlePush({
|
|
|
|
notification: {
|
|
|
|
title: 'This is a test',
|
|
|
|
body: 'Test body',
|
|
|
|
}
|
|
|
|
});
|
|
|
|
expect(scope.notifications).toEqual([{
|
|
|
|
title: 'This is a test',
|
|
|
|
options: {body: 'Test body'},
|
|
|
|
}]);
|
|
|
|
expect(scope.clients.getMock('default') !.messages).toEqual([{
|
|
|
|
type: 'PUSH',
|
|
|
|
data: {
|
|
|
|
notification: {
|
|
|
|
title: 'This is a test',
|
|
|
|
body: 'Test body',
|
|
|
|
},
|
|
|
|
},
|
|
|
|
}]);
|
|
|
|
});
|
|
|
|
|
|
|
|
async_it('prefetches updates to lazy cache when set', async() => {
|
|
|
|
expect(await makeRequest(scope, '/foo.txt')).toEqual('this is foo');
|
|
|
|
await driver.initialized;
|
|
|
|
expect(await makeRequest(scope, '/quux.txt')).toEqual('this is quux');
|
|
|
|
|
|
|
|
scope.updateServerState(serverUpdate);
|
|
|
|
expect(await driver.checkForUpdate()).toEqual(true);
|
|
|
|
serverUpdate.assertSawRequestFor('/quux.txt');
|
|
|
|
serverUpdate.clearRequests();
|
2018-03-02 13:10:59 -05:00
|
|
|
await driver.updateClient(await scope.clients.get('default'));
|
2017-09-28 19:18:12 -04:00
|
|
|
expect(await makeRequest(scope, '/quux.txt')).toEqual('this is quux v2');
|
|
|
|
serverUpdate.assertNoOtherRequests();
|
|
|
|
});
|
|
|
|
|
|
|
|
async_it('unregisters when manifest 404s', async() => {
|
|
|
|
expect(await makeRequest(scope, '/foo.txt')).toEqual('this is foo');
|
|
|
|
await driver.initialized;
|
|
|
|
|
|
|
|
scope.updateServerState(server404);
|
|
|
|
expect(await driver.checkForUpdate()).toEqual(false);
|
|
|
|
expect(scope.unregistered).toEqual(true);
|
|
|
|
expect(await scope.caches.keys()).toEqual([]);
|
|
|
|
});
|
|
|
|
|
2018-03-19 18:40:32 -04:00
|
|
|
async_it('does not unregister or change state when offline (i.e. manifest 504s)', async() => {
|
|
|
|
expect(await makeRequest(scope, '/foo.txt')).toEqual('this is foo');
|
|
|
|
await driver.initialized;
|
|
|
|
server.online = false;
|
|
|
|
|
|
|
|
expect(await driver.checkForUpdate()).toEqual(false);
|
|
|
|
expect(driver.state).toEqual(DriverReadyState.NORMAL);
|
|
|
|
expect(scope.unregistered).toBeFalsy();
|
|
|
|
expect(await scope.caches.keys()).not.toEqual([]);
|
|
|
|
});
|
|
|
|
|
2017-09-28 19:18:12 -04:00
|
|
|
describe('unhashed requests', () => {
|
|
|
|
async_beforeEach(async() => {
|
|
|
|
expect(await makeRequest(scope, '/foo.txt')).toEqual('this is foo');
|
|
|
|
await driver.initialized;
|
|
|
|
server.clearRequests();
|
|
|
|
});
|
|
|
|
|
|
|
|
async_it('are cached appropriately', async() => {
|
|
|
|
expect(await makeRequest(scope, '/unhashed/a.txt')).toEqual('this is unhashed');
|
|
|
|
server.assertSawRequestFor('/unhashed/a.txt');
|
|
|
|
expect(await makeRequest(scope, '/unhashed/a.txt')).toEqual('this is unhashed');
|
|
|
|
server.assertNoOtherRequests();
|
|
|
|
});
|
|
|
|
|
2017-10-02 18:59:57 -04:00
|
|
|
async_it('avoid opaque responses', async() => {
|
|
|
|
expect(await makeRequest(scope, '/unhashed/a.txt', 'default', {
|
|
|
|
credentials: 'include'
|
|
|
|
})).toEqual('this is unhashed');
|
|
|
|
server.assertSawRequestFor('/unhashed/a.txt');
|
|
|
|
expect(await makeRequest(scope, '/unhashed/a.txt')).toEqual('this is unhashed');
|
|
|
|
server.assertNoOtherRequests();
|
|
|
|
});
|
|
|
|
|
2017-09-28 19:18:12 -04:00
|
|
|
async_it('expire according to Cache-Control headers', async() => {
|
|
|
|
expect(await makeRequest(scope, '/unhashed/a.txt')).toEqual('this is unhashed');
|
|
|
|
server.clearRequests();
|
|
|
|
|
|
|
|
// Update the resource on the server.
|
|
|
|
scope.updateServerState(serverUpdate);
|
|
|
|
|
|
|
|
// Move ahead by 15 seconds.
|
|
|
|
scope.advance(15000);
|
|
|
|
|
|
|
|
expect(await makeRequest(scope, '/unhashed/a.txt')).toEqual('this is unhashed');
|
|
|
|
serverUpdate.assertNoOtherRequests();
|
|
|
|
|
|
|
|
// Another 6 seconds.
|
|
|
|
scope.advance(6000);
|
|
|
|
await driver.idle.empty;
|
|
|
|
serverUpdate.assertSawRequestFor('/unhashed/a.txt');
|
|
|
|
|
|
|
|
// Now the new version of the resource should be served.
|
|
|
|
expect(await makeRequest(scope, '/unhashed/a.txt')).toEqual('this is unhashed v2');
|
|
|
|
server.assertNoOtherRequests();
|
|
|
|
});
|
|
|
|
|
|
|
|
async_it('survive serialization', async() => {
|
|
|
|
expect(await makeRequest(scope, '/unhashed/a.txt')).toEqual('this is unhashed');
|
|
|
|
server.clearRequests();
|
|
|
|
|
|
|
|
const state = scope.caches.dehydrate();
|
|
|
|
scope = new SwTestHarnessBuilder().withCacheState(state).withServerState(server).build();
|
|
|
|
driver = new Driver(scope, scope, new CacheDatabase(scope, scope));
|
|
|
|
expect(await makeRequest(scope, '/foo.txt')).toEqual('this is foo');
|
|
|
|
await driver.initialized;
|
|
|
|
server.assertNoRequestFor('/unhashed/a.txt');
|
|
|
|
server.clearRequests();
|
|
|
|
|
|
|
|
expect(await makeRequest(scope, '/unhashed/a.txt')).toEqual('this is unhashed');
|
|
|
|
server.assertNoOtherRequests();
|
|
|
|
|
|
|
|
// Advance the clock by 6 seconds, triggering the idle tasks. If an idle task
|
|
|
|
// was scheduled from the request above, it means that the metadata was not
|
|
|
|
// properly saved.
|
|
|
|
scope.advance(6000);
|
|
|
|
await driver.idle.empty;
|
|
|
|
server.assertNoRequestFor('/unhashed/a.txt');
|
|
|
|
});
|
|
|
|
|
|
|
|
async_it('get carried over during updates', async() => {
|
|
|
|
expect(await makeRequest(scope, '/unhashed/a.txt')).toEqual('this is unhashed');
|
|
|
|
server.clearRequests();
|
|
|
|
|
|
|
|
scope = new SwTestHarnessBuilder()
|
|
|
|
.withCacheState(scope.caches.dehydrate())
|
|
|
|
.withServerState(serverUpdate)
|
|
|
|
.build();
|
|
|
|
driver = new Driver(scope, scope, new CacheDatabase(scope, scope));
|
|
|
|
expect(await makeRequest(scope, '/foo.txt')).toEqual('this is foo');
|
|
|
|
await driver.initialized;
|
|
|
|
|
|
|
|
scope.advance(15000);
|
|
|
|
await driver.idle.empty;
|
|
|
|
serverUpdate.assertNoRequestFor('/unhashed/a.txt');
|
|
|
|
serverUpdate.clearRequests();
|
|
|
|
|
|
|
|
expect(await makeRequest(scope, '/unhashed/a.txt')).toEqual('this is unhashed');
|
|
|
|
serverUpdate.assertNoOtherRequests();
|
|
|
|
|
|
|
|
scope.advance(15000);
|
|
|
|
await driver.idle.empty;
|
|
|
|
serverUpdate.assertSawRequestFor('/unhashed/a.txt');
|
|
|
|
|
|
|
|
expect(await makeRequest(scope, '/unhashed/a.txt')).toEqual('this is unhashed v2');
|
|
|
|
serverUpdate.assertNoOtherRequests();
|
|
|
|
});
|
|
|
|
});
|
2018-03-19 18:29:00 -04:00
|
|
|
|
2017-09-28 19:18:12 -04:00
|
|
|
describe('routing', () => {
|
2018-04-12 11:04:11 -04:00
|
|
|
const navRequest = (url: string, init = {}) => makeRequest(scope, url, undefined, {
|
|
|
|
headers: {Accept: 'text/plain, text/html, text/css'},
|
|
|
|
mode: 'navigate', ...init,
|
|
|
|
});
|
|
|
|
|
2017-09-28 19:18:12 -04:00
|
|
|
async_beforeEach(async() => {
|
|
|
|
expect(await makeRequest(scope, '/foo.txt')).toEqual('this is foo');
|
|
|
|
await driver.initialized;
|
|
|
|
server.clearRequests();
|
|
|
|
});
|
|
|
|
|
|
|
|
async_it('redirects to index on a route-like request', async() => {
|
2018-04-12 11:04:11 -04:00
|
|
|
expect(await navRequest('/baz')).toEqual('this is foo');
|
2017-09-28 19:18:12 -04:00
|
|
|
server.assertNoOtherRequests();
|
|
|
|
});
|
|
|
|
|
|
|
|
async_it('redirects to index on a request to the origin URL request', async() => {
|
2018-04-12 11:04:11 -04:00
|
|
|
expect(await navRequest('http://localhost/')).toEqual('this is foo');
|
2017-09-28 19:18:12 -04:00
|
|
|
server.assertNoOtherRequests();
|
|
|
|
});
|
|
|
|
|
|
|
|
async_it('does not redirect to index on a non-navigation request', async() => {
|
2018-04-12 11:04:11 -04:00
|
|
|
expect(await navRequest('/baz', {mode: undefined})).toBeNull();
|
2017-09-28 19:18:12 -04:00
|
|
|
server.assertSawRequestFor('/baz');
|
|
|
|
});
|
|
|
|
|
2018-04-30 18:12:31 -04:00
|
|
|
async_it('does not redirect to index on a request that does not accept HTML', async() => {
|
2018-04-12 11:04:11 -04:00
|
|
|
expect(await navRequest('/baz', {headers: {}})).toBeNull();
|
|
|
|
server.assertSawRequestFor('/baz');
|
|
|
|
|
|
|
|
expect(await navRequest('/qux', {headers: {'Accept': 'text/plain'}})).toBeNull();
|
|
|
|
server.assertSawRequestFor('/qux');
|
|
|
|
});
|
|
|
|
|
2017-09-28 19:18:12 -04:00
|
|
|
async_it('does not redirect to index on a request with an extension', async() => {
|
2018-04-12 11:04:11 -04:00
|
|
|
expect(await navRequest('/baz.html')).toBeNull();
|
2017-09-28 19:18:12 -04:00
|
|
|
server.assertSawRequestFor('/baz.html');
|
2018-04-12 11:04:11 -04:00
|
|
|
|
|
|
|
// Only considers the last path segment when checking for a file extension.
|
|
|
|
expect(await navRequest('/baz.html/qux')).toBe('this is foo');
|
|
|
|
server.assertNoOtherRequests();
|
2017-09-28 19:18:12 -04:00
|
|
|
});
|
|
|
|
|
2018-04-12 11:04:11 -04:00
|
|
|
async_it('does not redirect to index if the URL contains `__`', async() => {
|
|
|
|
expect(await navRequest('/baz/x__x')).toBeNull();
|
|
|
|
server.assertSawRequestFor('/baz/x__x');
|
|
|
|
|
|
|
|
expect(await navRequest('/baz/x__x/qux')).toBeNull();
|
|
|
|
server.assertSawRequestFor('/baz/x__x/qux');
|
2018-04-12 16:34:43 -04:00
|
|
|
|
|
|
|
expect(await navRequest('/baz/__')).toBeNull();
|
|
|
|
server.assertSawRequestFor('/baz/__');
|
|
|
|
|
|
|
|
expect(await navRequest('/baz/__/qux')).toBeNull();
|
|
|
|
server.assertSawRequestFor('/baz/__/qux');
|
2018-04-12 11:04:11 -04:00
|
|
|
});
|
|
|
|
|
|
|
|
describe('(with custom `navigationUrls`)', () => {
|
|
|
|
async_beforeEach(async() => {
|
|
|
|
scope.updateServerState(serverUpdate);
|
|
|
|
await driver.checkForUpdate();
|
|
|
|
serverUpdate.clearRequests();
|
|
|
|
});
|
|
|
|
|
|
|
|
async_it('redirects to index on a request that matches any positive pattern', async() => {
|
|
|
|
expect(await navRequest('/foo/file0')).toBeNull();
|
|
|
|
serverUpdate.assertSawRequestFor('/foo/file0');
|
|
|
|
|
|
|
|
expect(await navRequest('/foo/file1')).toBe('this is foo v2');
|
|
|
|
serverUpdate.assertNoOtherRequests();
|
|
|
|
|
|
|
|
expect(await navRequest('/bar/file2')).toBe('this is foo v2');
|
|
|
|
serverUpdate.assertNoOtherRequests();
|
|
|
|
});
|
|
|
|
|
|
|
|
async_it(
|
|
|
|
'does not redirect to index on a request that matches any negative pattern',
|
|
|
|
async() => {
|
|
|
|
expect(await navRequest('/ignored/file1')).toBe('this is not handled by the SW');
|
|
|
|
serverUpdate.assertSawRequestFor('/ignored/file1');
|
|
|
|
|
|
|
|
expect(await navRequest('/ignored/dir/file2'))
|
|
|
|
.toBe('this is not handled by the SW either');
|
|
|
|
serverUpdate.assertSawRequestFor('/ignored/dir/file2');
|
|
|
|
|
|
|
|
expect(await navRequest('/ignored/directory/file2')).toBe('this is foo v2');
|
|
|
|
serverUpdate.assertNoOtherRequests();
|
|
|
|
});
|
|
|
|
|
|
|
|
async_it('strips URL query before checking `navigationUrls`', async() => {
|
|
|
|
expect(await navRequest('/foo/file1?query=/a/b')).toBe('this is foo v2');
|
|
|
|
serverUpdate.assertNoOtherRequests();
|
|
|
|
|
|
|
|
expect(await navRequest('/ignored/file1?query=/a/b'))
|
|
|
|
.toBe('this is not handled by the SW');
|
|
|
|
serverUpdate.assertSawRequestFor('/ignored/file1');
|
|
|
|
|
|
|
|
expect(await navRequest('/ignored/dir/file2?query=/a/b'))
|
|
|
|
.toBe('this is not handled by the SW either');
|
|
|
|
serverUpdate.assertSawRequestFor('/ignored/dir/file2');
|
|
|
|
});
|
|
|
|
|
|
|
|
async_it('strips registration scope before checking `navigationUrls`', async() => {
|
|
|
|
expect(await navRequest('http://localhost/ignored/file1'))
|
|
|
|
.toBe('this is not handled by the SW');
|
|
|
|
serverUpdate.assertSawRequestFor('/ignored/file1');
|
|
|
|
});
|
2017-09-28 19:18:12 -04:00
|
|
|
});
|
|
|
|
});
|
fix(service-worker): properly handle invalid hashes in all scenarios (#21288)
When the SW fetches URLs listed in a manifest with hashes, it checks
the content hash against the manifest to make sure it has the correct
version of the URL. In the event of a mismatch, the SW is supposed to
consider the manifest invalid, and avoid using it. There are 3 cases
to consider by which this can happen.
Case 1: during the initial SW installation, a manifest is activated
without waiting for every URL to be fully loaded. In the background,
every prefetch URL listed by the manifest is requested and cached.
One such prefetch request could fail the hash test, and cause the
manifest to be treated as invalid. In such a case, the SW should
enter a state of EXISTING_CLIENTS_ONLY, as the latest manifest is
invalid.
This case works today.
Case 2: during the initial SW installation, as in Case 1, a manifest
is activated without waiting for each URL to fully load. However,
it's possible that the application could request a URL with a bad
hash before background initialization tries to load that URL. This
happens if, for example, the application has a broken index.html.
In this case, the SW should enter a state of EXISTING_CLIENTS_ONLY,
and serve the request from the network instead.
What happens today is that the internal error escapes the SW and
is returned as a rejected Promise to respondWith(), causing a
browser-level error that the site cannot be loaded, breaking the
site.
This change allows the SW to detect the error and enter the correct
state, falling back on the network if needed.
Case 3: during checkForUpdate(), the SW will try to fully cache the
new update before making it the latest version. Failure here is
complicated - if the page fails to load due to transient network
conditions (timeouts, 500s, etc), then it makes sense to continue
serving the existing cached version, and attempt to activate the
update on the next cycle.
If the page fails due to non-transient conditions though (400 error,
hash mismatch, etc), then the SW should consider the updated
manifest invalid, and enter a state of EXISTING_CLIENTS_ONLY.
Currently, all errors are treated as transient.
This change causes the SW to treat all errors during updates as
non-transient, which can cause the SW to unnecessarily enter a
safe mode. A future change can allow the SW to remain in normal mode
if the error is provably transient.
PR Close #21288
2018-01-02 15:42:39 -05:00
|
|
|
|
|
|
|
describe('bugs', () => {
|
|
|
|
async_it('does not crash with bad index hash', async() => {
|
|
|
|
scope = new SwTestHarnessBuilder().withServerState(brokenServer).build();
|
|
|
|
(scope.registration as any).scope = 'http://site.com';
|
|
|
|
driver = new Driver(scope, scope, new CacheDatabase(scope, scope));
|
|
|
|
|
|
|
|
expect(await makeRequest(scope, '/foo.txt')).toEqual('this is foo');
|
|
|
|
});
|
|
|
|
|
|
|
|
async_it('enters degraded mode when update has a bad index', async() => {
|
|
|
|
expect(await makeRequest(scope, '/foo.txt')).toEqual('this is foo');
|
|
|
|
await driver.initialized;
|
|
|
|
server.clearRequests();
|
|
|
|
|
|
|
|
scope = new SwTestHarnessBuilder()
|
|
|
|
.withCacheState(scope.caches.dehydrate())
|
|
|
|
.withServerState(brokenServer)
|
|
|
|
.build();
|
|
|
|
driver = new Driver(scope, scope, new CacheDatabase(scope, scope));
|
|
|
|
await driver.checkForUpdate();
|
|
|
|
|
|
|
|
scope.advance(12000);
|
|
|
|
await driver.idle.empty;
|
|
|
|
|
|
|
|
expect(driver.state).toEqual(DriverReadyState.EXISTING_CLIENTS_ONLY);
|
|
|
|
});
|
2018-03-20 09:10:59 -04:00
|
|
|
|
|
|
|
async_it('ignores invalid `only-if-cached` requests ', async() => {
|
|
|
|
const requestFoo = (cache: RequestCache | 'only-if-cached', mode: RequestMode) =>
|
|
|
|
makeRequest(scope, '/foo.txt', undefined, {cache, mode});
|
|
|
|
|
|
|
|
expect(await requestFoo('default', 'no-cors')).toBe('this is foo');
|
|
|
|
expect(await requestFoo('only-if-cached', 'same-origin')).toBe('this is foo');
|
|
|
|
expect(await requestFoo('only-if-cached', 'no-cors')).toBeNull();
|
|
|
|
});
|
fix(service-worker): properly handle invalid hashes in all scenarios (#21288)
When the SW fetches URLs listed in a manifest with hashes, it checks
the content hash against the manifest to make sure it has the correct
version of the URL. In the event of a mismatch, the SW is supposed to
consider the manifest invalid, and avoid using it. There are 3 cases
to consider by which this can happen.
Case 1: during the initial SW installation, a manifest is activated
without waiting for every URL to be fully loaded. In the background,
every prefetch URL listed by the manifest is requested and cached.
One such prefetch request could fail the hash test, and cause the
manifest to be treated as invalid. In such a case, the SW should
enter a state of EXISTING_CLIENTS_ONLY, as the latest manifest is
invalid.
This case works today.
Case 2: during the initial SW installation, as in Case 1, a manifest
is activated without waiting for each URL to fully load. However,
it's possible that the application could request a URL with a bad
hash before background initialization tries to load that URL. This
happens if, for example, the application has a broken index.html.
In this case, the SW should enter a state of EXISTING_CLIENTS_ONLY,
and serve the request from the network instead.
What happens today is that the internal error escapes the SW and
is returned as a rejected Promise to respondWith(), causing a
browser-level error that the site cannot be loaded, breaking the
site.
This change allows the SW to detect the error and enter the correct
state, falling back on the network if needed.
Case 3: during checkForUpdate(), the SW will try to fully cache the
new update before making it the latest version. Failure here is
complicated - if the page fails to load due to transient network
conditions (timeouts, 500s, etc), then it makes sense to continue
serving the existing cached version, and attempt to activate the
update on the next cycle.
If the page fails due to non-transient conditions though (400 error,
hash mismatch, etc), then the SW should consider the updated
manifest invalid, and enter a state of EXISTING_CLIENTS_ONLY.
Currently, all errors are treated as transient.
This change causes the SW to treat all errors during updates as
non-transient, which can cause the SW to unnecessarily enter a
safe mode. A future change can allow the SW to remain in normal mode
if the error is provably transient.
PR Close #21288
2018-01-02 15:42:39 -05:00
|
|
|
});
|
2017-09-28 19:18:12 -04:00
|
|
|
});
|
2017-12-16 17:42:55 -05:00
|
|
|
})();
|
2017-09-28 19:18:12 -04:00
|
|
|
|
|
|
|
async function makeRequest(
|
2018-03-19 18:29:00 -04:00
|
|
|
scope: SwTestHarness, url: string, clientId = 'default', init?: Object): Promise<string|null> {
|
|
|
|
const [resPromise, done] = scope.handleFetch(new MockRequest(url, init), clientId);
|
2017-09-28 19:18:12 -04:00
|
|
|
await done;
|
|
|
|
const res = await resPromise;
|
|
|
|
if (res !== undefined && res.ok) {
|
|
|
|
return res.text();
|
|
|
|
}
|
|
|
|
return null;
|
2018-03-19 18:29:00 -04:00
|
|
|
}
|