2017-11-18 15:26:33 -05:00
{
2018-01-05 19:15:14 -05:00
"cli-hello-world" : {
"master" : {
"uncompressed" : {
2019-10-15 09:42:31 -04:00
"runtime-es2015" : 1485 ,
2020-10-23 07:45:51 -04:00
"main-es2015" : 141516 ,
2020-09-19 01:10:32 -04:00
"polyfills-es2015" : 36964
2018-01-05 19:15:14 -05:00
}
}
} ,
2019-01-28 10:04:38 -05:00
"cli-hello-world-ivy-minimal" : {
"master" : {
"uncompressed" : {
2019-10-16 08:37:18 -04:00
"runtime-es2015" : 1485 ,
fix(core): Access injected parent values using SelfSkip (#39464)
In ViewEngine, SelfSkip would navigate up the tree to get tokens from
the parent node, skipping the child. This restores that functionality in
Ivy. In ViewEngine, if a special token (e.g. ElementRef) was not found
in the NodeInjector tree, the ModuleInjector was also used to lookup
that token. While special tokens like ElementRef make sense only in a
context of a NodeInjector, we preserved ViewEngine logic for now to
avoid breaking changes.
We identified 4 scenarios related to @SkipSelf and special tokens where
ViewEngine behavior was incorrect and is likely due to bugs. In Ivy this
is implemented to provide a more intuitive API. The list of scenarios
can be found below.
1. When Injector is used in combination with @Host and @SkipSelf on the
first Component within a module and the injector is defined in the
module, ViewEngine will get the injector from the module. In Ivy, it
does not do this and throws instead.
2. When retrieving a @ViewContainerRef while @SkipSelf and @Host are
present, in ViewEngine, it throws an exception. In Ivy it returns the
host ViewContainerRef.
3. When retrieving a @ViewContainerRef on an embedded view and @SkipSelf
is present, in ViewEngine, the ref is null. In Ivy it returns the parent
ViewContainerRef.
4. When utilizing viewProviders and providers, a child component that is
nested within a parent component that has @SkipSelf on a viewProvider
value, if that provider is provided by the parent component's
viewProviders and providers, ViewEngine will return that parent's
viewProviders value, which violates how viewProviders' visibility should
work. In Ivy, it retrieves the value from providers, as it should.
These discrepancies all behave as they should in Ivy and are likely bugs
in ViewEngine.
PR Close #39464
2020-10-27 19:07:08 -04:00
"main-es2015" : 17597 ,
2020-10-29 14:14:33 -04:00
"polyfills-es2015" : 36709
2019-01-28 10:04:38 -05:00
}
}
} ,
2019-01-28 09:54:34 -05:00
"cli-hello-world-ivy-compat" : {
2018-12-21 13:00:16 -05:00
"master" : {
"uncompressed" : {
2019-10-15 10:56:47 -04:00
"runtime-es2015" : 1485 ,
2020-11-10 00:09:18 -05:00
"main-es2015" : 146680 ,
2020-09-19 01:10:32 -04:00
"polyfills-es2015" : 36964
2018-12-21 13:00:16 -05:00
}
}
} ,
2019-08-12 15:52:58 -04:00
"cli-hello-world-ivy-i18n" : {
"master" : {
"uncompressed" : {
2019-10-02 07:28:23 -04:00
"runtime-es2015" : 1485 ,
fix(core): Access injected parent values using SelfSkip (#39464)
In ViewEngine, SelfSkip would navigate up the tree to get tokens from
the parent node, skipping the child. This restores that functionality in
Ivy. In ViewEngine, if a special token (e.g. ElementRef) was not found
in the NodeInjector tree, the ModuleInjector was also used to lookup
that token. While special tokens like ElementRef make sense only in a
context of a NodeInjector, we preserved ViewEngine logic for now to
avoid breaking changes.
We identified 4 scenarios related to @SkipSelf and special tokens where
ViewEngine behavior was incorrect and is likely due to bugs. In Ivy this
is implemented to provide a more intuitive API. The list of scenarios
can be found below.
1. When Injector is used in combination with @Host and @SkipSelf on the
first Component within a module and the injector is defined in the
module, ViewEngine will get the injector from the module. In Ivy, it
does not do this and throws instead.
2. When retrieving a @ViewContainerRef while @SkipSelf and @Host are
present, in ViewEngine, it throws an exception. In Ivy it returns the
host ViewContainerRef.
3. When retrieving a @ViewContainerRef on an embedded view and @SkipSelf
is present, in ViewEngine, the ref is null. In Ivy it returns the parent
ViewContainerRef.
4. When utilizing viewProviders and providers, a child component that is
nested within a parent component that has @SkipSelf on a viewProvider
value, if that provider is provided by the parent component's
viewProviders and providers, ViewEngine will return that parent's
viewProviders value, which violates how viewProviders' visibility should
work. In Ivy, it retrieves the value from providers, as it should.
These discrepancies all behave as they should in Ivy and are likely bugs
in ViewEngine.
PR Close #39464
2020-10-27 19:07:08 -04:00
"main-es2015" : 136703 ,
2020-09-19 01:10:32 -04:00
"polyfills-es2015" : 37641
2019-08-12 15:52:58 -04:00
}
}
} ,
2019-10-02 08:09:42 -04:00
"cli-hello-world-lazy" : {
"master" : {
"uncompressed" : {
2020-10-29 14:14:33 -04:00
"runtime-es2015" : 2285 ,
2020-11-16 14:04:00 -05:00
"main-es2015" : 241879 ,
2020-10-29 14:14:33 -04:00
"polyfills-es2015" : 36709 ,
"5-es2015" : 745
2019-10-02 08:09:42 -04:00
}
}
} ,
2019-10-15 10:15:19 -04:00
"cli-hello-world-lazy-rollup" : {
"master" : {
"uncompressed" : {
2020-10-23 07:45:51 -04:00
"runtime-es2015" : 2289 ,
"main-es2015" : 218507 ,
"polyfills-es2015" : 36723 ,
"5-es2015" : 781
2019-10-15 10:15:19 -04:00
}
}
} ,
2018-01-05 19:15:14 -05:00
"hello_world__closure" : {
"master" : {
"uncompressed" : {
2018-04-04 13:56:02 -04:00
"bundle" : "TODO(i): temporarily increase the payload size limit from 105779 - this is due to a closure issue related to ESM reexports that still needs to be investigated" ,
2019-08-15 09:14:25 -04:00
"bundle" : "TODO(i): we should define ngDevMode to false in Closure, but --define only works in the global scope." ,
2020-05-12 08:22:36 -04:00
"bundle" : "TODO(i): (FW-2164) TS 3.9 new class shape seems to have broken Closure in big ways. The size went from 169991 to 252338" ,
2020-06-09 11:40:00 -04:00
"bundle" : "TODO(i): after removal of tsickle from ngc-wrapped / ng_package, we had to switch to SIMPLE optimizations which increased the size from 252338 to 1198917, see PR#37221 and PR#37317 for more info" ,
2020-08-11 13:34:59 -04:00
"bundle" : 1214857
2018-01-05 19:15:14 -05:00
}
}
}
2020-10-23 07:45:51 -04:00
}
