honeymoose/angular-cn
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
angular-cn/packages/language-service/ivy/test/legacy/BUILD.bazel

36 lines
1.0 KiB
Python
Raw Normal View History

test(language-service): add new mock host for testing ivy (#36879) This commit adds a new mock host for testing the ivy language service. Unlike the existing mock_host which mocks the LanguageServiceHost, the Ivy mock host mocks just the filesystem interface, aka ts.ServerHost. This is because Ivy language service requires an actual Project to perform operations like adding synthetic typecheck files to the project, and by extension, to the ts.Program. These requirements make the existing mock host unsuitable to be reused. This new testing structure also improves test performance, because the old mock host copies (it actually creates symlinks, but still that's relatively expensive due to the sheer number of files involved) all @angular/* packages along with the typescript package to a temporary node_modules directory. This is done every time setup() is called. Instead, this new mock host just loads them from a pre-determined path in Bazel runfiles. PR Close #36879
2020-04-30 15:48:20 -07:00
load("//tools:defaults.bzl", "jasmine_node_test", "ts_library")
ts_library(
test(language-service): move existing tests to legacy directory (#39594) In preparation for in-memory testing infrastructure, the existing Ivy language service tests are moved to a `legacy` directory. These existing tests rely on a single integration project in `test/project/app`, which presents a number of challenges: * adding extra fields/properties to the integration project for one test can cause others to fail/flake. * it's especially difficult to test any cases that require introducing intentional errors, as those tend to break other tests. * tests load files from disk, which is slower. * tests rely on the real built versions of @angular/core and @angular/common, which makes them both slow to build and require rebuilds on every compiler change. * tests share a single tsconfig.json, making it extremely difficult to test how the language service handles different configuration scenarios (e.g. different type-checking flags). PR Close #39594
2020-11-04 12:28:37 -08:00
name = "legacy_lib",
test(language-service): add new mock host for testing ivy (#36879) This commit adds a new mock host for testing the ivy language service. Unlike the existing mock_host which mocks the LanguageServiceHost, the Ivy mock host mocks just the filesystem interface, aka ts.ServerHost. This is because Ivy language service requires an actual Project to perform operations like adding synthetic typecheck files to the project, and by extension, to the ts.Program. These requirements make the existing mock host unsuitable to be reused. This new testing structure also improves test performance, because the old mock host copies (it actually creates symlinks, but still that's relatively expensive due to the sheer number of files involved) all @angular/* packages along with the typescript package to a temporary node_modules directory. This is done every time setup() is called. Instead, this new mock host just loads them from a pre-determined path in Bazel runfiles. PR Close #36879
2020-04-30 15:48:20 -07:00
testonly = True,
srcs = glob(["*.ts"]),
deps = [
feat(language-service): introduce hybrid visitor to locate AST node (#38540) This commit introduces two visitors, one for Template AST and the other for Expression AST to allow us to easily find the node that most closely corresponds to a given cursor position. This is crucial because many language service APIs take in a `position` parameter, and the information returned depends on how well we can find a good candidate node. In View Engine implementation of language service, the search for the node and the processing of information to return the result are strongly coupled. This makes the code hard to understand and hard to debug because the stack trace is often littered with layers of visitor calls. With this new feature, we could test the "searching" part separately and colocate all the logic (aka hacks) that's required to retrieve an accurate span for a given node. Right now, only the most "narrow" node is returned by the main exported function `findNodeAtPosition`. If needed, we could expose the entire AST path, or expose other methods to provide more context for a node. Note that due to limitations in the template AST interface, there are a few known cases where microsyntax spans are not recorded properly. This will be dealt with in a follow-up PR. PR Close #38540
2020-08-12 16:13:02 -07:00
"//packages/compiler",
feat(language-service): Add diagnostics to suggest turning on strict mode (#40423) This PR adds a way for the language server to retrieve compiler options diagnostics via `languageService.getCompilerOptionsDiagnostics()`. This will be used by the language server to show a prompt in the editor if users don't have `strict` or `fullTemplateTypeCheck` turned on. Ref https://github.com/angular/vscode-ng-language-service/issues/1053 PR Close #40423
2021-01-13 14:52:29 -08:00
"//packages/compiler-cli/src/ngtsc/core:api",
"//packages/compiler-cli/src/ngtsc/diagnostics",
feat(language-service): [ivy] Parse Angular compiler options (#36922) Parse Angular compiler options in Angular language service. In View Engine, only TypeScript compiler options are read, Angular compiler options are not. With Ivy, there could be different modes of compilation, most notably how strict the templates should be checked. This commit makes the behavior of language service consistent with the Ivy compiler. PR Close #36922
2020-04-29 15:52:17 -07:00
"//packages/language-service/ivy",
test(language-service): add new mock host for testing ivy (#36879) This commit adds a new mock host for testing the ivy language service. Unlike the existing mock_host which mocks the LanguageServiceHost, the Ivy mock host mocks just the filesystem interface, aka ts.ServerHost. This is because Ivy language service requires an actual Project to perform operations like adding synthetic typecheck files to the project, and by extension, to the ts.Program. These requirements make the existing mock host unsuitable to be reused. This new testing structure also improves test performance, because the old mock host copies (it actually creates symlinks, but still that's relatively expensive due to the sheer number of files involved) all @angular/* packages along with the typescript package to a temporary node_modules directory. This is done every time setup() is called. Instead, this new mock host just loads them from a pre-determined path in Bazel runfiles. PR Close #36879
2020-04-30 15:48:20 -07:00
"@npm//typescript",
],
)
jasmine_node_test(
test(language-service): move existing tests to legacy directory (#39594) In preparation for in-memory testing infrastructure, the existing Ivy language service tests are moved to a `legacy` directory. These existing tests rely on a single integration project in `test/project/app`, which presents a number of challenges: * adding extra fields/properties to the integration project for one test can cause others to fail/flake. * it's especially difficult to test any cases that require introducing intentional errors, as those tend to break other tests. * tests load files from disk, which is slower. * tests rely on the real built versions of @angular/core and @angular/common, which makes them both slow to build and require rebuilds on every compiler change. * tests share a single tsconfig.json, making it extremely difficult to test how the language service handles different configuration scenarios (e.g. different type-checking flags). PR Close #39594
2020-11-04 12:28:37 -08:00
name = "legacy",
test(language-service): add new mock host for testing ivy (#36879) This commit adds a new mock host for testing the ivy language service. Unlike the existing mock_host which mocks the LanguageServiceHost, the Ivy mock host mocks just the filesystem interface, aka ts.ServerHost. This is because Ivy language service requires an actual Project to perform operations like adding synthetic typecheck files to the project, and by extension, to the ts.Program. These requirements make the existing mock host unsuitable to be reused. This new testing structure also improves test performance, because the old mock host copies (it actually creates symlinks, but still that's relatively expensive due to the sheer number of files involved) all @angular/* packages along with the typescript package to a temporary node_modules directory. This is done every time setup() is called. Instead, this new mock host just loads them from a pre-determined path in Bazel runfiles. PR Close #36879
2020-04-30 15:48:20 -07:00
data = [
# Note that we used to depend on the npm_package of common, core, and
# forms, but this is no longer the case. We did it for View Engine
# because we wanted to load the flat dts, which is only available in the
# npm_package. Ivy does not currently produce flat dts, so we might
# as well just depend on the outputs of ng_module.
"//packages/common",
"//packages/core",
"//packages/forms",
"//packages/language-service/test:project",
],
feat(language-service): [ivy] wrap ngtsc to handle typecheck files (#36930) This commit adds a Compiler interface that wraps the actual ngtsc compiler. The language-service specific compiler manages multiple typecheck files using the Project interface, creating and adding ScriptInfos as necessary. This commit also adds `overrideInlineTemplate()` method to the mock service so that we could test the Compiler diagnostics feature. PR Close #36930
2020-04-30 15:48:20 -07:00
tags = [
"ivy-only",
],
test(language-service): add new mock host for testing ivy (#36879) This commit adds a new mock host for testing the ivy language service. Unlike the existing mock_host which mocks the LanguageServiceHost, the Ivy mock host mocks just the filesystem interface, aka ts.ServerHost. This is because Ivy language service requires an actual Project to perform operations like adding synthetic typecheck files to the project, and by extension, to the ts.Program. These requirements make the existing mock host unsuitable to be reused. This new testing structure also improves test performance, because the old mock host copies (it actually creates symlinks, but still that's relatively expensive due to the sheer number of files involved) all @angular/* packages along with the typescript package to a temporary node_modules directory. This is done every time setup() is called. Instead, this new mock host just loads them from a pre-determined path in Bazel runfiles. PR Close #36879
2020-04-30 15:48:20 -07:00
deps = [
test(language-service): move existing tests to legacy directory (#39594) In preparation for in-memory testing infrastructure, the existing Ivy language service tests are moved to a `legacy` directory. These existing tests rely on a single integration project in `test/project/app`, which presents a number of challenges: * adding extra fields/properties to the integration project for one test can cause others to fail/flake. * it's especially difficult to test any cases that require introducing intentional errors, as those tend to break other tests. * tests load files from disk, which is slower. * tests rely on the real built versions of @angular/core and @angular/common, which makes them both slow to build and require rebuilds on every compiler change. * tests share a single tsconfig.json, making it extremely difficult to test how the language service handles different configuration scenarios (e.g. different type-checking flags). PR Close #39594
2020-11-04 12:28:37 -08:00
":legacy_lib",
test(language-service): add new mock host for testing ivy (#36879) This commit adds a new mock host for testing the ivy language service. Unlike the existing mock_host which mocks the LanguageServiceHost, the Ivy mock host mocks just the filesystem interface, aka ts.ServerHost. This is because Ivy language service requires an actual Project to perform operations like adding synthetic typecheck files to the project, and by extension, to the ts.Program. These requirements make the existing mock host unsuitable to be reused. This new testing structure also improves test performance, because the old mock host copies (it actually creates symlinks, but still that's relatively expensive due to the sheer number of files involved) all @angular/* packages along with the typescript package to a temporary node_modules directory. This is done every time setup() is called. Instead, this new mock host just loads them from a pre-determined path in Bazel runfiles. PR Close #36879
2020-04-30 15:48:20 -07:00
],
)
Reference in New Issue Copy Permalink