build: turn on tsc's stripInternal when producint public d.ts file

I also made some changes to fix imports and remove some stuff that caused
breakage once stripInternals was turned on.

modules/@angular/common/src/directives.ts

@@ -10,5 +10,4 @@ export {NgTemplateOutlet} from './directives/ng_template_outlet';
 export {NgStyle} from './directives/ng_style';
 export {NgSwitch, NgSwitchWhen, NgSwitchDefault} from './directives/ng_switch';
 export {NgPlural, NgPluralCase, NgLocalization} from './directives/ng_plural';
-export * from './directives/observable_list_diff';
 export {CORE_DIRECTIVES} from './directives/core_directives';

modules/@angular/common/src/directives/observable_list_diff.ts

@@ -1,11 +0,0 @@
-// TS does not have Observables
-
-// I need to be here to make TypeScript think this is a module.
-import {} from '../../src/facade/lang';
-
-/**
- * This module exists in Dart, but not in Typescript. This exported symbol
- * is only here to help Typescript think this is a module.
- * @internal
- */
-export var workaround_empty_observable_list_diff: any;

modules/@angular/common/src/location/location.ts

@@ -1,5 +1,5 @@
-import {Injectable, Inject} from '@angular/core';
+import {Injectable, EventEmitter} from '@angular/core';
-import {EventEmitter, ObservableWrapper} from '../../src/facade/async';
+import {ObservableWrapper} from '../../src/facade/async';
 
 import {LocationStrategy} from './location_strategy';
 

modules/@angular/common/tsconfig-es2015.json

@@ -5,6 +5,7 @@
   "compilerOptions": {
     "baseUrl": ".",
     "declaration": true,
+    "stripInternal": true,
     "emitDecoratorMetadata": true,
     "experimentalDecorators": true,
     "module": "es2015",

modules/@angular/common/tsconfig-es5.json

@@ -5,6 +5,7 @@
   "compilerOptions": {
     "baseUrl": ".",
     "declaration": true,
+    "stripInternal": true,
     "emitDecoratorMetadata": true,
     "experimentalDecorators": true,
     "module": "commonjs",

modules/@angular/compiler/test/metadata_resolver_spec.ts

@@ -14,7 +14,7 @@ import {
 
 import {IS_DART, stringify} from '../src/facade/lang';
 import {CompileMetadataResolver} from '../src/metadata_resolver';
-import {LifecycleHooks, LIFECYCLE_HOOKS_VALUES} from '@angular/core/src/metadata/lifecycle_hooks';
+import {LIFECYCLE_HOOKS_VALUES} from '@angular/core/src/metadata/lifecycle_hooks';
 import {
   Component,
   Directive,

modules/@angular/compiler/tsconfig-es2015.json

@@ -5,6 +5,7 @@
   "compilerOptions": {
     "baseUrl": ".",
     "declaration": true,
+    "stripInternal": true,
     "emitDecoratorMetadata": true,
     "experimentalDecorators": true,
     "module": "es2015",

modules/@angular/compiler/tsconfig-es5.json

@@ -5,6 +5,7 @@
   "compilerOptions": {
     "baseUrl": ".",
     "declaration": true,
+    "stripInternal": true,
     "emitDecoratorMetadata": true,
     "experimentalDecorators": true,
     "module": "commonjs",

modules/@angular/core/src/metadata/lifecycle_hooks.ts

@@ -11,9 +11,6 @@ export enum LifecycleHooks {
   AfterViewChecked
 }
 
-/**
- * @internal
- */
 export var LIFECYCLE_HOOKS_VALUES = [
   LifecycleHooks.OnInit,
   LifecycleHooks.OnDestroy,

modules/@angular/core/tsconfig-es2015.json

@@ -5,6 +5,7 @@
   "compilerOptions": {
     "baseUrl": ".",
     "declaration": true,
+    "stripInternal": true,
     "emitDecoratorMetadata": true,
     "experimentalDecorators": true,
     "module": "es2015",

modules/@angular/core/tsconfig-es5.json

@@ -5,6 +5,7 @@
   "compilerOptions": {
     "baseUrl": ".",
     "declaration": true,
+    "stripInternal": true,
     "emitDecoratorMetadata": true,
     "experimentalDecorators": true,
     "module": "commonjs",

modules/@angular/facade/src/async.ts

@@ -98,8 +98,11 @@ export class ObservableWrapper {
  * Once a reference implementation of the spec is available, switch to it.
  */
 export class EventEmitter<T> extends Subject<T> {
-  /** @internal */
+  // TODO: mark this as internal once all the facades are gone
-  _isAsync: boolean;
+  // we can't mark it as internal now because EventEmitter exported via @angular/core would not
+  // contain this property making it incompatible with all the code that uses EventEmitter via
+  // facades, which are local to the code and do not have this property stripped.
+  __isAsync: boolean;
 
   /**
    * Creates an instance of [EventEmitter], which depending on [isAsync],
@@ -107,7 +110,7 @@ export class EventEmitter<T> extends Subject<T> {
    */
   constructor(isAsync: boolean = true) {
     super();
-    this._isAsync = isAsync;
+    this.__isAsync = isAsync;
   }
 
   emit(value: T) { super.next(value); }
@@ -123,30 +126,30 @@ export class EventEmitter<T> extends Subject<T> {
     let completeFn = () => null;
 
     if (generatorOrNext && typeof generatorOrNext === 'object') {
-      schedulerFn = this._isAsync ? (value) => { setTimeout(() => generatorOrNext.next(value)); } :
+      schedulerFn = this.__isAsync ? (value) => { setTimeout(() => generatorOrNext.next(value)); } :
                                     (value) => { generatorOrNext.next(value); };
 
       if (generatorOrNext.error) {
-        errorFn = this._isAsync ? (err) => { setTimeout(() => generatorOrNext.error(err)); } :
+        errorFn = this.__isAsync ? (err) => { setTimeout(() => generatorOrNext.error(err)); } :
                                   (err) => { generatorOrNext.error(err); };
       }
 
       if (generatorOrNext.complete) {
-        completeFn = this._isAsync ? () => { setTimeout(() => generatorOrNext.complete()); } :
+        completeFn = this.__isAsync ? () => { setTimeout(() => generatorOrNext.complete()); } :
                                      () => { generatorOrNext.complete(); };
       }
     } else {
-      schedulerFn = this._isAsync ? (value) => { setTimeout(() => generatorOrNext(value)); } :
+      schedulerFn = this.__isAsync ? (value) => { setTimeout(() => generatorOrNext(value)); } :
                                     (value) => { generatorOrNext(value); };
 
       if (error) {
         errorFn =
-            this._isAsync ? (err) => { setTimeout(() => error(err)); } : (err) => { error(err); };
+            this.__isAsync ? (err) => { setTimeout(() => error(err)); } : (err) => { error(err); };
       }
 
       if (complete) {
         completeFn =
-            this._isAsync ? () => { setTimeout(() => complete()); } : () => { complete(); };
+            this.__isAsync ? () => { setTimeout(() => complete()); } : () => { complete(); };
       }
     }
 

modules/@angular/http/tsconfig-es2015.json

@@ -5,6 +5,7 @@
   "compilerOptions": {
     "baseUrl": ".",
     "declaration": true,
+    "stripInternal": true,
     "emitDecoratorMetadata": true,
     "experimentalDecorators": true,
     "module": "es2015",

modules/@angular/http/tsconfig-es5.json

@@ -5,6 +5,7 @@
   "compilerOptions": {
     "baseUrl": ".",
     "declaration": true,
+    "stripInternal": true,
     "emitDecoratorMetadata": true,
     "experimentalDecorators": true,
     "module": "commonjs",

modules/@angular/platform-browser/tsconfig-es2015.json

@@ -5,6 +5,7 @@
   "compilerOptions": {
     "baseUrl": ".",
     "declaration": true,
+    "stripInternal": true,
     "emitDecoratorMetadata": true,
     "experimentalDecorators": true,
     "module": "es2015",

modules/@angular/platform-browser/tsconfig-es5.json

@@ -5,6 +5,7 @@
   "compilerOptions": {
     "baseUrl": ".",
     "declaration": true,
+    "stripInternal": true,
     "emitDecoratorMetadata": true,
     "experimentalDecorators": true,
     "module": "commonjs",

modules/@angular/platform-server/tsconfig-es2015.json

@@ -5,6 +5,7 @@
   "compilerOptions": {
     "baseUrl": ".",
     "declaration": true,
+    "stripInternal": true,
     "emitDecoratorMetadata": true,
     "experimentalDecorators": true,
     "module": "es2015",

modules/@angular/platform-server/tsconfig-es5.json

@@ -5,6 +5,7 @@
   "compilerOptions": {
     "baseUrl": ".",
     "declaration": true,
+    "stripInternal": true,
     "emitDecoratorMetadata": true,
     "experimentalDecorators": true,
     "module": "commonjs",

modules/@angular/router-deprecated/tsconfig-es2015.json

@@ -5,6 +5,7 @@
   "compilerOptions": {
     "baseUrl": ".",
     "declaration": true,
+    "stripInternal": true,
     "emitDecoratorMetadata": true,
     "experimentalDecorators": true,
     "module": "es2015",

modules/@angular/router-deprecated/tsconfig-es5.json

@@ -5,6 +5,7 @@
   "compilerOptions": {
     "baseUrl": ".",
     "declaration": true,
+    "stripInternal": true,
     "emitDecoratorMetadata": true,
     "experimentalDecorators": true,
     "module": "commonjs",

modules/@angular/router/tsconfig-es2015.json

@@ -5,6 +5,7 @@
   "compilerOptions": {
     "baseUrl": ".",
     "declaration": true,
+    "stripInternal": true,
     "emitDecoratorMetadata": true,
     "experimentalDecorators": true,
     "module": "es2015",

modules/@angular/router/tsconfig-es5.json

@@ -5,6 +5,7 @@
   "compilerOptions": {
     "baseUrl": ".",
     "declaration": true,
+    "stripInternal": true,
     "emitDecoratorMetadata": true,
     "experimentalDecorators": true,
     "module": "commonjs",

modules/@angular/upgrade/tsconfig-es2015.json

@@ -5,6 +5,7 @@
   "compilerOptions": {
     "baseUrl": ".",
     "declaration": true,
+    "stripInternal": true,
     "emitDecoratorMetadata": true,
     "experimentalDecorators": true,
     "module": "es2015",

modules/@angular/upgrade/tsconfig-es5.json

@@ -5,6 +5,7 @@
   "compilerOptions": {
     "baseUrl": ".",
     "declaration": true,
+    "stripInternal": true,
     "emitDecoratorMetadata": true,
     "experimentalDecorators": true,
     "module": "commonjs",