honeymoose
/
angular-cn
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

refactor(core): remove toString() method from DefaultKeyValueDiffer 

toString() from DefaultKeyValueDiffer is only used in tests and should not
be part of the production code. toString() methods from differs add
~ 0.3KB (min+gzip) to the production bundle size.
This commit is contained in:
Pawel Kozlowski 2017-06-15 15:29:02 +02:00 committed by Hans
parent f194f18dbd
commit 009651e14f
3 changed files with 58 additions and 56 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
packages/core/src/change_detection/differs/default_keyvalue_differ.ts
View File

@ -257,26 +257,6 @@ export class DefaultKeyValueDiffer<K, V> implements KeyValueDiffer<K, V>, KeyVal
}
}
toString(): string {
const items: string[] = [];
const previous: string[] = [];
const changes: string[] = [];
const additions: string[] = [];
const removals: string[] = [];
this.forEachItem(r => items.push(stringify(r)));
this.forEachPreviousItem(r => previous.push(stringify(r)));
this.forEachChangedItem(r => changes.push(stringify(r)));
this.forEachAddedItem(r => additions.push(stringify(r)));
this.forEachRemovedItem(r => removals.push(stringify(r)));
return 'map: ' + items.join(', ') + '\n' +
'previous: ' + previous.join(', ') + '\n' +
'additions: ' + additions.join(', ') + '\n' +
'changes: ' + changes.join(', ') + '\n' +
'removals: ' + removals.join(', ') + '\n';
}
/** @internal */
private _forEach<K, V>(obj: Map<K, V>|{[k: string]: V}, fn: (v: V, k: any) => void) {
if (obj instanceof Map) {
@ -309,11 +289,4 @@ class KeyValueChangeRecord_<K, V> implements KeyValueChangeRecord<K, V> {
_nextChanged: KeyValueChangeRecord_<K, V>|null = null;
constructor(public key: K) {}
toString(): string {
return looseIdentical(this.previousValue, this.currentValue) ?
stringify(this.key) :
(stringify(this.key) + '[' + stringify(this.previousValue) + '->' +
stringify(this.currentValue) + ']');
}
}

59
packages/core/test/change_detection/differs/default_keyvalue_differ_spec.ts
View File

@ -7,7 +7,9 @@
*/
import {DefaultKeyValueDiffer, DefaultKeyValueDifferFactory} from '@angular/core/src/change_detection/differs/default_keyvalue_differ';
import {kvChangesAsString} from '../../change_detection/util';
import {kvChangesAsString, testChangesAsString} from '../../change_detection/util';
// todo(vicb): Update the code & tests for object equality
export function main() {
@ -28,13 +30,13 @@ export function main() {
m.set('a', 1);
differ.check(m);
expect(differ.toString())
.toEqual(kvChangesAsString({map: ['a[null->1]'], additions: ['a[null->1]']}));
expect(kvChangesAsString(differ))
.toEqual(testChangesAsString({map: ['a[null->1]'], additions: ['a[null->1]']}));
m.set('b', 2);
differ.check(m);
expect(differ.toString())
.toEqual(kvChangesAsString(
expect(kvChangesAsString(differ))
.toEqual(testChangesAsString(
{map: ['a', 'b[null->2]'], previous: ['a'], additions: ['b[null->2]']}));
});
@ -46,7 +48,7 @@ export function main() {
m.set(2, 10);
m.set(1, 20);
differ.check(m);
expect(differ.toString()).toEqual(kvChangesAsString({
expect(kvChangesAsString(differ)).toEqual(testChangesAsString({
map: ['1[10->20]', '2[20->10]'],
previous: ['1[10->20]', '2[20->10]'],
changes: ['1[10->20]', '2[20->10]']
@ -72,19 +74,19 @@ export function main() {
m.set('a', 'A');
differ.check(m);
expect(differ.toString())
.toEqual(kvChangesAsString({map: ['a[null->A]'], additions: ['a[null->A]']}));
expect(kvChangesAsString(differ))
.toEqual(testChangesAsString({map: ['a[null->A]'], additions: ['a[null->A]']}));
m.set('b', 'B');
differ.check(m);
expect(differ.toString())
.toEqual(kvChangesAsString(
expect(kvChangesAsString(differ))
.toEqual(testChangesAsString(
{map: ['a', 'b[null->B]'], previous: ['a'], additions: ['b[null->B]']}));
m.set('b', 'BB');
m.set('d', 'D');
differ.check(m);
expect(differ.toString()).toEqual(kvChangesAsString({
expect(kvChangesAsString(differ)).toEqual(testChangesAsString({
map: ['a', 'b[B->BB]', 'd[null->D]'],
previous: ['a', 'b[B->BB]'],
additions: ['d[null->D]'],
@ -93,13 +95,13 @@ export function main() {
m.delete('b');
differ.check(m);
expect(differ.toString())
.toEqual(kvChangesAsString(
expect(kvChangesAsString(differ))
.toEqual(testChangesAsString(
{map: ['a', 'd'], previous: ['a', 'b[BB->null]', 'd'], removals: ['b[BB->null]']}));
m.clear();
differ.check(m);
expect(differ.toString()).toEqual(kvChangesAsString({
expect(kvChangesAsString(differ)).toEqual(testChangesAsString({
previous: ['a[A->null]', 'd[D->null]'],
removals: ['a[A->null]', 'd[D->null]']
}));
@ -110,7 +112,8 @@ export function main() {
differ.check(m);
differ.check(m);
expect(differ.toString()).toEqual(kvChangesAsString({map: ['foo'], previous: ['foo']}));
expect(kvChangesAsString(differ))
.toEqual(testChangesAsString({map: ['foo'], previous: ['foo']}));
});
it('should work regardless key order', () => {
@ -123,7 +126,7 @@ export function main() {
m.set('a', 1);
differ.check(m);
expect(differ.toString()).toEqual(kvChangesAsString({
expect(kvChangesAsString(differ)).toEqual(testChangesAsString({
map: ['b[0->1]', 'a[0->1]'],
previous: ['a[0->1]', 'b[0->1]'],
changes: ['b[0->1]', 'a[0->1]']
@ -145,19 +148,19 @@ export function main() {
m['a'] = 'A';
differ.check(m);
expect(differ.toString())
.toEqual(kvChangesAsString({map: ['a[null->A]'], additions: ['a[null->A]']}));
expect(kvChangesAsString(differ))
.toEqual(testChangesAsString({map: ['a[null->A]'], additions: ['a[null->A]']}));
m['b'] = 'B';
differ.check(m);
expect(differ.toString())
.toEqual(kvChangesAsString(
expect(kvChangesAsString(differ))
.toEqual(testChangesAsString(
{map: ['a', 'b[null->B]'], previous: ['a'], additions: ['b[null->B]']}));
m['b'] = 'BB';
m['d'] = 'D';
differ.check(m);
expect(differ.toString()).toEqual(kvChangesAsString({
expect(kvChangesAsString(differ)).toEqual(testChangesAsString({
map: ['a', 'b[B->BB]', 'd[null->D]'],
previous: ['a', 'b[B->BB]'],
additions: ['d[null->D]'],
@ -168,7 +171,7 @@ export function main() {
m['a'] = 'A';
m['d'] = 'D';
differ.check(m);
expect(differ.toString()).toEqual(kvChangesAsString({
expect(kvChangesAsString(differ)).toEqual(testChangesAsString({
map: ['a', 'd'],
previous: ['a', 'b[BB->null]', 'd'],
removals: ['b[BB->null]']
@ -176,7 +179,7 @@ export function main() {
m = {};
differ.check(m);
expect(differ.toString()).toEqual(kvChangesAsString({
expect(kvChangesAsString(differ)).toEqual(testChangesAsString({
previous: ['a[A->null]', 'd[D->null]'],
removals: ['a[A->null]', 'd[D->null]']
}));
@ -187,7 +190,7 @@ export function main() {
differ.check({a: 0, b: 0});
differ.check({b: 1, a: 1});
expect(differ.toString()).toEqual(kvChangesAsString({
expect(kvChangesAsString(differ)).toEqual(testChangesAsString({
map: ['b[0->1]', 'a[0->1]'],
previous: ['a[0->1]', 'b[0->1]'],
changes: ['b[0->1]', 'a[0->1]']
@ -200,7 +203,7 @@ export function main() {
differ.check({b: 3, a: 2});
differ.check({a: 1, b: 2});
expect(differ.toString()).toEqual(kvChangesAsString({
expect(kvChangesAsString(differ)).toEqual(testChangesAsString({
map: ['a[2->1]', 'b[3->2]'],
previous: ['b[3->2]', 'a[2->1]'],
changes: ['a[2->1]', 'b[3->2]']
@ -211,7 +214,7 @@ export function main() {
differ.check({a: 'a', b: 'b'});
differ.check({c: 'c', a: 'a'});
expect(differ.toString()).toEqual(kvChangesAsString({
expect(kvChangesAsString(differ)).toEqual(testChangesAsString({
map: ['c[null->c]', 'a'],
previous: ['a', 'b[b->null]'],
additions: ['c[null->c]'],
@ -236,8 +239,8 @@ export function main() {
it('should treat null as an empty list', () => {
m.set('a', 'A');
differ.diff(m);
expect(differ.diff(null).toString())
.toEqual(kvChangesAsString({previous: ['a[A->null]'], removals: ['a[A->null]']}));
expect(kvChangesAsString(differ.diff(null)))
.toEqual(testChangesAsString({previous: ['a[A->null]'], removals: ['a[A->null]']}));
});
it('should throw when given an invalid collection', () => {

28
packages/core/test/change_detection/util.ts
View File

@ -6,6 +6,9 @@
* found in the LICENSE file at https://angular.io/license
*/
import {KeyValueChangeRecord, KeyValueChanges} from '@angular/core/src/change_detection/differs/keyvalue_differs';
import {looseIdentical, stringify} from '../../src/util';
export function iterableChangesAsString(
@ -19,7 +22,30 @@ export function iterableChangesAsString(
'identityChanges: ' + identityChanges.join(', ') + '\n';
}
export function kvChangesAsString(
function kvcrAsString(kvcr: KeyValueChangeRecord<string, any>) {
return looseIdentical(kvcr.previousValue, kvcr.currentValue) ?
stringify(kvcr.key) :
(stringify(kvcr.key) + '[' + stringify(kvcr.previousValue) + '->' +
stringify(kvcr.currentValue) + ']');
}
export function kvChangesAsString(kvChanges: KeyValueChanges<string, any>) {
const map: string[] = [];
const previous: string[] = [];
const changes: string[] = [];
const additions: string[] = [];
const removals: string[] = [];
kvChanges.forEachItem(r => map.push(kvcrAsString(r)));
kvChanges.forEachPreviousItem(r => previous.push(kvcrAsString(r)));
kvChanges.forEachChangedItem(r => changes.push(kvcrAsString(r)));
kvChanges.forEachAddedItem(r => additions.push(kvcrAsString(r)));
kvChanges.forEachRemovedItem(r => removals.push(kvcrAsString(r)));
return testChangesAsString({map, previous, additions, changes, removals});
}
export function testChangesAsString(
{map, previous, additions, changes, removals}:
{map?: any[], previous?: any[], additions?: any[], changes?: any[], removals?: any[]}):
string {