honeymoose
/
angular-cn
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

ci: enable the Selenium Promise Manager in AIO e2e tests to avoid flakiness on CI (#39905) 

Since we turned off the Selenium Promise Manager in #39600, the AIO e2e
tests have started flaking on CI. After trying out several things, the
only change that seems to eliminate the flakiness is turning the
Selenium Promise Manager back on (see #39873 for more details).

This commit turns the Selenium Project Manager on to get rid of the
flakiness.

Fixes #39872

PR Close #39905
This commit is contained in:
George Kalpakas 2020-11-30 23:46:14 +02:00 committed by Jessica Janiuk
parent 07fa97c831
commit 00d56e4ead
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
aio/tests/e2e/protractor.conf.js
View File

@ -21,7 +21,12 @@ exports.config = {
},
},
directConnect: true,
SELENIUM_PROMISE_MANAGER: false,
// Keep the Selenium Promise Manager enabled to avoid flakiness on CI.
// See https://github.com/angular/angular/issues/39872 for more details.
//
// TODO(gkalpak): Set this back to `false` to align with CLI-generated apps when the flakiness is
// fixed in the future.
SELENIUM_PROMISE_MANAGER: true,
baseUrl: 'http://localhost:4200/',
framework: 'jasmine',
jasmineNodeOpts: {