honeymoose
/
angular-cn
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

build: fix circular deps failure (#36629) 

With the large scale refactoring of the repo to the new version of clang-format, some import orders were changed.

Specifically the imports found in this range.

The file previously read:

import {TestBed} from './test_bed';
import {ComponentFixtureAutoDetect, ComponentFixtureNoNgZone, TestBedStatic, TestComponentRenderer, TestModuleMetadata} from './test_bed_common';
import {R3TestBedCompiler} from './r3_test_bed_compiler';
and now reads:

import {R3TestBedCompiler} from './r3_test_bed_compiler';
import {TestBed} from './test_bed';
import {ComponentFixtureAutoDetect, ComponentFixtureNoNgZone, TestBedStatic, TestComponentRenderer, TestModuleMetadata} from './test_bed_common';
This change in order cause the circular dependency to be entered earlier and changed the golden file for our circular deps discovery.

PR Close #36629
This commit is contained in:
Joey Perrott 2020-04-14 13:17:43 -07:00 committed by atscott
parent b010849102
commit 0147de9044
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
goldens/packages-circular-deps.json
View File

@ -1807,9 +1807,10 @@
"packages/core/src/render3/interfaces/view.ts" "packages/core/src/render3/interfaces/view.ts"
], ],
[ [
"packages/core/testing/src/r3_test_bed.ts", "packages/core/testing/src/r3_test_bed_compiler.ts",
"packages/core/testing/src/test_bed_common.ts", "packages/core/testing/src/test_bed_common.ts",
"packages/core/testing/src/test_bed.ts" "packages/core/testing/src/test_bed.ts",
"packages/core/testing/src/r3_test_bed.ts"
], ],
[ [
"packages/core/testing/src/r3_test_bed.ts", "packages/core/testing/src/r3_test_bed.ts",