ci: save the cache in `build-npm-packages` job instead of `test` (#28555)

In most cases, it doesn't make a difference, because the cache does
already exist and is not saved. In the few cases where the dependencies
change (and the cache needs to be updated), it makes more sense to save
the cache in the `build-npm-packages` job, because most jobs depend on
it and thus will be able to take advantage of the updated cache right
away.

This seems to be an oversight in b26ac1c22.

PR Close #28555
This commit is contained in:
George Kalpakas 2019-02-06 10:26:36 +02:00 committed by Igor Minar
parent 43467c95ab
commit 01bb3c5820
1 changed files with 6 additions and 6 deletions

View File

@ -117,12 +117,6 @@ jobs:
- run: sudo cp .circleci/bazel.rc /etc/bazel.bazelrc - run: sudo cp .circleci/bazel.rc /etc/bazel.bazelrc
- run: yarn bazel test //... --build_tag_filters=-ivy-only,local --test_tag_filters=-ivy-only,local - run: yarn bazel test //... --build_tag_filters=-ivy-only,local --test_tag_filters=-ivy-only,local
- save_cache:
key: *cache_key
paths:
- "node_modules"
- "~/bazel_repository_cache"
# Temporary job to test what will happen when we flip the Ivy flag to true # Temporary job to test what will happen when we flip the Ivy flag to true
test_ivy_aot: test_ivy_aot:
<<: *job_defaults <<: *job_defaults
@ -355,6 +349,12 @@ jobs:
paths: paths:
- packages-dist - packages-dist
- save_cache:
key: *cache_key
paths:
- "node_modules"
- "~/bazel_repository_cache"
# Build the ivy npm packages. # Build the ivy npm packages.
build-ivy-npm-packages: build-ivy-npm-packages: