From 03d93c96a3af18fb8cecde48f797e8a4a1243023 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Matias=20Niemel=C3=A4?= Date: Wed, 14 Feb 2018 18:48:45 -0500 Subject: [PATCH] Revert: "build: merge-pr new checks that all requested changes have been addressed (#21817)" This reverts commit 4a4d74971079482244520620008fe81cb3e97b55. --- scripts/github/merge-pr | 6 ------ 1 file changed, 6 deletions(-) diff --git a/scripts/github/merge-pr b/scripts/github/merge-pr index e26fc1474b..937f577be4 100755 --- a/scripts/github/merge-pr +++ b/scripts/github/merge-pr @@ -43,7 +43,6 @@ PULL_JSON=`curl -s https://api.github.com/repos/angular/angular/pulls/$PR_NUMBER PR_SHA_COUNT=`node $BASEDIR/utils/json_extract.js commits <<< """$PULL_JSON"""` STATUS_JSON_URL=`node $BASEDIR/utils/json_extract.js _links.statuses.href <<< """$PULL_JSON"""` STATUS=`curl -s $STATUS_JSON_URL | node $BASEDIR/utils/json_extract.js description | cut -d '|' -f1` -MERGE_STATUS=`curl -s https://api.github.com/repos/angular/angular/pulls/$PR_NUMBER/reviews | node ./scripts/github/utils/json_extract.js state` PR_LABELS=`curl -s https://api.github.com/repos/angular/angular/issues/$PR_NUMBER/labels` PR_ACTION=`echo "$PR_LABELS" | node $BASEDIR/utils/json_extract.js "name=^PR action:"` PR_TARGET=`echo "$PR_LABELS" | node $BASEDIR/utils/json_extract.js "name=^PR target:"` @@ -61,11 +60,6 @@ if [[ "$PR_CLA" != "cla: yes" ]]; then exit 1 fi -if [[ $MERGE_STATUS == *CHANGES_REQUESTED* ]]; then - echo The PR $PR_NUMBER has not been approved by all reviewers. Ask PR owner to obtain reviews or dismiss reviews and document the dismissal reason. - exit 1 -fi - if [[ "$STATUS" != "All checks passed!" ]]; then echo PR $PR_NUMBER is failing with: $STATUS if [[ $FORCE == 1 ]]; then