honeymoose
/
angular-cn
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

ci: github robot should enforce that all requested reviews are submitted (#25336) 

See docs in the diff for justification.
PR Close #25336
This commit is contained in:
Igor Minar 2018-08-06 12:06:50 -07:00 committed by Ben Lesh
parent 3ac7070009
commit 09711507f9
1 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
.github/angular-robot.yml vendored
View File

@ -62,6 +62,13 @@ merge:
# list of checks that will determine if the merge label can be added # list of checks that will determine if the merge label can be added
checks: checks:
# require that the PR has reviews from all requested reviewers
#
# This enables us to request reviews from both eng and tech writers, or multiple eng folks, and prevents accidental merges.
# Rather than merging PRs with pending reviews, if all PullApprove requirements are satisfied and additional reviews are not needed pending reviewers should be removed via GitHub UI (this also leaves an audit trail behind these decisions).
requireReviews: true,
# whether the PR shouldn't have a conflict with the base branch # whether the PR shouldn't have a conflict with the base branch
noConflict: true noConflict: true
# list of labels that a PR needs to have, checked with a regexp (e.g. "PR target:" will work for the label "PR target: master") # list of labels that a PR needs to have, checked with a regexp (e.g. "PR target:" will work for the label "PR target: master")