honeymoose
/
angular-cn
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix(gulpfile): fix the dartanalyzer task

This commit is contained in:
vsavkin 2014-12-29 18:09:30 -08:00
parent 3a80c4197d
commit 0a4d6170ba
1 changed files with 13 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
tools/build/dartanalyzer.js
View File

@ -31,7 +31,8 @@ module.exports = function(gulp, plugins, config) {
}));
function analyze(dirName, done) {
var stream = spawn(config.command, ['--fatal-warnings', tempFile], {
//TODO remove --package-warnings once dartanalyzer handles transitive libraries
var stream = spawn(config.command, ['--fatal-warnings', '--package-warnings', tempFile], {
// inherit stdin and stderr, but filter stdout
stdio: [process.stdin, 'pipe', process.stderr],
cwd: dirName
@ -46,19 +47,27 @@ module.exports = function(gulp, plugins, config) {
terminal: false
});
var hintCount = 0;
var errorCount = 0;
rl.on('line', function(line) {
//TODO remove once dartanalyzer handles transitive libraries
//skip errors in third-party packages
if (line.indexOf(dirName) == -1) {
return;
}
if (line.match(/Unused import/)) {
return;
}
if (line.match(/\[hint\]/)) {
hintCount++;
} else {
errorCount ++;
}
console.log(dirName + ':' + line);
});
stream.on('close', function(code) {
stream.on('close', function() {
var error;
if (code !== 0) {
error = new Error('Dartanalyzer failed with exit code ' + code);
if (errorCount > 0) {
error = new Error('Dartanalyzer showed errors');
}
if (hintCount > 0) {
error = new Error('Dartanalyzer showed hints');