From 0c2490368e10dd939353b21fc3ba20f441c97e5e Mon Sep 17 00:00:00 2001 From: Sonu Kapoor Date: Wed, 15 Jul 2020 18:59:11 -0400 Subject: [PATCH] refactor(platform-browser): specify return type of parseEventName (#38089) This commit refactors the argument of the `parseEventName` function to use an object with named properties instead of using an object indexer. PR Close #38089 --- packages/platform-browser/src/dom/events/key_events.ts | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/packages/platform-browser/src/dom/events/key_events.ts b/packages/platform-browser/src/dom/events/key_events.ts index 8ac3859fbe..45d8154319 100644 --- a/packages/platform-browser/src/dom/events/key_events.ts +++ b/packages/platform-browser/src/dom/events/key_events.ts @@ -111,7 +111,7 @@ export class KeyEventsPlugin extends EventManagerPlugin { }); } - static parseEventName(eventName: string): {[key: string]: string}|null { + static parseEventName(eventName: string): {fullKey: string, domEventName: string}|null { const parts: string[] = eventName.toLowerCase().split('.'); const domEventName = parts.shift(); @@ -136,7 +136,10 @@ export class KeyEventsPlugin extends EventManagerPlugin { return null; } - const result: {[k: string]: string} = {}; + // NOTE: Please don't rewrite this as so, as it will break JSCompiler property renaming. + // The code must remain in the `result['domEventName']` form. + // return {domEventName, fullKey}; + const result: {fullKey: string, domEventName: string} = {} as any; result['domEventName'] = domEventName; result['fullKey'] = fullKey; return result;