honeymoose/angular-cn
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

docs(bench press): Added link to Chromedriver bug for reference

Browse Source 
Closes #1923
This commit is contained in:
Michael Goderbauer 2015-05-15 11:43:35 -07:00 committed by Tobias Bosch
parent 9fbb3adbe2
commit 0e04467b8a
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
modules/benchpress/src/webdriver/chrome_driver_extension.js
View File

@ -38,8 +38,8 @@ export class ChromeDriverExtension extends WebDriverExtension {
// See [Chrome Trace Event Format](https://docs.google.com/document/d/1CvAClvFfyA5R-PhYUmn5OOQtYMH4h6I0nSsKchNAySU/edit) // See [Chrome Trace Event Format](https://docs.google.com/document/d/1CvAClvFfyA5R-PhYUmn5OOQtYMH4h6I0nSsKchNAySU/edit)
readPerfLog() { readPerfLog() {
// TODO(tbosch): Bug in ChromeDriver: Need to execute at least one command // TODO(tbosch): Chromedriver bug https://code.google.com/p/chromedriver/issues/detail?id=1098
// so that the browser logs can be read out! // Need to execute at least one command so that the browser logs can be read out!
return this._driver.executeScript('1+1') return this._driver.executeScript('1+1')
.then( (_) => this._driver.logs('performance') ) .then( (_) => this._driver.logs('performance') )
.then( (entries) => { .then( (entries) => {
@ -154,4 +154,4 @@ var _BINDINGS = [
(driver) => new ChromeDriverExtension(driver), (driver) => new ChromeDriverExtension(driver),
[WebDriverAdapter] [WebDriverAdapter]
) )
]; ];