honeymoose
/
angular-cn
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

docs(core): mark `EventEmitter#__isAsync` as internal to hide from API docs (#31378) 

The `__isAsync` property is not part of the public API and should not
appear in the API docs.

PR Close #31378
This commit is contained in:
George Kalpakas 2019-10-03 19:28:56 +03:00 committed by atscott
parent 9364a14d36
commit 0f21ae9a74
2 changed files with 1 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
packages/core/src/event_emitter.ts
View File

@ -62,12 +62,8 @@ import {Subject, Subscription} from 'rxjs';
* @publicApi * @publicApi
*/ */
export class EventEmitter<T extends any> extends Subject<T> { export class EventEmitter<T extends any> extends Subject<T> {
// TODO: mark this as internal once all the facades are gone
// we can't mark it as internal now because EventEmitter exported via @angular/core would not
// contain this property making it incompatible with all the code that uses EventEmitter via
// facades, which are local to the code and do not have this property stripped.
/** /**
* Internal * @internal
*/ */
__isAsync: boolean; // tslint:disable-line __isAsync: boolean; // tslint:disable-line

1
tools/public_api_guard/core/core.d.ts vendored
View File

@ -326,7 +326,6 @@ export declare class ErrorHandler {
} }
export declare class EventEmitter<T extends any> extends Subject<T> { export declare class EventEmitter<T extends any> extends Subject<T> {
__isAsync: boolean;
constructor(isAsync?: boolean); constructor(isAsync?: boolean);
emit(value?: T): void; emit(value?: T): void;
subscribe(generatorOrNext?: any, error?: any, complete?: any): Subscription; subscribe(generatorOrNext?: any, error?: any, complete?: any): Subscription;