honeymoose
/
angular-cn
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

test(compiler): check that the parser supports prematurely terminated interpolations (#42062) 

Such interpolations turned up during internal testing at Google, so this
commit adds a test to prevent regressions.

PR Close #42062
This commit is contained in:
Pete Bacon Darwin 2021-06-17 18:06:33 +01:00 committed by atscott
parent 9b3d4f5575
commit 11ebe21d0d
1 changed files with 27 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

27
packages/compiler/test/ml_parser/html_parser_spec.ts
View File

@ -239,6 +239,23 @@ import {humanizeDom, humanizeDomSourceSpans, humanizeLineColumn, humanizeNodes}
]);
expect(parsed.errors).toEqual([]);
});
it('should treat prematurely terminated interpolation as text', () => {
const {errors, rootNodes} =
parser.parse('<div><span>x {{ expr }<!---->} y</span><div></div></div>', 'TestComp');
expect(humanizeNodes(rootNodes, true)).toEqual([
[
html.Element, 'div', 0, '<div><span>x {{ expr }<!---->} y</span><div></div></div>',
'<div>', '</div>'
],
[html.Element, 'span', 1, '<span>x {{ expr }<!---->} y</span>', '<span>', '</span>'],
[html.Text, 'x {{ expr }', 2, ['x '], ['{{', ' expr }'], [''], 'x {{ expr }'],
[html.Comment, '', 2, '<!--'],
[html.Text, '} y', 2, ['} y'], '} y'],
[html.Element, 'div', 1, '<div></div>', '<div>', '</div>'],
]);
expect(errors).toEqual([]);
});
});
describe('attributes', () => {
@ -318,6 +335,16 @@ import {humanizeDom, humanizeDomSourceSpans, humanizeLineColumn, humanizeNodes}
[html.Attribute, ':xlink:href', 'Port', ['Port']],
]);
});
it('should support a prematurely terminated interpolation in attribute', () => {
const {errors, rootNodes} = parser.parse('<div p="{{ abc"><span></span>', 'TestComp');
expect(humanizeNodes(rootNodes, true)).toEqual([
[html.Element, 'div', 0, '<div p="{{ abc">', '<div p="{{ abc">', null],
[html.Attribute, 'p', '{{ abc', [''], ['{{', ' abc'], [''], 'p="{{ abc"'],
[html.Element, 'span', 1, '<span></span>', '<span>', '</span>'],
]);
expect(humanizeErrors(errors)).toEqual([]);
});
});
describe('comments', () => {