From 13f8648a002fb2a47bcf980eab5d087e54cafd74 Mon Sep 17 00:00:00 2001 From: Hans Larsen Date: Mon, 30 Oct 2017 11:51:03 -0700 Subject: [PATCH] fix: add missing globals from each rollup configuration (#20028) PR Close #20028 --- packages/common/http/rollup.config.js | 1 + packages/common/http/testing/rollup.config.js | 3 +++ packages/common/rollup.config.js | 2 ++ packages/http/rollup.config.js | 1 + packages/platform-server/rollup.config.js | 5 +++++ packages/platform-server/testing/rollup.config.js | 1 + packages/router/rollup.config.js | 1 + 7 files changed, 14 insertions(+) diff --git a/packages/common/http/rollup.config.js b/packages/common/http/rollup.config.js index bb3d2346bf..2b4f028586 100644 --- a/packages/common/http/rollup.config.js +++ b/packages/common/http/rollup.config.js @@ -11,6 +11,7 @@ const globals = { '@angular/platform-browser': 'ng.platformBrowser', '@angular/common': 'ng.common', 'rxjs/Observable': 'Rx', + 'rxjs/Observer': 'Rx', 'rxjs/Subject': 'Rx', 'rxjs/observable/of': 'Rx.Observable.prototype', diff --git a/packages/common/http/testing/rollup.config.js b/packages/common/http/testing/rollup.config.js index 758fdb05a0..00ce61eae5 100644 --- a/packages/common/http/testing/rollup.config.js +++ b/packages/common/http/testing/rollup.config.js @@ -15,8 +15,11 @@ const globals = { '@angular/common': 'ng.common', '@angular/common/http': 'ng.common.http', 'rxjs/Observable': 'Rx', + 'rxjs/Observer': 'Rx', 'rxjs/ReplaySubject': 'Rx', 'rxjs/Subject': 'Rx', + + 'rxjs/operator/startWith': 'Rx.Observable.prototype', }; module.exports = { diff --git a/packages/common/rollup.config.js b/packages/common/rollup.config.js index 390451dda5..8fac9ce640 100644 --- a/packages/common/rollup.config.js +++ b/packages/common/rollup.config.js @@ -12,7 +12,9 @@ const sourcemaps = require('rollup-plugin-sourcemaps'); const globals = { '@angular/core': 'ng.core', 'rxjs/Observable': 'Rx', + 'rxjs/Observer': 'Rx', 'rxjs/Subject': 'Rx', + 'rxjs/Subscription': 'Rx', }; module.exports = { diff --git a/packages/http/rollup.config.js b/packages/http/rollup.config.js index a270c03b95..ca9e1e22c7 100644 --- a/packages/http/rollup.config.js +++ b/packages/http/rollup.config.js @@ -14,6 +14,7 @@ const globals = { '@angular/compiler': 'ng.compiler', '@angular/platform-browser': 'ng.platformBrowser', 'rxjs/Observable': 'Rx', + 'rxjs/Observer': 'Rx', 'rxjs/Subject': 'Rx' }; diff --git a/packages/platform-server/rollup.config.js b/packages/platform-server/rollup.config.js index f89c6ee2e0..d27bf43ba3 100644 --- a/packages/platform-server/rollup.config.js +++ b/packages/platform-server/rollup.config.js @@ -11,14 +11,19 @@ const sourcemaps = require('rollup-plugin-sourcemaps'); const globals = { '@angular/animations': 'ng.animations', + '@angular/animations/browser': 'ng.animations.browser', '@angular/core': 'ng.core', '@angular/common': 'ng.common', + '@angular/common/http': 'ng.common.http', '@angular/compiler': 'ng.compiler', '@angular/http': 'ng.http', '@angular/platform-browser': 'ng.platformBrowser', + '@angular/platform-browser/animations': 'ng.platformBrowser.animations', '@angular/platform-browser-dynamic': 'ng.platformBrowserDynamic', 'rxjs/Observable': 'Rx', + 'rxjs/Observer': 'Rx', 'rxjs/Subject': 'Rx', + 'rxjs/Subscription': 'Rx', 'rxjs/operator/toPromise': 'Rx.Observable.prototype', 'rxjs/operator/filter': 'Rx.Observable.prototype', 'rxjs/operator/first': 'Rx.Observable.prototype' diff --git a/packages/platform-server/testing/rollup.config.js b/packages/platform-server/testing/rollup.config.js index 7c4d2f0f7c..260aaf8f49 100644 --- a/packages/platform-server/testing/rollup.config.js +++ b/packages/platform-server/testing/rollup.config.js @@ -15,6 +15,7 @@ const globals = { '@angular/compiler': 'ng.compiler', '@angular/compiler/testing': 'ng.compiler.testing', '@angular/platform-browser': 'ng.platformBrowser', + '@angular/platform-browser/animations': 'ng.platformBrowser.animations', '@angular/platform-server': 'ng.platformServer', '@angular/platform-browser-dynamic/testing': 'ng.platformBrowserDynamic.testing' }; diff --git a/packages/router/rollup.config.js b/packages/router/rollup.config.js index 9822296929..40cca57800 100644 --- a/packages/router/rollup.config.js +++ b/packages/router/rollup.config.js @@ -16,6 +16,7 @@ const globals = { 'rxjs/BehaviorSubject': 'Rx', 'rxjs/Observable': 'Rx', + 'rxjs/Observer': 'Rx', 'rxjs/Subject': 'Rx', 'rxjs/Subscription': 'Rx', 'rxjs/util/EmptyError': 'Rx',