From 14380ff08657243c9c7dba7ebcde2d01064a9d51 Mon Sep 17 00:00:00 2001 From: Filipe Silva Date: Thu, 19 Oct 2017 14:07:35 +0100 Subject: [PATCH] build: add warning about changing ngtools_api2 --- .pullapprove.yml | 19 +++++++++++++++++-- packages/compiler-cli/src/ngtools_api.ts | 6 ++++++ packages/compiler-cli/src/ngtools_api2.ts | 6 ++++++ packages/compiler-cli/src/ngtools_impl.ts | 7 +++++++ 4 files changed, 36 insertions(+), 2 deletions(-) diff --git a/.pullapprove.yml b/.pullapprove.yml index f9ddc46d73..e5ec0433d6 100644 --- a/.pullapprove.yml +++ b/.pullapprove.yml @@ -7,9 +7,12 @@ # # alexeagle - Alex Eagle # alxhub - Alex Rickabaugh +# brocco - Mike Brocchi # chuckjaz - Chuck Jazdzewski +# filipesilva - Filipe Silva # Foxandxss - Jesús Rodríguez # gkalpak - George Kalpakas +# hansl - Hans Larsen # IgorMinar - Igor Minar # jasonaden - Jason Aden # juleskremer - Jules Kremer @@ -144,11 +147,23 @@ groups: - mhevery - IgorMinar #fallback + compiler-cli/ngtools: + conditions: + files: + - "packages/compiler-cli/src/ngtools*" + users: + - hansl + - filipesilva #fallback + - brocco #fallback + compiler-cli: conditions: files: - - "packages/compiler-cli/*" - - "packages/bazel/*" + include: + - "packages/compiler-cli/*" + - "packages/bazel/*" + exclude: + - "packages/compiler-cli/src/ngtools*" users: - alexeagle - chuckjaz diff --git a/packages/compiler-cli/src/ngtools_api.ts b/packages/compiler-cli/src/ngtools_api.ts index 97b85e0472..5e5e771c5e 100644 --- a/packages/compiler-cli/src/ngtools_api.ts +++ b/packages/compiler-cli/src/ngtools_api.ts @@ -13,6 +13,12 @@ * something else. */ +/** + ********************************************************************* + * Changes to this file need to be approved by the Angular CLI team. * + ********************************************************************* + */ + import {AotCompilerHost, AotSummaryResolver, StaticReflector, StaticSymbolCache, StaticSymbolResolver} from '@angular/compiler'; import * as ts from 'typescript'; diff --git a/packages/compiler-cli/src/ngtools_api2.ts b/packages/compiler-cli/src/ngtools_api2.ts index 0a760b1623..4542da69bb 100644 --- a/packages/compiler-cli/src/ngtools_api2.ts +++ b/packages/compiler-cli/src/ngtools_api2.ts @@ -15,6 +15,12 @@ * Once the ngc api is public and stable, this can be removed. */ +/** + ********************************************************************* + * Changes to this file need to be approved by the Angular CLI team. * + ********************************************************************* + */ + import {ParseSourceSpan} from '@angular/compiler'; import * as ts from 'typescript'; diff --git a/packages/compiler-cli/src/ngtools_impl.ts b/packages/compiler-cli/src/ngtools_impl.ts index 2e90fd6bc6..0827f83024 100644 --- a/packages/compiler-cli/src/ngtools_impl.ts +++ b/packages/compiler-cli/src/ngtools_impl.ts @@ -12,6 +12,13 @@ * This API should be stable for NG 2. It can be removed in NG 4..., but should be replaced by * something else. */ + +/** + ********************************************************************* + * Changes to this file need to be approved by the Angular CLI team. * + ********************************************************************* + */ + import {AotCompilerHost, StaticReflector, StaticSymbol, core} from '@angular/compiler';