From 1716b913348d00aba535222fda01dccca52a0152 Mon Sep 17 00:00:00 2001 From: ayazhafiz Date: Fri, 6 Sep 2019 15:12:58 -0500 Subject: [PATCH] feat(language-service): add script to rebuild, refresh Angular dist (#32515) The Language Service integration tests should reinstall the Angular distribution every time it is built. Adds a `yarn build-dist` convinience script so building the distribution doesn't have to happen on the repo root. This new script also refreshes the installed modules. Building is expesnive, so it is not bundled with testing scripts. PR Close #32515 --- integration/language_service_plugin/README.md | 6 +++--- integration/language_service_plugin/package.json | 1 + 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/integration/language_service_plugin/README.md b/integration/language_service_plugin/README.md index 1f76230fa9..a687d839b2 100644 --- a/integration/language_service_plugin/README.md +++ b/integration/language_service_plugin/README.md @@ -7,9 +7,9 @@ To use the tests: - Use `yarn install` to install all dependencies in this directory and in the Angular repo root directory. -- From the Angular repo root directory, build Angular in the `dist/packages-dist` folder with - `./scripts/build-packages-dist.sh`. -- In this directory, run the tests with `yarn test`. +- Build an Angular distribution with `yarn build-dist`. This needs to be done after changes to + Angular, but not after changes to integration tests. This is an expensive build. +- In this directory, run the integration tests with `yarn test`. ## Update golden files diff --git a/integration/language_service_plugin/package.json b/integration/language_service_plugin/package.json index 3fe1900776..23d77fcbbf 100644 --- a/integration/language_service_plugin/package.json +++ b/integration/language_service_plugin/package.json @@ -12,6 +12,7 @@ }, "scripts": { "build": "tsc -p tsconfig.json", + "build-dist": "../../scripts/build-packages-dist.sh && yarn install --check-files", "cleanup": "rm -rf ti-*.log tsserver.log", "golden": "yarn build && node generate.js", "test": "yarn cleanup && yarn build && jasmine test.js"