honeymoose
/
angular-cn
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

build: fix elements test failures on IE (#35940) 

Fixes the following issues which caused the `elements` unit tests to break on IE:
1. `core.js` wasn't included which caused an error about `Promise` and `Symbol` to be thrown.
2. We were using a version of `@webcomponents/custom-elements` which was shipping ES6 code to npm. As a result, IE was throwing a syntax error.

PR Close #35940
This commit is contained in:
crisbeto 2020-03-08 16:52:17 +01:00 committed by Matias Niemelä
parent 9368053be5
commit 191e4d15b5
3 changed files with 6 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
package.json
View File

@ -78,7 +78,7 @@
"@types/systemjs": "0.19.32", "@types/systemjs": "0.19.32",
"@types/yaml": "^1.2.0", "@types/yaml": "^1.2.0",
"@types/yargs": "^11.1.1", "@types/yargs": "^11.1.1",
"@webcomponents/custom-elements": "^1.0.4", "@webcomponents/custom-elements": "^1.1.0",
"angular": "npm:angular@1.7", "angular": "npm:angular@1.7",
"angular-1.5": "npm:angular@1.5", "angular-1.5": "npm:angular@1.5",
"angular-1.6": "npm:angular@1.6", "angular-1.6": "npm:angular@1.6",

6
packages/elements/test/BUILD.bazel
View File

@ -30,6 +30,7 @@ filegroup(
testonly = True, testonly = True,
# do not sort # do not sort
srcs = [ srcs = [
"@npm//:node_modules/core-js/client/core.js",
"@npm//:node_modules/@webcomponents/custom-elements/src/native-shim.js", "@npm//:node_modules/@webcomponents/custom-elements/src/native-shim.js",
"@npm//:node_modules/reflect-metadata/Reflect.js", "@npm//:node_modules/reflect-metadata/Reflect.js",
"//packages/zone.js/dist:zone.js", "//packages/zone.js/dist:zone.js",
@ -42,11 +43,6 @@ karma_web_test_suite(
bootstrap = [ bootstrap = [
":elements_test_bootstrap_scripts", ":elements_test_bootstrap_scripts",
], ],
tags = [
# FIXME: timed out in CI
"fixme-saucelabs-ivy",
"fixme-saucelabs-ve",
],
deps = [ deps = [
":test_lib", ":test_lib",
], ],

8
yarn.lock
View File

@ -1905,10 +1905,10 @@
"@webassemblyjs/wast-parser" "1.8.5" "@webassemblyjs/wast-parser" "1.8.5"
"@xtuc/long" "4.2.2" "@xtuc/long" "4.2.2"
"@webcomponents/custom-elements@^1.0.4": "@webcomponents/custom-elements@^1.1.0":
version "1.1.2" version "1.4.0"
resolved "https://registry.yarnpkg.com/@webcomponents/custom-elements/-/custom-elements-1.1.2.tgz#041e4c20df35245f4d160b50d044b8cff192962c" resolved "https://registry.yarnpkg.com/@webcomponents/custom-elements/-/custom-elements-1.4.0.tgz#f21f41804e1f708d1bc924c345413f8a0e9b51a3"
integrity sha512-gVhuQHLTrQ28v1qMp0WGPSCBukFL7qAlemxCf19TnuNZ0bO9KPF72bfhH6Hpuwdu9TptIMGNlqrr9PzqrzfZFQ== integrity sha512-t9xpI4KVH4IcVp9XqLIAxHOovNcaUDDcfjK3v7ORv7xjnbIL1Dc+735tUTgyJvugTPAaxunILJY+Rh6+5729Hw==
"@xtuc/ieee754@^1.2.0": "@xtuc/ieee754@^1.2.0":
version "1.2.0" version "1.2.0"