From 1b3ee17888264abb1394ca18056b0a2b87a701a2 Mon Sep 17 00:00:00 2001 From: Joey Perrott Date: Tue, 14 Apr 2020 13:37:54 -0700 Subject: [PATCH] build: move circular deps golden to a subfolder (#36630) Moves the circular deps golden for packages into a subfolder of goldens, `/goldens/circular-deps/` to more easily target the files for ownership. PR Close #36630 --- .pullapprove.yml | 2 +- .../packages.json} | 0 packages/circular-deps-test.conf.js | 2 +- 3 files changed, 2 insertions(+), 2 deletions(-) rename goldens/{packages-circular-deps.json => circular-deps/packages.json} (100%) diff --git a/.pullapprove.yml b/.pullapprove.yml index 29637b8f9a..6cfa9a58d9 100644 --- a/.pullapprove.yml +++ b/.pullapprove.yml @@ -1044,7 +1044,7 @@ groups: - *can-be-global-approved - > contains_any_globs(files, [ - 'goldens/packages-circular-deps.json' + 'goldens/circular-deps/packages.json' ]) reviewers: users: diff --git a/goldens/packages-circular-deps.json b/goldens/circular-deps/packages.json similarity index 100% rename from goldens/packages-circular-deps.json rename to goldens/circular-deps/packages.json diff --git a/packages/circular-deps-test.conf.js b/packages/circular-deps-test.conf.js index 83f9a1d5f4..9ca6056118 100644 --- a/packages/circular-deps-test.conf.js +++ b/packages/circular-deps-test.conf.js @@ -10,7 +10,7 @@ const path = require('path'); module.exports = { baseDir: '../', - goldenFile: '../goldens/packages-circular-deps.json', + goldenFile: '../goldens/circular-deps/packages.json', // The test should not capture deprecated packages such as `http`, or the `webworker` platform. glob: `./!(http|platform-webworker|platform-webworker-dynamic)/**/*.ts`, // Command that will be displayed if the golden needs to be updated.