honeymoose
/
angular-cn
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix(platform-browser): support Symbols in custom jasmineToString() method (#19794) 

It's illegal to coerce a Symbol to a string, and results in a TypeError:

TypeError: Cannot convert a Symbol value to a string

Previously, the custom jasmineToString() method monkey-patched onto Maps
in platform-browser/testing/src/matchers.ts would coerce keys and values
to strings. A change in a newer version of Jasmine calls this method more
often, resulting in calls against Maps which contain Symbols in some
applications, which causes crashes.

The fix is to explicitly convert keys and values to strings, which does
work on Symbols.
This commit is contained in:
Alex Rickabaugh 2017-11-03 11:11:47 -07:00 committed by Victor Berchet
parent 03f080b7da
commit 1d19d61970
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
packages/platform-browser/testing/src/matchers.ts
View File

@ -107,7 +107,7 @@ export const expect: (actual: any) => NgMatchers = <any>_global.expect;
return '' + m; return '' + m;
} }
const res: any[] = []; const res: any[] = [];
m.forEach((v: any, k: any) => { res.push(`${k}:${v}`); }); m.forEach((v: any, k: any) => { res.push(`${String(k)}:${String(v)}`); });
return `{ ${res.join(',')} }`; return `{ ${res.join(',')} }`;
}; };