build: playground examples do not explicitly specify "ng_module" assets (#28562)

Currently all playground examples are built with NGC, and most
of the HTML resources are automatically inlined. Surprisingly NGC
is able to resolve the relative component assets even though these
aren't specified in the `assets`. This seems to work because NGC
resolves the files in the execroot where the files are present
(if Bazel doesn't use sandboxing).

Issue is tracked with TOOL-667

PR Close #28562
This commit is contained in:
Paul Gschwendtner 2019-02-06 14:22:01 +01:00 committed by Miško Hevery
parent 7e895b9179
commit 1d20088291
6 changed files with 6 additions and 1 deletions

View File

@ -6,6 +6,7 @@ package(default_visibility = ["//modules/playground:__subpackages__"])
ng_module( ng_module(
name = "gestures", name = "gestures",
srcs = glob(["**/*.ts"]), srcs = glob(["**/*.ts"]),
assets = ["template.html"],
tsconfig = "//modules/playground:tsconfig-build.json", tsconfig = "//modules/playground:tsconfig-build.json",
# TODO: FW-1004 Type checking is currently not complete. # TODO: FW-1004 Type checking is currently not complete.
type_check = False, type_check = False,

View File

@ -6,6 +6,7 @@ package(default_visibility = ["//modules/playground:__subpackages__"])
ng_module( ng_module(
name = "todo", name = "todo",
srcs = glob(["**/*.ts"]), srcs = glob(["**/*.ts"]),
assets = ["todo.html"],
tsconfig = "//modules/playground:tsconfig-build.json", tsconfig = "//modules/playground:tsconfig-build.json",
# TODO: FW-1004 Type checking is currently not complete. # TODO: FW-1004 Type checking is currently not complete.
type_check = False, type_check = False,

View File

@ -6,6 +6,7 @@ package(default_visibility = ["//modules/playground:__subpackages__"])
ng_module( ng_module(
name = "images", name = "images",
srcs = glob(["**/*.ts"]), srcs = glob(["**/*.ts"]),
assets = ["image_demo.html"],
tsconfig = "//modules/playground:tsconfig-build.json", tsconfig = "//modules/playground:tsconfig-build.json",
# TODO: FW-1004 Type checking is currently not complete. # TODO: FW-1004 Type checking is currently not complete.
type_check = False, type_check = False,

View File

@ -6,6 +6,7 @@ package(default_visibility = ["//modules/playground:__subpackages__"])
ng_module( ng_module(
name = "router", name = "router",
srcs = glob(["**/*.ts"]), srcs = glob(["**/*.ts"]),
assets = ["app.html"],
tsconfig = "//modules/playground:tsconfig-build.json", tsconfig = "//modules/playground:tsconfig-build.json",
# TODO: FW-1004 Type checking is currently not complete. # TODO: FW-1004 Type checking is currently not complete.
type_check = False, type_check = False,

View File

@ -6,6 +6,7 @@ package(default_visibility = ["//modules/playground:__subpackages__"])
ng_module( ng_module(
name = "todo", name = "todo",
srcs = glob(["**/*.ts"]), srcs = glob(["**/*.ts"]),
assets = ["todo.html"],
tsconfig = "//modules/playground:tsconfig-build.json", tsconfig = "//modules/playground:tsconfig-build.json",
# TODO: FW-1004 Type checking is currently not complete. # TODO: FW-1004 Type checking is currently not complete.
type_check = False, type_check = False,

View File

@ -6,7 +6,7 @@ package(default_visibility = ["//modules/playground:__subpackages__"])
ng_module( ng_module(
name = "zippy_component", name = "zippy_component",
srcs = glob(["**/*.ts"]), srcs = glob(["**/*.ts"]),
assets = glob(["**/*.html"]), assets = glob(["app/zippy.html"]),
tsconfig = "//modules/playground:tsconfig-build.json", tsconfig = "//modules/playground:tsconfig-build.json",
# TODO: FW-1004 Type checking is currently not complete. # TODO: FW-1004 Type checking is currently not complete.
type_check = False, type_check = False,