From 1e2d879632d16a6dbbaa5de39ac928182651d0c5 Mon Sep 17 00:00:00 2001 From: Arthur Ming Date: Wed, 16 Jun 2021 16:28:56 +0800 Subject: [PATCH] refactor(core): optimize the implementation about finding context from error in ErrorHandler (#42581) in _findContext method, use conditional operator check whether the params 'error' exists and then use nullish coalescing operator instead conditional operator when getDebugContext's result does not exist. PR Close #42581 --- packages/core/src/error_handler.ts | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/packages/core/src/error_handler.ts b/packages/core/src/error_handler.ts index 7f5ec2748e..ba7dc77033 100644 --- a/packages/core/src/error_handler.ts +++ b/packages/core/src/error_handler.ts @@ -59,12 +59,7 @@ export class ErrorHandler { /** @internal */ _findContext(error: any): any { - if (error) { - return getDebugContext(error) ? getDebugContext(error) : - this._findContext(getOriginalError(error)); - } - - return null; + return !error ? null : getDebugContext(error) ?? this._findContext(getOriginalError(error)); } /** @internal */