honeymoose
/
angular-cn
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix(bazel): clean up outstanding failure message for usages of --define=compile (#39046) 

Removes the failure message put in place to catch usages of the old --define=compile
method of setting which compiler was to be used.

PR Close #39046
This commit is contained in:
Joey Perrott 2020-09-29 08:13:47 -07:00 committed by Alex Rickabaugh
parent e8084ff906
commit 1e3f810f8f
1 changed files with 0 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
packages/bazel/src/ng_module.bzl
View File

@ -47,14 +47,6 @@ def is_ivy_enabled(ctx):
ctx.attr._renderer[BuildSettingInfo].value == "ivy")): ctx.attr._renderer[BuildSettingInfo].value == "ivy")):
return True return True
# TODO(josephperott): Remove after ~Feb 2020, to allow local script migrations
if "compile" in ctx.var and ctx.workspace_name == "angular":
fail(
msg = "Setting ViewEngine/Ivy using --define=compile is deprecated, please use " +
"--config=ivy or --config=view-engine instead.",
attr = "ng_module",
)
# This attribute is only defined in google's private ng_module rule and not # This attribute is only defined in google's private ng_module rule and not
# available externally. For external users, this is effectively a no-op. # available externally. For external users, this is effectively a no-op.
if hasattr(ctx.attr, "ivy") and ctx.attr.ivy == True: if hasattr(ctx.attr, "ivy") and ctx.attr.ivy == True: