honeymoose
/
angular-cn
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Revert "build: derive ts_library dep from jasmine_node_test boostrap label if it ends in `_es5` (#34589)" (#34730) 

This reverts commit 79a0d007b4.

PR Close #34730
This commit is contained in:
atscott 2020-01-10 13:39:37 -08:00
parent 88c7dfefe6
commit 24679d8676
42 changed files with 50 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
packages/animations/browser/test/BUILD.bazel
View File

@ -19,6 +19,7 @@ jasmine_node_test(
bootstrap = ["//tools/testing:node_es5"],
deps = [
":test_lib",
"//tools/testing:node",
],
)

1
packages/animations/test/BUILD.bazel
View File

@ -16,6 +16,7 @@ jasmine_node_test(
bootstrap = ["//tools/testing:node_es5"],
deps = [
":test_lib",
"//tools/testing:node",
],
)

1
packages/bazel/src/schematics/BUILD.bazel
View File

@ -17,5 +17,6 @@ jasmine_node_test(
"//packages/bazel/src/schematics/ng-add:test",
"//packages/bazel/src/schematics/ng-new:test",
"//packages/bazel/src/schematics/utility:test",
"//tools/testing:node",
],
)

1
packages/benchpress/test/BUILD.bazel
View File

@ -20,6 +20,7 @@ jasmine_node_test(
":test_lib",
"//packages/benchpress",
"//packages/core/testing",
"//tools/testing:node",
"@npm//protractor",
],
)

1
packages/common/http/test/BUILD.bazel
View File

@ -22,6 +22,7 @@ jasmine_node_test(
bootstrap = ["//tools/testing:node_es5"],
deps = [
":test_lib",
"//tools/testing:node",
],
)

1
packages/common/http/testing/test/BUILD.bazel
View File

@ -20,6 +20,7 @@ jasmine_node_test(
bootstrap = ["//tools/testing:node_es5"],
deps = [
":test_lib",
"//tools/testing:node",
],
)

1
packages/common/test/BUILD.bazel
View File

@ -27,6 +27,7 @@ jasmine_node_test(
bootstrap = ["//tools/testing:node_es5"],
deps = [
":test_lib",
"//tools/testing:node",
],
)

1
packages/common/upgrade/test/BUILD.bazel
View File

@ -19,5 +19,6 @@ jasmine_node_test(
bootstrap = ["//tools/testing:node_es5"],
deps = [
":test_lib",
"//tools/testing:node",
],
)

1
packages/compiler-cli/integrationtest/bazel/injectable_def/app/test/BUILD.bazel
View File

@ -27,5 +27,6 @@ jasmine_node_test(
"//packages/platform-server",
"//packages/platform-server/testing",
"//packages/private/testing",
"//tools/testing:node",
],
)

1
packages/compiler-cli/integrationtest/bazel/injector_def/ivy_build/app/test/BUILD.bazel
View File

@ -28,5 +28,6 @@ jasmine_node_test(
],
deps = [
":test_lib",
"//tools/testing:node",
],
)

4
packages/compiler-cli/test/BUILD.bazel
View File

@ -53,6 +53,7 @@ jasmine_node_test(
":extract_i18n_lib",
"//packages/common:npm_package",
"//packages/core",
"//tools/testing:node",
"@npm//minimist",
],
)
@ -90,6 +91,7 @@ jasmine_node_test(
deps = [
":ngc_lib",
"//packages/core",
"//tools/testing:node",
"@npm//minimist",
"@npm//rxjs",
"@npm//tsickle",
@ -121,6 +123,7 @@ jasmine_node_test(
deps = [
":perform_watch_lib",
"//packages/core",
"//tools/testing:node",
],
)
@ -147,5 +150,6 @@ jasmine_node_test(
deps = [
":perform_compile_lib",
"//packages/core",
"//tools/testing:node",
],
)

2
packages/compiler-cli/test/diagnostics/BUILD.bazel
View File

@ -28,6 +28,7 @@ jasmine_node_test(
deps = [
":check_types_lib",
"//packages/core",
"//tools/testing:node",
],
)
@ -47,5 +48,6 @@ jasmine_node_test(
bootstrap = ["//tools/testing:node_es5"],
deps = [
":typescript_version_lib",
"//tools/testing:node",
],
)

1
packages/compiler-cli/test/metadata/BUILD.bazel
View File

@ -22,5 +22,6 @@ jasmine_node_test(
deps = [
":test_lib",
"//packages/core",
"//tools/testing:node",
],
)

1
packages/compiler-cli/test/transformers/BUILD.bazel
View File

@ -33,6 +33,7 @@ jasmine_node_test(
deps = [
":test_lib",
"//packages/core",
"//tools/testing:node",
"@npm//source-map",
],
)

1
packages/compiler/test/BUILD.bazel
View File

@ -83,6 +83,7 @@ jasmine_node_test(
deps = [
":test_lib",
":test_node_only_lib",
"//tools/testing:node",
"@npm//base64-js",
"@npm//source-map",
],

1
packages/compiler/test/css_parser/BUILD.bazel
View File

@ -19,6 +19,7 @@ jasmine_node_test(
bootstrap = ["//tools/testing:node_es5"],
deps = [
":css_parser_lib",
"//tools/testing:node",
],
)

1
packages/compiler/test/expression_parser/BUILD.bazel
View File

@ -18,6 +18,7 @@ jasmine_node_test(
bootstrap = ["//tools/testing:node_es5"],
deps = [
":expression_parser_lib",
"//tools/testing:node",
],
)

1
packages/compiler/test/ml_parser/BUILD.bazel
View File

@ -16,6 +16,7 @@ jasmine_node_test(
bootstrap = ["//tools/testing:node_es5"],
deps = [
":ml_parser_lib",
"//tools/testing:node",
],
)

1
packages/compiler/test/render3/BUILD.bazel
View File

@ -21,5 +21,6 @@ jasmine_node_test(
bootstrap = ["//tools/testing:node_es5"],
deps = [
":test_lib",
"//tools/testing:node",
],
)

1
packages/compiler/test/selector/BUILD.bazel
View File

@ -20,6 +20,7 @@ jasmine_node_test(
bootstrap = ["//tools/testing:node_es5"],
deps = [
":selector_lib",
"//tools/testing:node",
],
)

1
packages/core/test/BUILD.bazel
View File

@ -67,6 +67,7 @@ jasmine_node_test(
"//packages/platform-server",
"//packages/platform-server/testing",
"//packages/zone.js/lib:zone_d_ts",
"//tools/testing:node",
"@npm//base64-js",
"@npm//source-map",
],

1
packages/core/test/acceptance/BUILD.bazel
View File

@ -41,6 +41,7 @@ jasmine_node_test(
deps = [
":acceptance_lib",
"//packages/zone.js/lib:zone_d_ts",
"//tools/testing:node",
"@npm//base64-js",
"@npm//source-map",
],

1
packages/core/test/render3/BUILD.bazel
View File

@ -63,6 +63,7 @@ jasmine_node_test(
name = "render3",
bootstrap = [":domino_es5"],
deps = [
":domino",
":render3_node_lib",
"//packages/zone.js/lib",
],

1
packages/core/test/render3/ivy/BUILD.bazel
View File

@ -22,6 +22,7 @@ jasmine_node_test(
],
deps = [
":ivy_lib",
"//packages/core/test/render3:domino",
"//packages/zone.js/lib",
],
)

1
packages/core/test/strict_types/BUILD.bazel
View File

@ -27,5 +27,6 @@ jasmine_node_test(
name = "strict_types",
deps = [
":strict_types_lib",
"//tools/testing:node",
],
)

1
packages/core/test/view/BUILD.bazel
View File

@ -41,6 +41,7 @@ jasmine_node_test(
deps = [
":view_lib",
":view_node_only_lib",
"//tools/testing:node",
],
)

1
packages/examples/core/BUILD.bazel
View File

@ -81,5 +81,6 @@ jasmine_node_test(
bootstrap = ["//tools/testing:node_es5"],
deps = [
":core_tests_lib",
"//tools/testing:node",
],
)

1
packages/examples/core/testing/ts/BUILD.bazel
View File

@ -18,5 +18,6 @@ jasmine_node_test(
bootstrap = ["//tools/testing:node_es5"],
deps = [
":fake_async_lib",
"//tools/testing:node",
],
)

1
packages/forms/test/BUILD.bazel
View File

@ -23,6 +23,7 @@ jasmine_node_test(
bootstrap = ["//tools/testing:node_es5"],
deps = [
":test_lib",
"//tools/testing:node",
],
)

1
packages/http/test/BUILD.bazel
View File

@ -23,6 +23,7 @@ jasmine_node_test(
bootstrap = ["//tools/testing:node_es5"],
deps = [
":test_lib",
"//tools/testing:node",
],
)

1
packages/localize/schematics/ng-add/BUILD.bazel
View File

@ -46,5 +46,6 @@ jasmine_node_test(
bootstrap = ["//tools/testing:node_es5"],
deps = [
":test_lib",
"//tools/testing:node",
],
)

1
packages/platform-browser-dynamic/test/BUILD.bazel
View File

@ -21,6 +21,7 @@ jasmine_node_test(
bootstrap = ["//tools/testing:node_es5"],
deps = [
":test_lib",
"//tools/testing:node",
],
)

1
packages/platform-browser/animations/test/BUILD.bazel
View File

@ -27,6 +27,7 @@ jasmine_node_test(
bootstrap = ["//tools/testing:node_es5"],
deps = [
":test_lib",
"//tools/testing:node",
],
)

1
packages/platform-browser/test/BUILD.bazel
View File

@ -32,6 +32,7 @@ jasmine_node_test(
bootstrap = ["//tools/testing:node_es5"],
deps = [
":test_lib",
"//tools/testing:node",
],
)

1
packages/platform-server/test/BUILD.bazel
View File

@ -27,5 +27,6 @@ jasmine_node_test(
],
deps = [
":test_lib",
"//tools/testing:node",
],
)

1
packages/platform-webworker/test/BUILD.bazel
View File

@ -24,6 +24,7 @@ jasmine_node_test(
bootstrap = ["//tools/testing:node_es5"],
deps = [
":test_lib",
"//tools/testing:node",
],
)

1
packages/router/test/BUILD.bazel
View File

@ -26,6 +26,7 @@ jasmine_node_test(
bootstrap = ["//tools/testing:node_es5"],
deps = [
":test_lib",
"//tools/testing:node",
],
)

1
packages/router/test/aot_ngsummary_test/BUILD.bazel
View File

@ -30,5 +30,6 @@ jasmine_node_test(
bootstrap = ["//tools/testing:node_es5"],
deps = [
":aot_test_lib",
"//tools/testing:node",
],
)

1
packages/service-worker/config/test/BUILD.bazel
View File

@ -19,5 +19,6 @@ jasmine_node_test(
":test_lib",
"//packages/service-worker/config",
"//packages/service-worker/config/testing",
"//tools/testing:node",
],
)

1
packages/service-worker/test/BUILD.bazel
View File

@ -21,6 +21,7 @@ jasmine_node_test(
bootstrap = ["//tools/testing:node_es5"],
deps = [
":test_lib",
"//tools/testing:node",
],
)

6
packages/zone.js/test/BUILD.bazel
View File

@ -206,11 +206,17 @@ jasmine_node_test(
jasmine_node_test(
name = "test_node_error_disable_policy",
bootstrap = [":node_error_disable_policy_entry_point_es5"],
deps = [
":node_error_disable_policy_entry_point",
],
)
jasmine_node_test(
name = "test_node_error_lazy_policy",
bootstrap = [":node_error_lazy_policy_entry_point_es5"],
deps = [
":node_error_lazy_policy_entry_point",
],
)
ts_library(

5
tools/defaults.bzl
View File

@ -281,11 +281,6 @@ def jasmine_node_test(bootstrap = [], **kwargs):
for label in bootstrap:
deps += [label]
templated_args += ["--node_options=--require=$(rlocation $(location %s))" % label]
if label.endswith("_es5"):
# If this label is a filegroup derived from a ts_library then automtically
# add the ts_library target (which is the label sans `_es5`) to deps so we pull
# in all of its transitive deps
deps += [label[:-4]]
_jasmine_node_test(
deps = deps,