fix(router): make setUpLocationChangeListener idempotent
This commit is contained in:
parent
307c4693dc
commit
25e5b2fdf0
|
@ -382,6 +382,7 @@ export class Router {
|
|||
setUpLocationChangeListener(): void {
|
||||
// Zone.current.wrap is needed because of the issue with RxJS scheduler,
|
||||
// which does not work properly with zone.js in IE and Safari
|
||||
if (!this.locationSubscription) {
|
||||
this.locationSubscription = <any>this.location.subscribe(Zone.current.wrap((change: any) => {
|
||||
const rawUrlTree = this.urlSerializer.parse(change['url']);
|
||||
const lastNavigation = this.navigations.value;
|
||||
|
@ -400,6 +401,7 @@ export class Router {
|
|||
}, 0);
|
||||
}));
|
||||
}
|
||||
}
|
||||
|
||||
/**
|
||||
* Returns the current route state.
|
||||
|
@ -443,7 +445,12 @@ export class Router {
|
|||
/**
|
||||
* Disposes of the router.
|
||||
*/
|
||||
dispose(): void { this.locationSubscription.unsubscribe(); }
|
||||
dispose(): void {
|
||||
if (this.locationSubscription) {
|
||||
this.locationSubscription.unsubscribe();
|
||||
this.locationSubscription = null;
|
||||
}
|
||||
}
|
||||
|
||||
/**
|
||||
* Applies an array of commands to the current url tree and creates a new url tree.
|
||||
|
|
|
@ -6,6 +6,7 @@
|
|||
* found in the LICENSE file at https://angular.io/license
|
||||
*/
|
||||
|
||||
import {Location} from '@angular/common';
|
||||
import {TestBed} from '@angular/core/testing';
|
||||
|
||||
import {ResolveData} from '../src/config';
|
||||
|
@ -32,6 +33,28 @@ describe('Router', () => {
|
|||
});
|
||||
});
|
||||
|
||||
describe('setUpLocationChangeListener', () => {
|
||||
beforeEach(() => { TestBed.configureTestingModule({imports: [RouterTestingModule]}); });
|
||||
|
||||
it('should be indempotent', () => {
|
||||
const r: Router = TestBed.get(Router);
|
||||
const location: Location = TestBed.get(Location);
|
||||
|
||||
r.setUpLocationChangeListener();
|
||||
const a = (<any>r).locationSubscription;
|
||||
r.setUpLocationChangeListener();
|
||||
const b = (<any>r).locationSubscription;
|
||||
|
||||
expect(a).toBe(b);
|
||||
|
||||
r.dispose();
|
||||
r.setUpLocationChangeListener();
|
||||
const c = (<any>r).locationSubscription;
|
||||
|
||||
expect(c).not.toBe(b);
|
||||
});
|
||||
});
|
||||
|
||||
describe('PreActivation', () => {
|
||||
const serializer = new DefaultUrlSerializer();
|
||||
const inj = {get: (token: any) => () => `${token}_value`};
|
||||
|
|
Loading…
Reference in New Issue